linux.git/drivers/usb/musb, branch v3.14

usb: musb: correct use of schedule_delayed_work()

2014-02-20T15:17:24+00:00

schedule_delayed_work() takes the delay in jiffies, not msecs.

This bug slipped in with the recent reset logic cleanup
(8ed1fb790ea: "usb: musb: finish suspend/reset work independently from
musb_hub_control()").

Signed-off-by: Daniel Mack 
Signed-off-by: Felipe Balbi

usb: musb: do not sleep in atomic context

2014-02-18T16:34:07+00:00

musb_port_reset() is called from musb_hub_control() which in turn holds
a spinlock, so musb_port_reset() is not allowed to call msleep().

With the asynchronous work helpers in place, this is fortunately easy to
fix by rescheduling the reset deassertion function to after the time
when the wait period is finished.

Note, however, that the MUSB_POWER_RESUME bit is only set on AM33xx
processors under rare conditions such as when to another driver
reporting an error during suspend. Hence, this didn't hit me yet in
normal operation.

Signed-off-by: Daniel Mack 
Signed-off-by: Felipe Balbi

usb: musb: core: Fix remote-wakeup resume

2014-02-18T16:32:26+00:00

During resume don't touch SUSPENDM/RESUME bits of POWER register
while restoring controller context. These bits might be changed
by the controller during resume operation and so will be different
than what they were during suspend.

e.g. SUSPENDM bit is set by software during USB global suspend but
automatically cleared by the controller during remote wakeup or
during resume. Setting this bit back while restoring context
causes undesired behaviour. i.e. Babble interrupt is generated
and USB is broken.

Signed-off-by: Roger Quadros 
Signed-off-by: Felipe Balbi

usb: musb: host: Fix SuperSpeed hub enumeration

2014-02-18T16:32:23+00:00

Disables PING on status phase of control transfer.
PING token is not mandatory in status phase of control transfer
and so some high speed USB devices don't support it. If such devices
are connected to MUSB then they would not respond to PING token
causing delayed or failed enumeration.

[Roger Q] Fixes enumeration issues with some Super-Speed USB hubs
e.g. Dlink DUB-1340

Signed-off-by: Ajay Kumar Gupta 
Signed-off-by: Roger Quadros 
Signed-off-by: Felipe Balbi

usb: musb: fix obex in g_nokia.ko causing kernel panic

2014-02-18T15:38:11+00:00

phy_power_off() can, depending on the PHY being used,
start I2C transactions which shouldn't happen in
atomic context.

Current call to phy_power_off() inside omap2430_runtime
callbacks causes the following dump, as a fix, just don't
power off the PHY in runtime.

[   18.606414] [] (__schedule+0x5c/0x50c) from [] (schedule_timeout+0x1f4/0x25c)
[   18.623809] [] (schedule_timeout+0x1f4/0x25c) from [] (wait_for_common+0xc8/0x1ac)
[   18.649291] [] (wait_for_common+0xc8/0x1ac) from [] (omap_i2c_xfer+0x338/0x488)
[   18.674499] [] (omap_i2c_xfer+0x338/0x488) from [] (__i2c_transfer+0x40/0x74)
[   18.692047] [] (__i2c_transfer+0x40/0x74) from [] (i2c_transfer+0x6c/0x90)
[   18.709320] [] (i2c_transfer+0x6c/0x90) from [] (regmap_i2c_read+0x48/0x68)
[   18.726715] [] (regmap_i2c_read+0x48/0x68) from [] (_regmap_raw_read+0x128/0x220)
[   18.752685] [] (_regmap_raw_read+0x128/0x220) from [] (regmap_raw_read+0xa0/0x130)
[   18.779052] [] (regmap_raw_read+0xa0/0x130) from [] (regmap_bulk_read+0xf8/0x16c)
[   18.805694] [] (regmap_bulk_read+0xf8/0x16c) from [] (twl_i2c_read+0xa4/0xe0)
[   18.823730] [] (twl_i2c_read+0xa4/0xe0) from [] (__twl4030_phy_power.isra.12+0x1c/0x58)
[   18.850921] [] (__twl4030_phy_power.isra.12+0x1c/0x58) from []
(twl4030_phy_power.part.14+0x80/0xc8)
[   18.879699] [] (twl4030_phy_power.part.14+0x80/0xc8) from []
(twl4030_set_suspend+0x54/0x1e8)
[   18.908325] [] (twl4030_set_suspend+0x54/0x1e8) from []
(omap2430_runtime_resume+0x5c/0x64)
[   18.937042] [] (omap2430_runtime_resume+0x5c/0x64) from []
(pm_generic_runtime_resume+0x2c/0x38)
[   18.966461] [] (pm_generic_runtime_resume+0x2c/0x38) from [] (__rpm_callback+0x54/0x80)
[   18.995117] [] (__rpm_callback+0x54/0x80) from [] (rpm_callback+0x40/0x74)
[   19.013610] [] (rpm_callback+0x40/0x74) from [] (rpm_resume+0x448/0x63c)
[   19.031921] [] (rpm_resume+0x448/0x63c) from [] (rpm_resume+0x364/0x63c)
[   19.050140] [] (rpm_resume+0x364/0x63c) from [] (__pm_runtime_resume+0x48/0x74)
[   19.077728] [] (__pm_runtime_resume+0x48/0x74) from [] (musb_gadget_pullup+0x1c/0xb4)
[   19.105895] [] (musb_gadget_pullup+0x1c/0xb4) from [] (usb_function_deactivate+0x54/0xa4
[libcomposite])
[   19.135955] [] (usb_function_deactivate+0x54/0xa4 [libcomposite]) from []
(obex_bind+0x124/0x1d8 [usb_f_obex])
[   19.166870] [] (obex_bind+0x124/0x1d8 [usb_f_obex]) from [] (usb_add_function+0x58/0xf4
[libcomposite])
[   19.197143] [] (usb_add_function+0x58/0xf4 [libcomposite]) from []
(nokia_bind_config+0x204/0x250 [g_nokia])
[   19.227905] [] (nokia_bind_config+0x204/0x250 [g_nokia]) from [] (usb_add_config+0x28/0xc0
[libcomposite])
[   19.258483] [] (usb_add_config+0x28/0xc0 [libcomposite]) from [] (nokia_bind+0x9c/0x21c
[g_nokia])
[   19.288421] [] (nokia_bind+0x9c/0x21c [g_nokia]) from [] (composite_bind+0x74/0x180
[libcomposite])
[   19.318420] [] (composite_bind+0x74/0x180 [libcomposite]) from []
(udc_bind_to_driver+0x2c/0xc4)
[   19.348114] [] (udc_bind_to_driver+0x2c/0xc4) from [] (usb_gadget_probe_driver+0x74/0x94)
[   19.377166] [] (usb_gadget_probe_driver+0x74/0x94) from [] (do_one_initcall+0x94/0x138)
[   19.406005] [] (do_one_initcall+0x94/0x138) from [] (load_module+0x113c/0x13c4)
[   19.434051] [] (load_module+0x113c/0x13c4) from [] (SyS_init_module+0xcc/0xec)
[   19.462127] [] (SyS_init_module+0xcc/0xec) from [] (ret_fast_syscall+0x0/0x30)
[   19.490753] Code: 0a00002e e1a00004 eb001438 e598300c (e5d3202c)
[   19.506805] ---[ end trace 060b62ec0d68a78b ]---
[   19.523132] Kernel panic - not syncing: Fatal exception in interrupt

dump is from 3.12-rc5 kernel

Reported-by: Pali Rohár 
Signed-off-by: Ivaylo Dimitrov 
Signed-off-by: Felipe Balbi

usb: delete non-required instances of include

2014-01-08T23:01:39+00:00

None of these files are actually using any __init type directives
and hence don't need to include .  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Greg Kroah-Hartman

USB: musb: correct spelling mistakes in comment and error string

2014-01-03T20:39:31+00:00

Signed-off-by: Rahul Bedarkar 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'usb-for-v3.14' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next

2014-01-03T20:15:10+00:00

Felipe writes:

usb: changes for v3.14 merge window

This pull request is quite extensive, containing
105 non-merge commits. Because of that, we describe
the changes in sections below:

New drivers:
	- Keystone PHY driver and DWC3 Glue Layer
	- Aeroflex Gaisler GRUSBDC
	- Tahvo PHY driver for N770
	- JZ4740 MUSB gluer Layer
	- Broadcom PHY Driver

Important new features:
	- MUSB DSPS learned about suspend/resume
	- New quirk_ep_out_aligned_size flag added to struct usb_gadget
	- DWC3 initializes the new quirk flag so gadget drivers can use it.
	- AM335x PHY Driver learns about remote wakeup
	- Renesas USBHS now requests DMA Engine only once
	- s3c-hsotg is now re-used on Broadcom devices
	- USB PHY layer now makes sure to initialize the notifier for all
		drivers
	- omap-control learned about TI's new AM437x devices
	- few other usb gadget/function drivers learned about the new
		configfs-based binding.

Misc Fixes and Clean Ups:
	- Several sparse fixes all over the place
	- Removal of redundant of_match_ptr()
	- r-car gen2 phy now uses usb_add_phy_dev()
	- removal of DEFINE_PCI_DEVICE_TABLE() from a few drivers
	- conversion to clk_prepare/clk_unprepare on r8a66597-udc
	- some randconfig errors and build warnings were fixed
	- removal of unnecessary lock on dwc3-omap.c

Signed-of-by: Felipe Balbi

usb: musb: Remove usb_disable() check in module_init()

2013-12-26T16:17:40+00:00

Removing the check to usb_disable() before registering the platform
driver allows to build this driver when !USB && USB_GADGET, to be
used in gadget-only mode.

Also, use module_platform_driver() to register the platform driver.

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Felipe Balbi

usb: musb: Rework USB and USB_GADGET dependency

2013-12-23T16:28:56+00:00

This USB controller can work in as host-only, gadget-only or dual-role
modes. Rework the dependency on the USB and USB_GADGET configs in order
to allow building the driver when !USB or !USG_GADGET.

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Felipe Balbi