linux.git/drivers/usb/misc/usblcd.c, branch v2.6.34

USB: Push BKL on open down into the drivers

2010-03-02T22:54:23+00:00

Straightforward push into the drivers to allow
auditing individual drivers separately

Signed-off-by: Oliver Neukum 
Acked-by: Mauro Carvalho Chehab 
Cc: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

USB misc: make USB device id constant

2010-03-02T22:54:17+00:00

The id_table field of the struct usb_device_id is constant in 
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// 

Signed-off-by: Németh Márton 
Cc: Julia Lawall 
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman

USB: usblcd, fix memory leak

2009-10-09T20:52:06+00:00

Stanse found a memory leak in lcd_probe. Instead of returning without
releasing the memory, jump to the error label which frees it.

http://stanse.fi.muni.cz/

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

headers: smp_lock.h redux

2009-07-12T19:22:34+00:00

* Remove smp_lock.h from files which don't need it (including some headers!)
* Add smp_lock.h to files which do need it
* Make smp_lock.h include conditional in hardirq.h
  It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPT

  This will make hardirq.h inclusion cheaper for every PREEMPT=n config
  (which includes allmodconfig/allyesconfig, BTW)

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds

USB: remove info() macro from usb/misc drivers

2008-10-17T21:41:09+00:00

USB should not be having it's own printk macros, so remove info() and
use the system-wide standard of dev_info() wherever possible.

Signed-off-by: Greg Kroah-Hartman

USB: remove warn() macro from usb drivers

2008-10-17T21:41:09+00:00

USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible.  In the
few places that will not work out, use a basic printk().

Signed-off-by: Greg Kroah-Hartman

USB: usblcd: Push down BKL into driver

2008-07-21T22:16:18+00:00

I'm pretty sure this can be eliminated however I couldn't prove (or find)
what stopped the device vanishing mid IOCTL_GET_HARD_VERSION. Perhaps a
USB wizard could double check that and see if the lock_kernel can go
entirely.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: remove unnecessary type casting of urb->context

2008-04-25T04:16:55+00:00

urb->context code cleanup

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

USB: replace remaining FUNCTION occurrences