linux.git/drivers/usb/misc/usblcd.c, branch v2.6.31

headers: smp_lock.h redux

2009-07-12T19:22:34+00:00

* Remove smp_lock.h from files which don't need it (including some headers!)
* Add smp_lock.h to files which do need it
* Make smp_lock.h include conditional in hardirq.h
  It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPT

  This will make hardirq.h inclusion cheaper for every PREEMPT=n config
  (which includes allmodconfig/allyesconfig, BTW)

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds

USB: remove info() macro from usb/misc drivers

2008-10-17T21:41:09+00:00

USB should not be having it's own printk macros, so remove info() and
use the system-wide standard of dev_info() wherever possible.

Signed-off-by: Greg Kroah-Hartman

USB: remove warn() macro from usb drivers

2008-10-17T21:41:09+00:00

USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible.  In the
few places that will not work out, use a basic printk().

Signed-off-by: Greg Kroah-Hartman

USB: usblcd: Push down BKL into driver

2008-07-21T22:16:18+00:00

I'm pretty sure this can be eliminated however I couldn't prove (or find)
what stopped the device vanishing mid IOCTL_GET_HARD_VERSION. Perhaps a
USB wizard could double check that and see if the lock_kernel can go
entirely.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: remove unnecessary type casting of urb->context

2008-04-25T04:16:55+00:00

urb->context code cleanup

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

USB: replace remaining FUNCTION occurrences

2008-04-25T04:16:55+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Greg Kroah-Hartman

USB: open disconnect race in usblcd

2007-10-25T19:18:46+00:00

this driver has a possible use after free due to a race when disconnect
and open handle intfdata without a lock.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: misc: usblcd: clean up urb->status usage

2007-07-20T00:46:08+00:00

This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: Greg Kroah-Hartman

USB: autosuspend for usblcd

2007-07-12T23:34:38+00:00

this patch implements autosuspend for the usblcd driver. It uses
the new usb_anchor infrastructure. Many thanks to Georges for testing.

Signed-off-by: Oliver Neukum 
Cc: Georges Toth 
Signed-off-by: Greg Kroah-Hartman

USB: prevent char device open/deregister race

2007-07-12T23:29:48+00:00

This patch (as908) adds central protection in usbcore for the
prototypical race between opening and unregistering a char device.
The spinlock used to protect the minor-numbers array is replaced with
an rwsem, which can remain locked across a call to a driver's open()
method.  This guarantees that open() and deregister() will be mutually
exclusive.

The private locks currently used in several individual drivers for
this purpose are no longer necessary, and the patch removes them.  The
following USB drivers are affected: usblcd, idmouse, auerswald,
legousbtower, sisusbvga/sisusb, ldusb, adutux, iowarrior, and
usb-skeleton.

As a side effect of this change, usb_deregister_dev() must not be
called while holding a lock that is acquired by open().  Unfortunately
a number of drivers do this, but luckily the solution is simple: call
usb_deregister_dev() before acquiring the lock.

In addition to these changes (and their consequent code
simplifications), the patch fixes a use-after-free bug in adutux and a
race between open() and release() in iowarrior.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman