linux.git/drivers/usb/host, branch v2.6.33

USB: FHCI: Fix build after kfifo rework

2010-02-16T23:11:07+00:00

After kfifo rework FHCI fails to build:

  CC      drivers/usb/host/fhci-tds.o
drivers/usb/host/fhci-tds.c: In function 'fhci_ep0_free':
drivers/usb/host/fhci-tds.c:108: error: used struct type value where scalar is required
drivers/usb/host/fhci-tds.c:118: error: used struct type value where scalar is required
drivers/usb/host/fhci-tds.c:128: error: used struct type value where scalar is required

This is because kfifos are no longer pointers in the ep struct.
So, instead of checking the pointers, we should now check if kfifo
is initialized.

Reported-by: Josh Boyer 
Signed-off-by: Anton Vorontsov 
Acked-by: Stefani Seibold 
Signed-off-by: Greg Kroah-Hartman

USB: ehci: phy low power mode bug fixing

2010-02-16T23:11:04+00:00

1. There are two msleep calls inside two spin lock sections, need to unlock
   and lock again after msleep.
2. Save a extra status reg setting.

Signed-off-by: Alek Du 
Signed-off-by: Greg Kroah-Hartman

usb: r8a66597-hcd: Fix up spinlock recursion in root hub polling.

2010-02-05T02:53:28+00:00

The current root hub polling code exhibits a spinlock recursion on the
private controller lock. r8a66597_root_hub_control() is called from
r8a66597_timer() which grabs the lock and disables IRQs. The following
chain emerges:

  r8a66597_timer() <-- lock taken
    r8a66597_root_hub_control()
      r8a66597_check_syssts()
        usb_hcd_poll_rh_status() <-- acquires the same lock
	/* insert death here */

The entire chain requires IRQs to be disabled, so we just unlock and
relock around the call to usb_hcd_poll_rh_status() while leaving the
IRQ state unchanged.

Signed-off-by: Paul Mundt 
Acked-by: Yoshihiro Shimoda

usb: r8a66597-hcd: Flush the D-cache for the pipe-in transfer buffers.

2010-02-05T02:53:25+00:00

This implements the same D-cache flushing logic for r8a66597-hcd as
Catalin's isp1760 (http://patchwork.kernel.org/patch/76391/) change,
with the same note applying here as well:

    When the HDC driver writes the data to the transfer buffers it
    pollutes the D-cache (unlike DMA drivers where the device writes
    the data). If the corresponding pages get mapped into user space,
    there are no additional cache flushing operations performed and
    this causes random user space faults on architectures with
    separate I and D caches (Harvard) or those with aliasing D-cache.

This fixes up crashes during USB boot on SH7724 and others:

	http://marc.info/?l=linux-sh&m=126439837308912&w=2

Reported-by: Goda Yusuke 
Tested-by: Goda Yusuke 
Cc: stable@kernel.org
Signed-off-by: Paul Mundt 
Acked-by: Yoshihiro Shimoda

usb: r8a66597-hdc disable interrupts fix

2010-02-02T02:30:45+00:00

This patch improves disable_controller() in the r8a66597-hdc
driver to disable all interrupts and clear status flags. It
also makes sure that disable_controller() is called during
probe(). This fixes the relatively rare case of unexpected
pending interrupts after kexec reboot.

Signed-off-by: Magnus Damm 
Acked-by: Yoshihiro Shimoda 
Signed-off-by: Paul Mundt

USB: isp1362: fix build failure on ARM systems via irq_flags cleanup

2010-01-20T23:24:36+00:00

There was some left over #ifdef ARM logic that is outdated but no one
really noticed.  So instead of relying on this tricky logic, properly
load and utilize the platform irq_flags resources.

Reported-by: Ben Hutchings 
Signed-off-by: Lothar Wassmann 
Signed-off-by: Mike Frysinger 
Signed-off-by: Greg Kroah-Hartman

USB: isp1362: better 64bit printf warning fixes

2010-01-20T23:24:35+00:00

Some hosts that treat the return value of sizeof differently from unsigned
long might still hit warnings.  So use %zu for sizeof() values.  This is a
better version of the previous commit b0a9cf297e58721933.

Signed-off-by: Lothar Wassmann 
Signed-off-by: Mike Frysinger 
Signed-off-by: Greg Kroah-Hartman

USB: Fix level of isp1760 Reloading ptd error message

2010-01-20T23:24:35+00:00

This error message is not actually an error, it's an information
message. It is triggered when a transfer which ended in a NAQ is
retried successfully by the hardware.

Signed-off-by: Colin Tuckley 
Cc: Sebastian Andrzej Siewior 
Cc: Catalin Marinas 
Signed-off-by: Greg Kroah-Hartman

USB: FHCI: avoid NULL pointer dereference

2010-01-20T23:24:35+00:00

Assign fhci only if usb is not NULL.

Signed-off-by: Alexander Beregalov 
Signed-off-by: Greg Kroah-Hartman

USB: add missing delay during remote wakeup

2010-01-20T23:24:34+00:00

This patch (as1330) fixes a bug in khbud's handling of remote
wakeups.  When a device sends a remote-wakeup request, the parent hub
(or the host controller driver, for directly attached devices) begins
the resume sequence and notifies khubd when the sequence finishes.  At
this point the port's SUSPEND feature is automatically turned off.

However the device needs an additional 10-ms resume-recovery time
(TRSMRCY in the USB spec).  Khubd does not wait for this delay if the
SUSPEND feature is off, and as a result some devices fail to behave
properly following a remote wakeup.  This patch adds the missing
delay to the remote-wakeup path.

It also extends the resume-signalling delay used by ehci-hcd and
uhci-hcd from 20 ms (the value in the spec) to 25 ms (the value we use
for non-remote-wakeup resumes).  The extra time appears to help some
devices.

Signed-off-by: Alan Stern 
Cc: stable 
Cc: Rickard Bellini 
Signed-off-by: Greg Kroah-Hartman