linux.git/drivers/usb/gadget, branch v4.9

usb: gadget: f_fs: fix wrong parenthesis in ffs_func_req_match()

2016-11-18T11:50:37+00:00

Properly check the return code of ffs_func_revmap_intf() and
ffs_func_revmap_ep() for a non-negative value.

Instead of checking the return code, the comparison was performed for the last
parameter of the function calls, because of wrong parenthesis.

This also fixes the following static checker warning:
drivers/usb/gadget/function/f_fs.c:3152 ffs_func_req_match()
warn: always true condition '(((creq->wIndex)) >= 0) => (0-u16max >= 0)'

Reported-by: Dan Carpenter 
Signed-off-by: Felix Hädicke 
Signed-off-by: Felipe Balbi

usb: gadget: u_ether: remove interrupt throttling

2016-11-01T13:48:25+00:00

According to Dave Miller "the networking stack has a
hard requirement that all SKBs which are transmitted
must have their completion signalled in a fininte
amount of time. This is because, until the SKB is
freed by the driver, it holds onto socket,
netfilter, and other subsystem resources."

In summary, this means that using TX IRQ throttling
for the networking gadgets is, at least, complex and
we should avoid it for the time being.

Cc: 
Reported-by: Ville Syrjälä 
Tested-by: Ville Syrjälä 
Suggested-by: David Miller 
Signed-off-by: Felipe Balbi

usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable

2016-10-17T09:34:25+00:00

ffs_func_eps_disable is called from atomic context so it cannot sleep
thus cannot grab a mutex.  Change the handling of epfile->read_buffer
to use non-sleeping synchronisation method.

Reported-by: Chen Yu 
Signed-off-by: Michał Nazarewicz 
Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests")
Tested-by: John Stultz 
Tested-by: Chen Yu 
Signed-off-by: Felipe Balbi

usb: gadget: f_fs: edit epfile->ep under lock

2016-10-17T09:34:08+00:00

epfile->ep is protected by ffs->eps_lock (not epfile->mutex) so clear it
while holding the spin lock.

Tested-by: John Stultz 
Tested-by: Chen Yu 
Signed-off-by: Michal Nazarewicz 
Signed-off-by: Felipe Balbi

usb: gadget: function: u_ether: don't starve tx request queue

2016-10-17T08:14:00+00:00

If we don't guarantee that we will always get an
interrupt at least when we're queueing our very last
request, we could fall into situation where we queue
every request with 'no_interrupt' set. This will
cause the link to get stuck.

The behavior above has been triggered with g_ether
and dwc3.

Cc: 
Reported-by: Ville Syrjälä 
Signed-off-by: Felipe Balbi

usb: gadget: udc: atmel: fix endpoint name

2016-10-17T08:13:21+00:00

Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"),
atmel_usba_udc fails with:

------------[ cut here ]------------
WARNING: CPU: 0 PID: 0 at include/linux/usb/gadget.h:405
ecm_do_notify+0x188/0x1a0
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted 4.7.0+ #15
Hardware name: Atmel SAMA5
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (__warn+0xe4/0xfc)
[] (__warn) from [] (warn_slowpath_null+0x20/0x28)
[] (warn_slowpath_null) from [] (ecm_do_notify+0x188/0x1a0)
[] (ecm_do_notify) from [] (ecm_set_alt+0x74/0x1ac)
[] (ecm_set_alt) from [] (composite_setup+0xfc0/0x19f8)
[] (composite_setup) from [] (usba_udc_irq+0x8f4/0xd9c)
[] (usba_udc_irq) from [] (handle_irq_event_percpu+0x9c/0x158)
[] (handle_irq_event_percpu) from [] (handle_irq_event+0x28/0x3c)
[] (handle_irq_event) from [] (handle_fasteoi_irq+0xa0/0x168)
[] (handle_fasteoi_irq) from [] (generic_handle_irq+0x24/0x34)
[] (generic_handle_irq) from [] (__handle_domain_irq+0x54/0xa8)
[] (__handle_domain_irq) from [] (__irq_svc+0x54/0x70)
[] (__irq_svc) from [] (arch_cpu_idle+0x38/0x3c)
[] (arch_cpu_idle) from [] (cpu_startup_entry+0x9c/0xdc)
[] (cpu_startup_entry) from [] (start_kernel+0x354/0x360)
[] (start_kernel) from [<20008078>] (0x20008078)
---[ end trace e7cf9dcebf4815a6 ]---

Fixes: c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes")
Cc: 
Reported-by: Richard Genoud 
Acked-by: Nicolas Ferre 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Felipe Balbi

treewide: remove redundant #include

2016-10-11T22:06:33+00:00

Kernel source files need not include  explicitly
because the top Makefile forces to include it with:

  -include $(srctree)/include/linux/kconfig.h

This commit removes explicit includes except the following:

  * arch/s390/include/asm/facilities_src.h
  * tools/testing/radix-tree/linux/kernel.h

These two are used for host programs.

Link: http://lkml.kernel.org/r/1473656164-11929-1-git-send-email-yamada.masahiro@socionext.com
Signed-off-by: Masahiro Yamada 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2016-10-11T03:16:43+00:00

Pull more vfs updates from Al Viro:
 ">rename2() work from Miklos + current_time() from Deepa"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  fs: Replace current_fs_time() with current_time()
  fs: Replace CURRENT_TIME_SEC with current_time() for inode timestamps
  fs: Replace CURRENT_TIME with current_time() for inode timestamps
  fs: proc: Delete inode time initializations in proc_alloc_inode()
  vfs: Add current_time() api
  vfs: add note about i_op->rename changes to porting
  fs: rename "rename2" i_op to "rename"
  vfs: remove unused i_op->rename
  fs: make remaining filesystems use .rename2
  libfs: support RENAME_NOREPLACE in simple_rename()
  fs: support RENAME_NOREPLACE for local filesystems
  ncpfs: fix unused variable warning

fs: Replace CURRENT_TIME with current_time() for inode timestamps

2016-09-28T01:06:21+00:00

CURRENT_TIME macro is not appropriate for filesystems as it
doesn't use the right granularity for filesystem timestamps.
Use current_time() instead.

CURRENT_TIME is also not y2038 safe.

This is also in preparation for the patch that transitions
vfs timestamps to use 64 bit time and hence make them
y2038 safe. As part of the effort current_time() will be
extended to do range checks. Hence, it is necessary for all
file system timestamps to use current_time(). Also,
current_time() will be transitioned along with vfs to be
y2038 safe.

Note that whenever a single call to current_time() is used
to change timestamps in different inodes, it is because they
share the same time granularity.

Signed-off-by: Deepa Dinamani 
Reviewed-by: Arnd Bergmann 
Acked-by: Felipe Balbi 
Acked-by: Steven Whitehouse 
Acked-by: Ryusuke Konishi 
Acked-by: David Sterba 
Signed-off-by: Al Viro

Revert "usb: gadget: NCM: Protect dev->port_usb using dev->lock"

2016-09-19T09:05:43+00:00

This reverts commit c9ffc78745f89e300fe704348dd8e6800acf4d18 as it was
reported to be broken.

Cc: Felipe Balbi 
Cc: Jim Baxter 
Cc: Harish Jenny K N 
Signed-off-by: Greg Kroah-Hartman