linux.git/drivers/usb/gadget/function/f_uvc.c, branch v5.13

usb: webcam: Invalid size of Processing Unit Descriptor

2021-03-18T08:02:27+00:00

According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.

Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds bmVideoStandards into
uvc_processing_unit_descriptor structure.

The bmVideoStandards field was added in UVC 1.1 and it wasn't part of
UVC 1.0a.

Reviewed-by: Laurent Pinchart 
Signed-off-by: Pawel Laszczak 
Reviewed-by: Peter Chen 
Link: https://lore.kernel.org/r/20210315071748.29706-1-pawell@gli-login.cadence.com
Signed-off-by: Greg Kroah-Hartman

usb: gadget: uvc: add bInterval checking for HS mode

2021-03-18T08:02:27+00:00

Patch adds extra checking for bInterval passed by configfs.
The 5.6.4 chapter of USB Specification (rev. 2.0) say:
"A high-bandwidth endpoint must specify a period of 1x125 µs
(i.e., a bInterval value of 1)."

The issue was observed during testing UVC class on CV.
I treat this change as improvement because we can control
bInterval by configfs.

Reviewed-by: Peter Chen 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Pawel Laszczak 
Link: https://lore.kernel.org/r/20210308125338.4824-1-pawell@gli-login.cadence.com
Signed-off-by: Greg Kroah-Hartman

usb: gadget: uvc: Fix the wrong v4l2_device_unregister call

2020-10-02T06:57:45+00:00

If an error occurred before calling the 'v4l2_device_register' func,
and then goto error, but no need to call 'v4l2_device_unregister'
func.

Signed-off-by: Zqiang 
Signed-off-by: Felipe Balbi

media: gadget: uvc: rename VFL_TYPE_GRABBER to _VIDEO

2020-02-24T15:52:45+00:00

'GRABBER' is a weird name, all other types map to the /dev
device names. Rename to 'VIDEO' to be consistent with the
other types.

Signed-off-by: Hans Verkuil 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Mauro Carvalho Chehab

media: usb/gadget/f_uvc: set device_caps in struct video_device

2019-06-05T12:47:44+00:00

Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.

That way the V4L2 core knows what the capabilities of the
video device are.

But this only really works if all drivers use this, so convert
this UVC gadget driver.

Signed-off-by: Hans Verkuil 
Reviewed-by: Laurent Pinchart 
Acked-by: Felipe Balbi 
Signed-off-by: Mauro Carvalho Chehab

usb: gadget: uvc: Remove uvc_set_trace_param() function

2018-09-25T15:48:07+00:00

The function is never called, remove it.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Kieran Bingham

usb: gadget: uvc: Replace plain printk() with dev_*()

2018-09-25T15:41:00+00:00

Adding device context to the kernel log messages make them more useful.
Add new uvcg_* macros based on dev_*() that print both the gadget device
name and the function name.

While at it, remove a commented out printk statement and an unused
printk-based macro.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Paul Elder 
Tested-by: Paul Elder 
Reviewed-by: Kieran Bingham

usb: gadget: uvc: configfs: Add interface number attributes

2018-09-24T15:54:26+00:00

The video control and video streaming interface numbers are needed in
the UVC gadget userspace stack to reply to UVC requests. They are
hardcoded to fixed values at the moment, preventing configurations with
multiple functions.

To fix this, make them dynamically discoverable by userspace through
read-only configfs attributes in /control/bInterfaceNumber and
/streaming/bInterfaceNumber respectively.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Kieran Bingham

usb: gadget: uvc: configfs: Allocate groups dynamically

2018-09-24T15:54:23+00:00

The UVC configfs implementation creates all groups as global static
variables. This prevents creation of multiple UVC function instances,
as they would all require their own configfs group instances.

Fix this by allocating all groups dynamically. To avoid duplicating code
around, extend the config_item_type structure with group name and
children, and implement helper functions to create children
automatically for most groups.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Kieran Bingham

usb: gadget: uvc: Expose configuration name through video node

2018-07-26T10:43:18+00:00

When utilising multiple instantiations of a UVC gadget on a composite
device, there is no clear method to link a particular configuration to
its respective video node.

Provide a means for identifying the correct video node by exposing the
name of the function configuration through sysfs.

Reviewed-by: Laurent Pinchart 
Signed-off-by: Kieran Bingham 
Signed-off-by: Felipe Balbi