linux.git/drivers/usb/gadget/function/f_midi.c, branch v3.19 Linux kernel source tree usb: gadget: fix misspelling of current function in string 2014-12-22T16:27:34+00:00 Julia Lawall Julia.Lawall@lip6.fr 2014-12-07T19:21:00+00:00 c9b3bde03b95cf1cab068f773435cfee271baf0b Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Felipe Balbi <balbi@ti.com> 
Replace a misspelled function name by %s and then __func__.

This was done using Coccinelle, including the use of Levenshtein distance,
as proposed by Rasmus Villemoes.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: midi: f_midi_alloc() can be static 2014-11-12T15:01:03+00:00 Fengguang Wu fengguang.wu@intel.com 2014-11-12T13:28:24+00:00 f509fee81fa205c664ea4e446b6d8a8caae38c35 drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static? drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static? drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static? Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static?
drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static?
drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: add configfs support 2014-11-05T19:37:17+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:31+00:00 6f1de344557315a8e5de0d15a28276198ca7fdac Make the midi function available for gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
Make the midi function available for gadgets composed with configfs.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: use usb_gstrings_attach 2014-11-05T19:36:20+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:30+00:00 9caa0d77f7ce6ca0ec6bb81e28a93db1b6287b0f In order to add configfs support the usb_gstrings_attach must be used. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
In order to add configfs support the usb_gstrings_attach must be used.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: remove compatibility layer 2014-11-05T19:36:17+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:29+00:00 33cfad66efbb72de0ebe72f554b31b6688957052 There are no old f_midi interface users left, so remove it. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
There are no old f_midi interface users left, so remove it.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: convert to new function interface with backward compatibility 2014-11-05T19:36:09+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:27+00:00 b85e9de9e818de0dcbc50b7b4242192eb6194855 Converting midi to the new function interface requires converting the USB midi's function code and its users. This patch converts the f_midi.c to the new function interface. The file can now be compiled into a separate usb_f_midi.ko module. The old function interface is provided by means of a preprocessor conditional directives. After all users are converted, the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
Converting midi to the new function interface requires converting
the USB midi's function code and its users.

This patch converts the f_midi.c to the new function interface.
The file can now be compiled into a separate usb_f_midi.ko module.

The old function interface is provided by means of a preprocessor
conditional directives. After all users are converted, the old interface
can be removed.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: check kstrdup() return value 2014-11-05T19:36:05+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:26+00:00 d23b4c3ee2d5cbdeaec9f8e7d8a9bdcc73836fb9 kstrdup() might fail, so check its return value and react appropriately. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
kstrdup() might fail, so check its return value and react appropriately.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: f_midi: enable use of the index parameter 2014-11-05T19:36:02+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-10-16T11:33:25+00:00 6e58ed578e2c65442b7a02deecc96e482c701654 The soundcard index to use for the ALSA device creation is passed as a parameter to f_midi_bind_config(), but is assigned to midi->index only after the call to f_midi_register_card(midi). So no matter what is passed to f_midi_bind_config(), the actual index for snd_card_new() is always 0. This probably works ok if at the moment of f_midi's bind there are no other snd_cards, but if there are, it is not possible to bind f_midi. This patch moves the assignment to a place before the call to f_midi_register_card(midi). Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
The soundcard index to use for the ALSA device creation is passed as a
parameter to f_midi_bind_config(), but is assigned to midi->index only
after the call to f_midi_register_card(midi). So no matter what is passed
to f_midi_bind_config(), the actual index for snd_card_new() is always 0.
This probably works ok if at the moment of f_midi's bind there are no
other snd_cards, but if there are, it is not possible to bind f_midi.

This patch moves the assignment to a place before the call to
f_midi_register_card(midi).

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
usb: gadget: Gadget directory cleanup - group usb functions 2014-07-16T17:50:36+00:00 Andrzej Pietrasiewicz andrzej.p@samsung.com 2014-07-15T11:09:46+00:00 00a2430ff07d4e0e0e7e24e02fd8adede333b797 The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the USB functions implementations into a separate directory. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 
The drivers/usb/gadget directory contains many files.
Files which are related can be distributed into separate directories.
This patch moves the USB functions implementations into a separate directory.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>