linux.git/drivers/usb/gadget/function/f_fs.c, branch v4.5

usb: gadget: functionfs: fix missing access_ok checks

2015-11-18T21:09:26+00:00

use safe copy_*_user instead of unsafe __copy_*_user
functions when accessing userland memory.

Signed-off-by: Daniel Walter 
Signed-off-by: Felipe Balbi

usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-31T13:57:57+00:00

Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates
usb request and increments refcounts. These things needs to be cleaned
up by if further steps of initialization fail by calling functionfs_unbind().

Signed-off-by: Robert Baldyga 
Acked-by: Michal Nazarewicz 
Signed-off-by: Felipe Balbi

usb: gadget: f_fs: do not set cancel function on synchronous {read,write}

2015-07-06T17:34:08+00:00

do not try to set cancel function in synchronous operations in
ffs_epfile_{read,write}_iter.

Cc:  # v4.0+
Acked-by: Al Viro 
Signed-off-by: Rui Miguel Silva 
Signed-off-by: Felipe Balbi

Merge 4.1-rc7 into usb-next

2015-06-08T17:57:51+00:00

This resolves a merge issue in musb_core.c and we want the fixes that
were in Linus's tree in this branch as well for testing.

Signed-off-by: Greg Kroah-Hartman

usb: gadget: f_fs: add extra check before unregister_gadget_item

2015-05-26T15:39:34+00:00

ffs_closed can race with configfs_rmdir which will call config_item_release, so
add an extra check to avoid calling the unregister_gadget_item with an null
gadget item.

Signed-off-by: Rui Miguel Silva 
Signed-off-by: Felipe Balbi

usb: gadget: f_fs: fix check in read operation

2015-05-26T15:20:57+00:00

when copying to iter the size can be different then the iov count,
the check for full iov is wrong and make any read on request which
is not the exactly size of iov to return -EFAULT.

So, just check the success of the copy.

Signed-off-by: Rui Miguel Silva 
Signed-off-by: Felipe Balbi

usb: gadget: ffs: fix: Always call ffs_closed() in ffs_data_clear()

2015-05-26T15:15:09+00:00

Originally FFS_FL_CALL_CLOSED_CALLBACK flag has been used to
indicate if we should call ffs_closed_callback().

Commit 4b187fceec3c ("usb: gadget: FunctionFS: add devices
management code") changed its semantic to indicate if we should
call ffs_closed() function which does a little bit more.

This situation leads to:

[  122.362269] ------------[ cut here ]------------
[  122.362287] WARNING: CPU: 2 PID: 2384 at drivers/usb/gadget/function/f_fs.c:3417 ffs_ep0_write+0x730/0x810 [usb_f_fs]()
[  122.362292] Modules linked in:
[  122.362555] CPU: 2 PID: 2384 Comm: adbd Tainted: G        W       4.1.0-0.rc4.git0.1.1.fc22.i686 #1
[  122.362561] Hardware name: To be filled by O.E.M. To be filled by O.E.M./Aptio CRB, BIOS 5.6.5 07/25/2014
[  122.362567]  c0d1f947 415badfa 00000000 d1029e64 c0a86e54 00000000 d1029e94 c045b937
[  122.362584]  c0c37f94 00000002 00000950 f9b313d4 00000d59 f9b2ebf0 f9b2ebf0 fffffff0
[  122.362600]  00000003 deb53d00 d1029ea4 c045ba42 00000009 00000000 d1029f08 f9b2ebf0
[  122.362617] Call Trace:
[  122.362633]  [] dump_stack+0x41/0x52
[  122.362645]  [] warn_slowpath_common+0x87/0xc0
[  122.362658]  [] ? ffs_ep0_write+0x730/0x810 [usb_f_fs]
[  122.362668]  [] ? ffs_ep0_write+0x730/0x810 [usb_f_fs]
[  122.362678]  [] warn_slowpath_null+0x22/0x30
[  122.362689]  [] ffs_ep0_write+0x730/0x810 [usb_f_fs]
[  122.362702]  [] ? ffs_ep0_read+0x380/0x380 [usb_f_fs]
[  122.362712]  [] __vfs_write+0x2f/0x100
[  122.362722]  [] ? __sb_start_write+0x52/0x110
[  122.362731]  [] vfs_write+0x94/0x1b0
[  122.362740]  [] ? mutex_lock+0x10/0x30
[  122.362749]  [] SyS_write+0x51/0xb0
[  122.362759]  [] sysenter_do_call+0x12/0x12
[  122.362766] ---[ end trace 0673d3467cecf8db ]---

in some cases (reproduction path below). This commit get back
semantic of that flag and ensures that ffs_closed() is called
always when needed but ffs_closed_callback() is called only
if this flag is set.

Reproduction path:
Compile kernel without any UDC driver or bound some gadget
to existing one and then:

$ modprobe g_ffs
$ mount none -t functionfs mount_point
$ ffs-example mount_point

This will fail with -ENODEV as there is no udc.

$ ffs-example mount_point

This will fail with -EBUSY because ffs_data has not been
properly cleaned up.

Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Felipe Balbi

make new_sync_{read,write}() static

2015-04-12T02:29:40+00:00

All places outside of core VFS that checked ->read and ->write for being NULL or
called the methods directly are gone now, so NULL {read,write} with non-NULL
{read,write}_iter will do the right thing in all cases.

Signed-off-by: Al Viro

fs: move struct kiocb to fs.h

2015-03-26T00:28:11+00:00

struct kiocb now is a generic I/O container, so move it to fs.h.
Also do a #include diet for aio.h while we're at it.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

fs: split generic and aio kiocb

2015-03-13T16:10:27+00:00

Most callers in the kernel want to perform synchronous file I/O, but
still have to bloat the stack with a full struct kiocb.  Split out
the parts needed in filesystem code from those in the aio code, and
only allocate those needed to pass down argument on the stack.  The
aio code embedds the generic iocb in the one it allocates and can
easily get back to it by using container_of.

Also add a ->ki_complete method to struct kiocb, this is used to call
into the aio code and thus removes the dependency on aio for filesystems
impementing asynchronous operations.  It will also allow other callers
to substitute their own completion callback.

We also add a new ->ki_flags field to work around the nasty layering
violation recently introduced in commit 5e33f6 ("usb: gadget: ffs: add
eventfd notification about ffs events").

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro