linux.git/drivers/usb/dwc3, branch v4.18

usb: dwc3: gadget: remove redundant variable maxpacket

2018-07-17T07:12:51+00:00

Variable maxpacket is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'maxpacket' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
Signed-off-by: Felipe Balbi

usb: dwc3: qcom: mark PM functions as __maybe_unused

2018-06-19T09:48:12+00:00

The #ifdef guards around these are wrong, resulting in warnings
in certain configurations:

drivers/usb/dwc3/dwc3-qcom.c:244:12: error: 'dwc3_qcom_resume' defined but not used [-Werror=unused-function]
 static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
            ^~~~~~~~~~~~~~~~
drivers/usb/dwc3/dwc3-qcom.c:223:12: error: 'dwc3_qcom_suspend' defined but not used [-Werror=unused-function]
 static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)

This replaces the guards with __maybe_unused annotations to shut up
the warnings and give better compile time coverage.

Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Reviewed-by: Douglas Anderson 
Acked-by: Geert Uytterhoeven 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Felipe Balbi

usb: dwc3: Fix error return code in dwc3_qcom_probe()

2018-06-19T09:48:12+00:00

Fix to return error code -ENODEV from the get device failed error
handling case instead of 0, as done elsewhere in this function.

Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Signed-off-by: Wei Yongjun 
Signed-off-by: Felipe Balbi

usb: dwc3: Only call clk_bulk_get() on devicetree instantiated devices

2018-06-18T09:41:01+00:00

Commit fe8abf332b8f ("usb: dwc3: support clocks and resets for DWC3 core")
adds support for handling clocks and resets in the DWC3 core, so that for
platforms following the standard devicetree bindings this does not need
to be duplicated in all the different glue layers.

These changes intended for devicetree based platforms introduce an
uncoditional clk_bulk_get() in the core probe path. This leads to the
following error being logged on x86/ACPI systems:

[   26.276783] dwc3 dwc3.3.auto: Failed to get clk 'ref': -2

This commits wraps the clk_bulk_get() in an if (dev->of_node) check so
that it only is done on devicetree instantiated devices, fixing this
error.

Cc: Masahiro Yamada 
Reviewed-by: Masahiro Yamada 
Signed-off-by: Hans de Goede 
Signed-off-by: Felipe Balbi

usb: dwc3: of-simple: fix use-after-free on remove

2018-06-18T09:41:00+00:00

The clocks have already been explicitly disabled and put as part of
remove() so the runtime suspend callback must not be run when balancing
the runtime PM usage count before returning.

Fixes: 16adc674d0d6 ("usb: dwc3: add generic OF glue layer")
Signed-off-by: Johan Hovold 
Signed-off-by: Felipe Balbi

usb: dwc3: pci: add support for Intel IceLake

2018-06-18T09:40:56+00:00

PCI IDs for Intel IceLake.

Signed-off-by: Heikki Krogerus 
Signed-off-by: Felipe Balbi

USB: dwc3: no need to check return value of debugfs_create functions

2018-05-31T10:54:22+00:00

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: dwc3: Remove DEBUG define from Qualcomm DWC3 glue driver

2018-05-31T10:43:53+00:00

It appears that a "#define DEBUG" was left in on the recent patch
landed for the Qualcomm DWC3 glue driver.  Let's remove it.

Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Signed-off-by: Douglas Anderson 
Signed-off-by: Greg Kroah-Hartman

usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue

2018-05-21T07:36:14+00:00

dwc3_ep_dequeue() waits for completion of End Transfer command using
wait_event_lock_irq(), which will release the dwc3->lock while waiting
and reacquire after completion. This allows a potential race condition
with ep_disable() which also removes all requests from started_list
and pending_list.

The check for NULL r->trb should catch this but currently it exits to
the wrong 'out1' label which calls dwc3_gadget_giveback(). Since its
list entry was already removed, if CONFIG_DEBUG_LIST is enabled a
'list_del corruption' bug is thrown since its next/prev pointers are
already LIST_POISON1/2. If r->trb is NULL it should simply exit to
'out0'.

Fixes: cf3113d893d4 ("usb: dwc3: gadget: properly increment dequeue pointer on ep_dequeue")
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Mayank Rana 
Signed-off-by: Jack Pham 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: dwc3_gadget_del_and_unmap_request() can be static

2018-05-21T07:36:14+00:00

Fixes the following sparse warning:

drivers/usb/dwc3/gadget.c:169:6: warning:
 symbol 'dwc3_gadget_del_and_unmap_request' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
Signed-off-by: Felipe Balbi