linux.git/drivers/usb/dwc2, branch v3.19

usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-19T15:41:49+00:00

This patch fixes the following problem: data transmission in direction
IN break unless the GSNPSID register access is done with spinlock held.
This issue occurs at least in Exynos4412 SoC, probably in many SoC's
from Exynos familly.

The problem is described here:
https://lkml.org/lkml/2014/12/22/185
And there is linux mailing list discussion:
https://lkml.org/lkml/2015/1/14/17

Signed-off-by: Robert Baldyga 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-22T16:28:55+00:00

This makes us sure that all requests are completed before we unbind
gadget. There are assumptions in gadget API that all requests have to
be completed and leak of complete can break some usb function drivers.

For example unbind of ECM function can cause NULL pointer dereference:

[   26.396595] configfs-gadget gadget: unbind function
'cdc_ethernet'/e79c4c00
[   26.414999] Unable to handle kernel NULL pointer dereference at
virtual address 00000000
(...)
[   26.452223] PC is at ecm_unbind+0x6c/0x9c
[   26.456209] LR is at ecm_unbind+0x68/0x9c
(...)
[   26.603696] [] (ecm_unbind) from []
(purge_configs_funcs+0x94/0xd8)
[   26.611674] [] (purge_configs_funcs) from []
(configfs_composite_unbind+0x14/0x34)
[   26.620961] [] (configfs_composite_unbind) from
[] (usb_gadget_remove_driver+0x68/0x9c)
[   26.630683] [] (usb_gadget_remove_driver) from []
(usb_gadget_unregister_driver+0x64/0x94)
[   26.640664] [] (usb_gadget_unregister_driver) from
[] (unregister_gadget+0x20/0x3c)
[   26.650038] [] (unregister_gadget) from []
(gadget_dev_desc_UDC_store+0x80/0xb8)
[   26.659152] [] (gadget_dev_desc_UDC_store) from
[] (gadget_info_attr_store+0x1c/0x28)
[   26.668703] [] (gadget_info_attr_store) from []
(configfs_write_file+0xe8/0x148)
[   26.677818] [] (configfs_write_file) from []
(vfs_write+0xb0/0x1a0)
[   26.685801] [] (vfs_write) from []
(SyS_write+0x44/0x84)
[   26.692834] [] (SyS_write) from []
(ret_fast_syscall+0x0/0x30)
[   26.700381] Code: e30409f8 e34c0069 eb07b88d e59430a8 (e5930000)
[   26.706485] ---[ end trace f62a082b323838a2 ]---

It's because in some cases request is still running on endpoint during
unbind and kill_all_requests() called from s3c_hsotg_udc_stop() function
doesn't cause call of complete() of request. Missing complete() call
causes ecm->notify_req equals NULL in ecm_unbind() function, and this
is reason of this bug.

Similar breaks can be observed in another usb function drivers.

This patch fixes this bug forcing usb request completion in when
s3c_hsotg_ep_disable() is called from s3c_hsotg_udc_stop().

Acked-by: Paul Zimmerman 
Signed-off-by: Robert Baldyga 
Signed-off-by: Felipe Balbi

Merge tag 'usb-for-v3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next

2014-11-25T17:31:14+00:00

Felipe writes:

usb: patches for v3.19 merge window

This time, a very pull request with 216 non-merge
commits. Most of the commits contained here are
sparse or coccinelle fixes ranging from missing
'static' to returning 0 in case of errors.

More importantly, we have the removal the now
unnecessary 'driver' argument to ->udc_stop().

DWC2 learned about Dual-Role builds. Users of
this IP can now have a single driver built for
host and device roles.

DWC3 got support for two new HW platforms: Exynos7
and AMD.

The Broadcom USB 3.0 Device Controller IP is now
supported and so is PLX USB338x, which means DWC3
has lost is badge as the only USB 3.0 peripheral
IP supported on Linux.

Thanks for Tony Lindgren's work, we can now have
a distro-like kernel where all MUSB glue layers
can be built into the same kernel (statically
or dynamically linked) and it'll work in PIO (DMA
will come probably on v3.20).

Other than these, the usual set of cleanups and
non-critical fixes.

Signed-off-by: Felipe Balbi

usb: dwc2: remove early return on clock query

2014-11-25T14:47:05+00:00

Since we have assigned clk=NULL, which is a valid clk, we should not
be returning when a clock node is not provide. Instead, we should return
only when we cannot enable the clock.

Signed-off-by: Dinh Nguyen 
Signed-off-by: Felipe Balbi

usb: dwc2: Fix build warning when CONFIG_PM_SLEEP=n

2014-11-25T14:47:04+00:00

Building with bcm2835_defconfig, which has CONFIG_PM_SLEEP=n causes the
following build warning:

drivers/usb/dwc2/platform.c:227:12: warning: 'dwc2_suspend' defined but not used [-Wunused-function]
drivers/usb/dwc2/platform.c:237:12: warning: 'dwc2_resume' defined but not used [-Wunused-function]

Annotate these functions with '__maybe_unused' to prevent the warnings.

Reported-by: Olof's autobuilder 
Signed-off-by: Fabio Estevam 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: rework suspend/resume code to correctly restore gadget state

2014-11-21T15:07:42+00:00

Suspend/resume code assumed that the gadget was always started and
enabled to connect to usb bus. This means that the actual state of the
gadget (started/stopped or connected/disconnected) was not correctly
preserved on suspend/resume cycle. This patch fixes this issue.

Signed-off-by: Marek Szyprowski 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: add mutex to serialize init/deinit calls

2014-11-21T15:07:38+00:00

This patch adds mutex, which protects initialization and
deinitialization procedures against suspend/resume methods. This mutex
will be needed by the updated suspend/resume calls, which tracks gadget
state.

Signed-off-by: Marek Szyprowski 
Acked-by: Paul Zimmerman 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: rework disconnect event handling

2014-11-21T15:07:34+00:00

This patch adds a call to s3c_hsotg_disconnect() from 'end session'
interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem
about unplugged usb cable. DISCONNINT interrupt cannot be used for this
purpose, because it is asserted only in host mode.

To avoid reporting disconnect event more than once, a disconnect call has
been moved from USB_REQ_SET_ADDRESS handling function to SESSREQINT
interrupt. This way driver ensures that disconnect event is reported
either when usb cable is unplugged or every time the host starts a new
session. To handle devices which has been synthesized without
SRP support, connected state is set in ENUMDONE interrupt.

Signed-off-by: Marek Szyprowski 
Acked-by: Paul Zimmerman 
Signed-off-by: Felipe Balbi

usb: dwc2: Update Kconfig to support dual-role

2014-11-14T21:00:07+00:00

Update DWC2 kconfig and makefile to support dual-role mode. The platform
file will always get compiled for the case where the controller is directly
connected to the CPU. So for loadable modules, dwc2.ko is built for host,
peripheral, and dual-role mode. The PCI bus interface will be called
dwc2_pci.ko and the platform interface module will be called dwc2_platform.ko.

Signed-off-by: Dinh Nguyen 
Acked-by: Paul Zimmerman 
Signed-off-by: Felipe Balbi

usb: dwc2: move usb_disabled() call to host driver only

2014-11-14T21:00:03+00:00

Since platform.c will get built for both Host and Gadget, if we leave the
usb_disabled() call in platform.c, it results in the following build error
when (!USB && USB_GADGET) condition is met.

ERROR: "usb_disabled" [drivers/usb/dwc2/dwc2_platform.ko] undefined!

Since usb_disabled() is mostly used to disable USB host functionality, move
the call the host portion for the DWC2 driver.

Acked-by: Paul Zimmerman 
Signed-off-by: Dinh Nguyen 
Signed-off-by: Felipe Balbi