linux.git/drivers/usb/dwc2/platform.c, branch v4.5

Revert "usb: dwc2: Move reset into dwc2_get_hwparams()"

2016-02-03T18:15:19+00:00

This reverts commit 263b7fb557f7 ("usb: dwc2: Move reset into
dwc2_get_hwparams()") due to regression found on bcm2835 platform. USB
ethernet fails, due to being unable to pick up proper parameters when
performing a plain reset before reading hw params.

Below shows the results of the gnptxfsiz and hptxfsiz with and before
and after reverting this (from Stefan Wahren):

So here is the probe result before Patch 1 is applied:

[    1.283148] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host
[    1.313894] dwc2 20980000.usb: gnptxfsiz=00201000
[    1.314104] dwc2 20980000.usb: hptxfsiz=00000000
[    1.353908] dwc2 20980000.usb: 256 invalid for host_nperio_tx_fifo_size. Check HW configuration.
[    1.354262] dwc2 20980000.usb: 512 invalid for host_perio_tx_fifo_size. Check HW configuration.
[    1.394249] dwc2 20980000.usb: DWC OTG Controller
[    1.394561] dwc2 20980000.usb: new USB bus registered, assigned bus number 1
[    1.394917] dwc2 20980000.usb: irq 33, io mem 0x00000000

And here is the probe result after Patch 1 is applied:

[    1.280107] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host
[    1.353949] dwc2 20980000.usb: gnptxfsiz=01001000
[    1.354166] dwc2 20980000.usb: hptxfsiz=02002000
[    1.434301] dwc2 20980000.usb: DWC OTG Controller
[    1.434616] dwc2 20980000.usb: new USB bus registered, assigned bus number 1
[    1.434973] dwc2 20980000.usb: irq 33, io mem 0x00000000

Tested-by: Heiko Stuebner 
Tested-by: Douglas Anderson 
Signed-off-by: John Youn 
Reported-by: Stefan Wahren 
Reported-by: Remi Pommarel 
Tested-by: Stefan Wahren 
Tested-by: Remi Pommarel 
Signed-off-by: Felipe Balbi

usb: dwc2: add shutdown callback to platform variant

2015-12-22T18:12:51+00:00

In specific conditions (involving usb hubs) dwc2 devices can create a
lot of interrupts, even to the point of overwhelming devices running
at low frequencies. Some devices need to do special clock handling
at shutdown-time which may bring the system clock below the threshold
of being able to handle the dwc2 interrupts. Disabling dwc2-irqs
in a shutdown callbacks prevents reboots/poweroffs from getting stuck
in such cases.

The hsotg struct already contains an unused irq element, so we can
just use it to store the irq number for the shutdown callback.

Reviewed-by: Douglas Anderson 
Acked-by: John Youn 
Signed-off-by: Heiko Stuebner 
Signed-off-by: Felipe Balbi

usb: dwc2: Remove redundant reset in probe

2015-12-22T18:02:34+00:00

Reset already happens before this so just force the dr_mode.

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Move reset into dwc2_get_hwparams()

2015-12-22T17:58:34+00:00

The reset is required to get reset values of the hardware parameters but
the force mode is not. Move the base reset into dwc2_get_hwparams() and
do the reset and force mode afterwards.

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Fix dr_mode validation

2015-12-22T17:57:35+00:00

The dr_mode parameter was being checked against how the dwc2 module
was being configured at compile time. But it wasn't checked against
the hardware capabilities, nor were the hardware capabilities checked
against the compilation parameters.

This commit adds those checks and adjusts dr_mode to an appropriate
value, if needed. If the hardware capabilities and module compilation
do not match then we fail as it wouldn't be possible to run properly.

The hardware, module, and dr_mode, can each be set to host, device,
or otg. Check that all these values are compatible and adjust the
value of dr_mode if possible.

The following table summarizes the behavior:

                     actual
   HW  MOD dr_mode   dr_mode
 ------------------------------
  HST  HST  any    :  HST
  HST  DEV  any    :  ---
  HST  OTG  any    :  HST

  DEV  HST  any    :  ---
  DEV  DEV  any    :  DEV
  DEV  OTG  any    :  DEV

  OTG  HST  any    :  HST
  OTG  DEV  any    :  DEV
  OTG  OTG  any    :  dr_mode

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Rename dwc2_core_reset()

2015-12-22T17:55:21+00:00

Renamed dwc2_core_reset() to dwc2_core_reset_and_force_dr_mode(). This
describes what it is doing more accurately. This is in preparation of
introducing a plain dwc2_core_reset() function that only performs the
reset and doesn't force the mode.

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

2015-12-22T17:51:45+00:00

We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should
be called before dwc2_get_hwparams() to reset core registers to
default value. Without this the FIFO setting might be incorrect
because calculating FIFO size need power-on value of
GRXFSIZ/GNPTXFSIZ/HPTXFSIZ registers.

This patch could avoid warnning massage like in rk3288 platform:
[    2.074764] dwc2 ff580000.usb: 256 invalid for
host_perio_tx_fifo_size. Check HW configuration.

Signed-off-by: Yunzhi Li 
Signed-off-by: Douglas Anderson 
Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: add support of hi6220

2015-12-15T15:12:41+00:00

Support hisilicon,hi6220-usb for HiKey board

Acked-by: Rob Herring 
Acked-by: John Youn 
Signed-off-by: Zhangfei Gao 
Signed-off-by: Felipe Balbi

usb: dwc2: host: enable descriptor dma for fs devices

2015-12-15T15:12:41+00:00

As descriptor dma mode does not support split transfers, it can't be
enabled for high speed devices. Add a core parameter to enable it for
full speed devices.

Ensure frame list and descriptor list are correctly freed during
disconnect.

Acked-by: John Youn 
Signed-off-by: Mian Yousaf Kaukab 
Signed-off-by: Gregory Herrero 
Signed-off-by: Felipe Balbi

usb: dwc2: fix kernel oops during driver probe

2015-11-20T15:29:47+00:00

This patch make sure that all necessary members of dwc2_hsotg
are initialized before the irq handler is requested. So
the kernel oops triggered by dwc2_handle_common_intr has
been fixed.

  dwc2 20980000.usb: Configuration mismatch. Forcing host mode
  dwc2 20980000.usb: no platform data or transceiver defined
  Unable to handle kernel paging request at virtual address cc860040
  pgd = c0004000
  [cc860040] *pgd=0b41e811, *pte=00000000, *ppte=00000000
  Internal error: Oops: 7 [#1] ARM
  CPU: 0 PID: 1 Comm: swapper Not tainted 4.3.0-rc3+ #19
  Hardware name: BCM2835
  task: cb494000 ti: cb4d0000 task.ti: cb4d0000
  PC is at dwc2_is_controller_alive+0x18/0x34
  LR is at dwc2_handle_common_intr+0x24/0xb60

Acked-by: John Youn 
Tested-by: Marek Szyprowski 
Signed-off-by: Stefan Wahren 
Signed-off-by: Felipe Balbi