linux.git/drivers/usb/core, branch v2.6.36

USB: update Kconfig help text for CONFIG_USB_SUSPEND

2010-09-24T18:05:01+00:00

This patch (as1429) updates the Kconfig help text for
CONFIG_USB_SUSPEND.  The power/level file is now deprecated; we should
tell people to use power/control instead.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: fix bug in initialization of interface minor numbers

2010-09-24T18:05:00+00:00

Recent changes in the usbhid layer exposed a bug in usbcore.  If
CONFIG_USB_DYNAMIC_MINORS is enabled then an interface may be assigned
a minor number of 0.  However interfaces that aren't registered as USB
class devices also have their minor number set to 0, during
initialization.  As a result usb_find_interface() may return the
wrong interface, leading to a crash.

This patch (as1418) fixes the problem by initializing every
interface's minor number to -1.  It also cleans up the
usb_register_dev() function, which besides being somewhat awkwardly
written, does not unwind completely on all its error paths.

Signed-off-by: Alan Stern 
Tested-by: Philip J. Turmel 
Tested-by: Gabriel Craciunescu 
Tested-by: Alex Riesen 
Tested-by: Matthias Bayer 
CC: Jiri Kosina 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

usb: allow drivers to use allocated bandwidth until unbound

2010-09-04T00:33:40+00:00

When using the remove sysfs file, the device configuration is set to -1
(unconfigured). This eventually unbind drivers with the bandwidth_mutex
held. Some drivers may call functions that hold said mutex, like
usb_reset_device. This is the case for rtl8187, for example. This will
lead to the same process holding the mutex twice, which deadlocks.

Besides, according to Alan Stern:
"The deadlock problem probably could be handled somehow, but there's a
separate issue: Until the usb_disable_device call finishes unbinding
the drivers, the drivers are free to continue using their allocated
bandwidth.  We musn't change the bandwidth allocations until after the
unbinding is done.  So this patch is indeed necessary."

Unbinding the driver before holding the bandwidth_mutex solves the
problem. If any operation after that fails, drivers are not bound again.
But that would be a problem anyway that the user may solve resetting the
device configuration to one that works, just like he would need to do in
most other failure cases.

Signed-off-by: Thadeu Lima de Souza Cascardo 
Cc: Alan Stern 
Cc: Sarah Sharp 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: remove fake "address-of" expressions

2010-08-10T21:35:45+00:00

Fake "address-of" expressions that evaluate to NULL generally confuse
readers and can provoke compiler warnings.  This patch (as1412)
removes three such fake expressions, using "#ifdef"s in their place.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: fix thread-unsafe anchor utiliy routines

2010-08-10T21:35:45+00:00

This patch fixes a race condition in two utility routines
related to the removal/unlinking of urbs from an anchor.

If two threads are concurrently accessing the same anchor,
both could end up with the same urb - thinking they are
the exclusive owner.

Alan Stern pointed out a related issue in
usb_unlink_anchored_urbs:

"The URB isn't removed from the anchor until it completes
 (as a by-product of completion, in fact), which might not
 be for quite some time after the unlink call returns.
 In the meantime, the subroutine will keep trying to unlink
 it, over and over again."

Cc: stable 
Cc: Oliver Neukum 
Cc: Greg Kroah-Hartman 
Acked-by: Alan Stern 
Signed-off-by: Christian Lamparter 
Signed-off-by: Greg Kroah-Hartman

USB: accept RNDIS configs if there's no alternative

2010-08-10T21:35:43+00:00

This patch (as1410) makes a slight change to the strategy used for
choosing a default configuration.  Currently we skip configs whose
first interface is RNDIS, if the kernel wasn't built with the
corresponding driver.  This risks losing access to the other
interfaces in those configs.  In addition, if there is only one config
then we will end up not configuring the device at all.

This changes the logic; now such configurations will be skipped only
if there is at least one other config.

Signed-off-by: Alan Stern 
Tested-by: Adam Kropelin 
Signed-off-by: Greg Kroah-Hartman

USB delay init quirk for logitech Harmony 700-series devices

2010-08-10T21:35:41+00:00

The Logitech Harmony 700 series needs an extra delay during
initialization.  This patch adds a USB quirk which enables such a delay
and adds the device to the quirks list.

Signed-off-by: Phil Dibowitz 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: xHCI: Supporting MSI/MSI-X

2010-08-10T21:35:40+00:00

Enable MSI/MSI-X supporting in xhci driver.

Provide the mechanism to fall back using MSI and Legacy IRQs
if MSI-X IRQs register failed.

Signed-off-by: Dong Nguyen 
Signed-off-by: Sarah Sharp ,
Signed-off-by: Greg Kroah-Hartman

USB: core: hcd-pci: use for_each_pci_dev()

2010-08-10T21:35:38+00:00

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Kulikov Vasiliy 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: EHCI: fix NULL pointer dererence in HCDs that use HCD_LOCAL_MEM

2010-08-10T21:35:38+00:00

If we use the HCD_LOCAL_MEM flag and dma_declare_coherent_memory() to
enforce the host controller's local memory utilization we also need to
disable native scatter-gather support, otherwise hcd_alloc_coherent() in
map_urb_for_dma() is called with urb->transfer_buffer == NULL, that
triggers a NULL pointer dereference.

We can also consider to add a WARN_ON() and return an error code to
better catch this problem in the future.

At the moment no driver seems to hit this bug, so I should
consider this a low-priority fix.

Signed-off-by: Andrea Righi 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman