linux.git/drivers/usb/core, branch v2.6.30

USB: pass mem_flags to dma_alloc_coherent

2009-04-23T21:15:28+00:00

When I want to use my webcam, I get:

                                 vvvvvvv
cheese: page allocation failure. order:5, mode:0x8004
Pid: 8100, comm: cheese Not tainted 2.6.30-rc2-wl-dirty #102
Call Trace:
 [] __alloc_pages_internal+0x3fe/0x520
 [] dma_generic_alloc_coherent+0x90/0x120
 [] hcd_buffer_alloc+0xee/0x130 [usbcore]
 [] usb_buffer_alloc+0x2d/0x40 [usbcore]
 [] uvc_alloc_urb_buffers+0x84/0x140 [uvcvideo]
 [] uvc_init_video+0x126/0x400 [uvcvideo]
 [...]

Oddly, I remembered fixing this and putting in __GFP_NOWARN
because uvcvideo retries a smaller allocation. However, the
allocation function doesn't pass the gfp flags through to
dma_alloc_coherent so we still get the warning!

Signed-off-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

USB: add reset endpoint operations

2009-04-17T17:50:27+00:00

Wireless USB endpoint state has a sequence number and a current
window and not just a single toggle bit.  So allow HCDs to provide a
endpoint_reset method and call this or clear the software toggles as
required (after a clear halt, set configuration etc.).

usb_settoggle() and friends are then HCD internal and are moved into
core/hcd.h and all device drivers call usb_reset_endpoint() instead.

If the device endpoint state has been reset (with a clear halt) but
the host endpoint state has not then subsequent data transfers will
not complete. The device will only work again after it is reset or
disconnected.

Signed-off-by: David Vrabel 
Signed-off-by: Greg Kroah-Hartman

USB: allow malformed LANGID descriptors

2009-03-24T23:20:45+00:00

When an USB hardware does not provide a valid LANGID, fall back to value
zero which is still a reasonable default for most devices.

Signed-off-by: Daniel Mack 
Signed-off-by: Greg Kroah-Hartman

USB: more u32 conversion after transfer_buffer_length and actual_length

2009-03-24T23:20:45+00:00

transfer_buffer_length and actual_length have become unsigned, therefore some
additional conversion of local variables, function arguments and print
specifications is desired.

A test for a negative urb->transfer_buffer_length became obsolete; instead
we ensure that it does not exceed INT_MAX. Also, urb->actual_length is always
less than urb->transfer_buffer_length.

rh_string() does no longer return -EPIPE in the case of an unsupported ID.
Instead its only caller, rh_call_control() does the check.

Signed-off-by: Roel Kluin 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: usbfs: remove unneeded "inline" annotations

2009-03-24T23:20:44+00:00

This patch (as1223) removes a bunch of unnecessary "inline"
annotations from the usbfs driver.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: don't send Set-Interface after reset

2009-03-24T23:20:38+00:00

This patch (as1221) changes the way usbcore reinitializes a device
following a reset or a reset-resume.  Currently we call
usb_set_interface() for every interface in the active configuration;
this is to put the interface into the same altsetting as before the
reset and to make sure that the host's endpoint state matches the
device's endpoint state.

However, sending a Set-Interface request is a waste of time if an
interface was already in altsetting 0 before the reset, since it is
certainly in altsetting 0 afterward.  In addition, many devices can't
handle Set-Interface requests -- they crash when they receive them.

So instead, the patch adds code to check each interface.  If the
interface wasn't in altsetting 0 before the reset, we go head with the
Set-Interface request as before.  But if it was then we skip sending
the Set-Interface request, and we clear out the host-side endpoint
state by calling usb_disable_interface() followed by
usb_enable_interface().

The patch also adds a couple of new comments to explain what's going
on.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: allow libusb to talk to unauthenticated WUSB devices

2009-03-24T23:20:35+00:00

To permit a userspace application to associate with WUSB devices
using numeric association, control transfers to unauthenticated WUSB
devices must be allowed.

This requires that wusbcore correctly sets the device state to
UNAUTHENTICATED, DEFAULT and ADDRESS and that control transfers can be
performed to UNAUTHENTICATED devices.

Signed-off-by: David Vrabel 
Signed-off-by: Greg Kroah-Hartman

USB: replace uses of __constant_{endian}

2009-03-24T23:20:33+00:00

The base versions handle constant folding now.

Signed-off-by: Harvey Harrison 
Signed-off-by: Greg Kroah-Hartman

USB: drivers: use USB API functions rather than constants

2009-03-24T23:20:28+00:00

This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include 

@depends on !inc && (r1||r5)@
@@

+ #include 
  #include 
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

USB: add quirk to avoid config and interface strings

2009-03-24T23:20:25+00:00

Apparently the Configuration and Interface strings aren't used as
often as the Vendor, Product, and Serial strings.  In at least one
device (a Saitek Cyborg Gold 3D joystick), attempts to read the
Configuration string cause the device to stop responding to Control
requests.

This patch (as1226) adds a quirks flag, telling the kernel not to
read a device's Configuration or Interface strings, together with a
new quirk for the offending joystick.

Reported-by: Melchior FRANZ 
Tested-by: Melchior FRANZ 
Signed-off-by: Alan Stern 
Cc: stable   [2.6.28 and 2.6.29, nothing earlier]
Signed-off-by: Greg Kroah-Hartman