linux.git/drivers/usb/class, branch v3.5-rc2

USB: Disable hub-initiated LPM for comms devices.

2012-05-18T22:42:55+00:00

Hub-initiated LPM is not good for USB communications devices.  Comms
devices should be able to tell when their link can go into a lower power
state, because they know when an incoming transmission is finished.
Ideally, these devices would slam their links into a lower power state,
using the device-initiated LPM, after finishing the last packet of their
data transfer.

If we enable the idle timeouts for the parent hubs to enable
hub-initiated LPM, we will get a lot of useless LPM packets on the bus
as the devices reject LPM transitions when they're in the middle of
receiving data.  Worse, some devices might blindly accept the
hub-initiated LPM and power down their radios while they're in the
middle of receiving a transmission.

The Intel Windows folks are disabling hub-initiated LPM for all USB
communications devices under a xHCI USB 3.0 host.  In order to keep
the Linux behavior as close as possible to Windows, we need to do the
same in Linux.

Set the disable_hub_initiated_lpm flag for for all USB communications
drivers.  I know there aren't currently any USB 3.0 devices that
implement these class specifications, but we should be ready if they do.

Signed-off-by: Sarah Sharp 
Cc: Marcel Holtmann 
Cc: Gustavo Padovan 
Cc: Johan Hedberg 
Cc: Hansjoerg Lipp 
Cc: Tilman Schmidt 
Cc: Karsten Keil 
Cc: Peter Korsgaard 
Cc: Jan Dumon 
Cc: Petko Manolov 
Cc: Steve Glendinning 
Cc: "John W. Linville" 
Cc: Kalle Valo 
Cc: "Luis R. Rodriguez" 
Cc: Jouni Malinen 
Cc: Vasanthakumar Thiagarajan 
Cc: Senthil Balasubramanian 
Cc: Christian Lamparter 
Cc: Brett Rudley 
Cc: Roland Vossen 
Cc: Arend van Spriel 
Cc: "Franky (Zhenhui) Lin" 
Cc: Kan Yan 
Cc: Dan Williams 
Cc: Jussi Kivilinna 
Cc: Ivo van Doorn 
Cc: Gertjan van Wingerde 
Cc: Helmut Schaa 
Cc: Herton Ronaldo Krzesinski 
Cc: Hin-Tak Leung 
Cc: Larry Finger 
Cc: Chaoming Li 
Cc: Daniel Drake 
Cc: Ulrich Kunitz 
Signed-off-by: Sarah Sharp

USB: cdc-wdm: remove from device list on disconnect

2012-05-11T22:19:22+00:00

Prevents dereferencing an invalid struct usb_interface
pointer.

Always delete entry from device list whether or not the
rest of the device state cleanup is postponed. The device
list uses desc->intf as key, and wdm_open will dereference
this key while searching for a matching device.  A device
should not appear in the list unless probe() has succeeded
and disconnect() has not finished.

Cc: Oliver Neukum 
Cc: stable 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: cannot use dev_printk when device is gone

2012-05-11T22:19:22+00:00

We cannot dereference a removed USB interface for
dev_printk. Use pr_debug instead where necessary.

Flush errors are expected if device is unplugged and are
therefore best ingored at this point.

Move the kill_urbs() call in wdm_release with dev_dbg()
for the non disconnect, as we know it has already been
called if WDM_DISCONNECTING is set.  This does not
actually fix anything, but keeps the code more consistent.

Cc: Oliver Neukum 
Cc: stable 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: poll must return POLLHUP if device is gone

2012-05-11T22:19:22+00:00

Else the poll will be restarted indefinitely in a tight loop,
preventing final device cleanup.

Cc: Oliver Neukum 
Cc: stable 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

Merge 3.4-rc6 into usb-next

2012-05-07T16:03:39+00:00

This resolves the conflict with:
	drivers/usb/host/ehci-tegra.c

Signed-off-by: Greg Kroah-Hartman

USB: usblp.c: remove dbg() usage

2012-05-02T04:33:31+00:00

dbg() was a very old USB-specific macro that should no longer
be used. This patch removes it from being used in the driver
and uses dev_dbg() instead.

CC: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: cleanup error codes

2012-04-30T13:58:56+00:00

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The internal error codes returned in the write() code
path cannot be simply passed on to user space.

Signed-off-by: Oliver Neukum 
Tested-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: add debug messages on cleanup

2012-04-30T13:57:27+00:00

Device state cleanup is done in either wdm_disconnect or
wdm_release depending on the order they are called. Adding
a couple of debug messages to document the program flow.

Signed-off-by: Bjørn Mork 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: fix memory leak

2012-04-30T01:53:41+00:00

cleanup() is not called if the last close() comes after
disconnect(). That leads to a memory leak. Rectified
by checking for an earlier disconnect() in release()

Signed-off-by: Oliver Neukum 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: sanitize error returns

2012-04-30T01:53:41+00:00

wdm_flush() returns unsanitized USB error codes.
They must be cleaned up to before being anded to user space

Signed-off-by: Oliver Neukum 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman