linux.git/drivers/usb/class, branch v2.6.27

USB: cdc-acm: don't unlock acm->mutex on error path

2008-08-21T17:26:35+00:00

On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote:
> I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify"
> and the kernel oopsed:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000458
> IP: [] mutex_unlock+0x0/0xb
>  [] acm_tty_open+0x4c/0x214

Signed-off-by: Alexey Dobriyan 
Tested-by: Andrei Popa 
Cc: stable 		[2.6.25.x, 2.6.26.x]
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: quirk for Conexant CX93010 USB modem

2008-08-21T17:26:33+00:00

This patch gets my Rosewill RNX-56USB USB modem (with Conexant CX93010
chipset) up and running to the point where I can send AT commands and
retrieve caller ID data, which is all I want to do with it.

Signed-off-by: Eric Sandeen 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: drain writes on close

2008-08-14T00:32:57+00:00

Add a mechanism to let the write queue drain naturally before
closing the TTY, rather than always losing that data.  There
is a timeout, so it can't wait too long.

Provide missing locking inside acm_wb_is_avail(); it matters
more now.  Note, this presumes an earlier patch was applied,
removing a call to this routine where the lock was held.

Slightly improved diagnostics on write URB completion, so we
can tell when a write URB gets killed and, if so, how much
data it wrote first ... and so that I/O path is normally
silent (and can't much change timings).

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: stop dropping tx buffers

2008-08-14T00:32:57+00:00

The "increase cdc-acm write throughput" patch left in place two
now-obsolete mechanisms, either of which can make the cdc-acm
driver drop TX data (nasty!).  This patch removes them:

  - The write_ready flag ... if an URB and buffer were found,
    they can (and should!) always be used.

  - TX path acm_wb_is_used() ... used when the buffer was just
    allocated, so that check is pointless.

Also fix a won't-yet-matter leak of a write buffer on a disconnect path.

Signed-off-by: David Brownell 
Cc:  David Engraf 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: bugfix release()

2008-08-14T00:32:57+00:00

Bugfixes to the usb_driver_release_interface() usage;

  (a) make sure releasing *either* interface first will release
      the other, instead of insisting it be the control interface;

  (b) remove the recently-added self-deadlock.

(The "fix disconnect bug in cdc-acm" patch was incomplete and incorrect.)

Plus a small "sparse" fix:  rename a local variable so it doesn't
shadow a function parameter.

Signed-off-by: David Brownell 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm.c: Fix compile warnings

2008-08-14T00:32:56+00:00

The irq flags should be unsigned long.

  CC [M]  drivers/usb/class/cdc-acm.o
drivers/usb/class/cdc-acm.c: In function 'acm_waker':
drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast
drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

tty: rework break handling

2008-07-22T20:03:28+00:00

Some hardware needs to do break handling itself and may have partial
support only. Make break_ctl return an error code. Add a tty driver flag
so you can indicate driver hardware side break support.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

USB: fix build error in cdc-acm for CONFIG_PM=n

2008-07-21T22:16:47+00:00

Here's the fix. cdc-wdm has the same problem. The fix is the same.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: fix disconnect bug in cdc-acm

2008-07-21T22:16:37+00:00

cdc-acm must give up secondary interfaces if the primary is disconnected
and vice versa. This wasn't done correctly.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: autosuspend for cdc-wdm

2008-07-21T22:16:36+00:00

this patch implements

- suspend/resume
- aggressive autosuspend for the cdc-wdm driver
- pre/post_reset

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman