linux.git/drivers/usb/chipidea, branch v3.10-rc2

drivers/usb/chipidea: don't check resource with devm_ioremap_resource

2013-05-18T09:57:31+00:00

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang 
Acked-by: Alexander Shishkin

Merge tag 'usb-for-v3.10' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next

2013-04-05T22:18:00+00:00

Felipe writes:

usb: patches for v3.10 merge window

Here is the big Gadget & PHY pull request. Many of us have
been really busy lately getting multiple drivers to a better
position.

Since this pull request is so large, I will divide it in sections
so it's easier to grasp what's included.

- cleanups:
	. UDC drivers no longer touch gadget->dev, that's now udc-core
		responsibility
	. Many more UDC drivers converted to usb_gadget_map/unmap_request()
	. UDC drivers no longer initialize DMA-related fields from gadget's
		device structure
	. UDC drivers don't touch gadget.dev.driver directly
	. UDC drivers don't assign gadget.dev.release directly
	. Removal of some unused DMA_ADDR_INVALID
	. Introduction of CONFIG_USB_PHY
	. All phy drivers have been moved to drivers/usb/phy and renamed to
		a common naming scheme
	. Fix PHY layer so it never returns a NULL pointer, also fix all
		callers to avoid using IS_ERR_OR_NULL()
	. Sparse fixes all over the place
	. drivers/usb/otg/ has been deleted
	. Marvel drivers (mv_udc, ehci-mv, mv_otg and mv_u3d) improved clock
		usage

- new features:
	. UDC core now provides a generic way for tracking and reporting
		UDC's state (not attached, resuming, suspended, addressed,
		default, etc)
	. twl4030-usb learned that it shouldn't be enabled during init
	. Full DT support for DWC3 has been implemented
	. ab8500-usb learned about pinctrl framework
	. nop PHY learned about DeviceTree and regulators
	. DWC3 learned about suspend/resume
	. DWC3 can now be compiled in host-only and gadget-only (as well as
		DRD) configurations
	. UVC now enables streaming endpoint based on negotiated speed
	. isp1301 now implements the PHY API properly
	. configfs-based interface for gadget drivers which will lead to
		the removal of all code which just combines functions together
		to build functional gadget drivers.
	. f_serial and f_obex were converted to new configfs interface while
		maintaining old interface around.

- non-critical fixes:
	. UVC gadget driver got fixes for Endpoint usage and stream calculation
	. ab8500-usb fixed unbalanced clock and regulator API usage
	. twl4030-usb got a fix for when OMAP3 is booted with cable connected
	. fusb300_udc got a fix for DMA usage
	. UVC got fixes for two assertions of the USB Video Class Compliance
		specification revision 1.1
	. build warning issues caused by recent addition of __must_check to
		regulator API

These are all changes which deserve a mention, all other changes are related
to these one or minor spelling fixes and other similar tasks.

Signed-of-by: Felipe Balbi

usb: chipidea: udc: fix memory leak in _ep_nuke

2013-04-05T21:09:12+00:00

In hardware_enqueue code adds one extra td with dma_pool_alloc if
mReq->req.zero is true. When _ep_nuke will be called for that endpoint,
dma_pool_free will not be called to free that memory again. That patch
fixes this.

Cc: stable  # v3.5
Signed-off-by: Michael Grzeschik 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: fix memory access of shared memory on armv5 machines

2013-04-05T20:43:14+00:00

The udc uses an shared dma memory space between hard and software. This
memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
with the attribute ((packed)).

The compiler currently does not know about the alignment of the memory
layout, and will create strb and ldrb operations.

The Datasheet of the synopsys core describes, that some operations on
the mapped memory need to be atomic double word operations. I.e. the
next pointer addressing in the qhead, as otherwise the hardware will
read wrong data and totally stuck.

This is also possible while working with the current active td queue,
and preparing the td->ptr.next in software while the hardware is still
working with the current active td which is supposed to be changed:

writeb(0xde, &td->ptr.next + 0x0); /* strb */
writeb(0xad, &td->ptr.next + 0x1); /* strb */

<----- hardware reads value of td->ptr.next and get stuck!

writeb(0xbe, &td->ptr.next + 0x2); /* strb */
writeb(0xef, &td->ptr.next + 0x3); /* strb */

This appeares on armv5 machines where the hardware does not support
unaligned 32bit operations.

This patch adds the attribute ((aligned(4))) to the structures to tell
the compiler to use 32bit operations. It also adds an wmb() for the
prepared TD data before it gets enqueued into the qhead.

Cc: stable  # v3.5
Signed-off-by: Michael Grzeschik 
Reviewed-by: Felipe Balbi 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-30T15:20:49+00:00

A static count of transfer descriptors was used everywhere in the driver
with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT,
and replaces all users of this value. This way its possible to have only
one parameter to change and limit the amount of buffer pointers per TD.

Signed-off-by: Michael Grzeschik 
Reviewed-by: Peter Chen 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-30T15:20:49+00:00

There is no need to call ep_queue unlocked inside the own driver. We
move its functionionality into an unlocked version.

This patch removes potential unlocked timeslots inside
isr_setup_status_phase and isr_get_status_response, in which the lock
got released just before acquired again inside usb_ep_queue.

Signed-off-by: Michael Grzeschik 
Signed-off-by: Marc Kleine-Budde 
Reviewed-by: Peter Chen 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: don't truncate requests to single tds

2013-03-30T15:20:48+00:00

It is not safe to truncate requests to the maximum possible size the
controller can handle with one td and to keep working. That patch fixes
that with proper error handling instead.

Reported-by: Felipe Balbi 
Signed-off-by: Michael Grzeschik 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-30T15:20:48+00:00

This patch changes the read of the td status to one atomic operation to
analyse coherent bits.

Signed-off-by: Michael Grzeschik 
[Alex: fixed backwards endianness conversion]
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-30T15:20:48+00:00

Its not necessary and also not specified in the datasheet to change the
ZLT flag before every ep_prime. This patch moves this to the ep_enable
and applies it only for non configuration endpoints.

Signed-off-by: Michael Grzeschik 
Reviewed-by: Felipe Balbi 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: rework ep_enable cap setting

2013-03-30T15:20:48+00:00

This patch reworks the cap value from several read
and write operations to one single operation.

Signed-off-by: Michael Grzeschik 
Reviewed-by: Felipe Balbi 
[Alex: removed useless isoc-related bit of code]
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman