linux.git/drivers/usb/cdns3, branch v5.9 Linux kernel source tree usb: cdns3: convert to devm_platform_ioremap_resource_byname 2020-07-29T14:49:37+00:00 Chunfeng Yun chunfeng.yun@mediatek.com 2020-07-22T07:51:11+00:00 7e8b59c1fc6bf78b8117efd8d354bcb99efed2ea Use devm_platform_ioremap_resource_byname() to simplify code Cc: Peter Chen <peter.chen@nxp.com> Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Link: https://lore.kernel.org/r/1595404275-8449-3-git-send-email-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use devm_platform_ioremap_resource_byname() to simplify code

Cc: Peter Chen <peter.chen@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1595404275-8449-3-git-send-email-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usb: cdns3: drd: simplify *switch_gadet and *switch_host 2020-07-24T13:45:13+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:54+00:00 b2aeb6da3d6ee562e57ad3a7d73a7de0c36ce8eb Patch split function cdns3_drd_switch_gadget and cdns3_drd_switch_host into: - cdns3_drd_host_on - cdns3_drd_host_off - cdns3_drd_gadget_on - cdns3_drd_gadgett_off These functions don't have any shared code so it's better to have smaller, faster and easier functions. Signed-off-by: Pawel Laszczak <pawell@cadence.com> Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch split function cdns3_drd_switch_gadget and
cdns3_drd_switch_host into:
- cdns3_drd_host_on
- cdns3_drd_host_off
- cdns3_drd_gadget_on
- cdns3_drd_gadgett_off

These functions don't have any shared code so it's better to
have smaller, faster and easier functions.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: core: removed overwriting some error code 2020-07-24T13:45:13+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:53+00:00 f41ca26b8b178d0b7005c9bfeda88814179203b3 Some error code can be preserved, so we can remove overwriting error code returned by some functions. Signed-off-by: Pawel Laszczak <pawell@cadence.com> Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Some error code can be preserved, so we can remove overwriting
error code returned by some functions.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: core: removed 'goto not_otg' 2020-07-24T13:45:13+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:52+00:00 5c2cf30f14cc3973f2d288e33b0153f5d9a357fb Patch removes 'goto not_otg' instruction from cdns3_hw_role_state_machine function. Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch removes 'goto not_otg' instruction from
cdns3_hw_role_state_machine function.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOST 2020-07-24T13:45:13+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:51+00:00 08c35dd3cc2184dcc952fc845329dcae1ee302d3 Patch adds 2 definitions that make it easier to understand the code. Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch adds 2 definitions that make it easier to understand the code.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: drd: changed return type from int to bool 2020-07-24T13:45:13+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:50+00:00 245258495a5157e4428bd944189e4062d852dcdd Patch changes return type from int to bool for cdns3_is_host and cdns3_is_device functions. Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch changes return type from int to bool for
cdns3_is_host and cdns3_is_device functions.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: drd: return IRQ_NONE explicitly. 2020-07-24T13:45:12+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:49+00:00 03cce68a828dba13b3715033e5133839820218c3 IRQ_NONE can be returned indirect. Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
IRQ_NONE can be returned indirect.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cnds3: drd: deleted != 2020-07-24T13:45:12+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:48+00:00 ecf4f823fb7050e4f450bb56cd403cbb6d41ca7c Patch deletes unnecessary != from condition statement in cdns3_drd_init function. Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch deletes unnecessary != from condition statement in cdns3_drd_init
function.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: drd: removed not needed variables initialization 2020-07-24T13:45:12+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:47+00:00 27afe1661275213adee3f8dc08b3610abcbca678 Patch remove some variables initialization from core.c and drd.c file. Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Patch remove some variables initialization from core.c and drd.c
file.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
usb: cdns3: core: removed cdns3_get_current_role_driver function 2020-07-24T13:45:12+00:00 Pawel Laszczak pawell@cadence.com 2020-07-13T10:05:46+00:00 b20aecff99a2335731bb2ae69c8368dfc356aef7 Function is not used in driver so it can be removed. Signed-off-by: Pawel Laszczak <pawell@cadence.com> Reviewed-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> 
Function is not used in driver so it can be removed.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>