linux.git/drivers/usb/atm, branch v2.6.14

[PATCH] USB: URB_ASYNC_UNLINK flag removed from the kernel

2005-09-08T23:23:04+00:00

29 July 2005, Cambridge, MA:

This afternoon Alan Stern submitted a patch to remove the URB_ASYNC_UNLINK
flag from the Linux kernel.  Mr. Stern explained, "This flag is a relic
from an earlier, less-well-designed system.  For over a year it hasn't
been used for anything other than printing warning messages."

An anonymous spokesman for the Linux kernel development community
commented, "This is exactly the sort of thing we see happening all the
time.  As the kernel evolves, support for old techniques and old code can
be jettisoned and replaced by newer, better approaches.  Proprietary
operating systems do not have the freedom or flexibility to change so
quickly."

Mr. Stern, a staff member at Harvard University's Rowland Institute who
works on Linux only as a hobby, noted that the patch (labelled as548) did
not update two files, keyspan.c and option.c, in the USB drivers' "serial"
subdirectory.  "Those files need more extensive changes," he remarked.
"They examine the status field of several URBs at times when they're not
supposed to.  That will need to be fixed before the URB_ASYNC_UNLINK flag
is removed."

Greg Kroah-Hartman, the kernel maintainer responsible for overseeing all
of Linux's USB drivers, did not respond to our inquiries or return our
calls.  His only comment was "Applied, thanks."

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: convert kcalloc to kzalloc

2005-09-07T23:57:46+00:00

This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.

Signed-off-by: Pekka Enberg 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[ATM]: speedtch: Revert 86cf42e4e029b83110cf98692420239103363dbf

2005-07-26T02:54:35+00:00

It was already fixed more sufficiently by Andrew Morton's
change 843c944fb86e5e31ee7b319172e657ea22301322.

Noted by Duncan Sands.

Signed-off-by: David S. Miller

[ATM]: [speedtch] cure atm_printk() macro gcc-2.95 compile error

2005-07-19T20:57:17+00:00

Signed-off-by: Duncan Sands 
Signed-off-by: Chas Williams 
Signed-off-by: David S. Miller

[PATCH] USB ATM: fix line resync logic

2005-07-12T18:52:55+00:00

We map states 0x00 and 0x10 to the ATM_PHY_SIG_LOST flag.  The current logic fails to
resync the line if we get state 0x10 followed by 0x00, since we only resync the line
when the state is 0x00 and the flag changed.  Doubly fixed by (1) always resyncing the
line when the state is 0x00 even if the state didn't change, and (2) keeping track of
the last state, not just the flag.  We do (2) as well as (1) in order to get better log
messages.

This is a tweaked version of the original patch by Aurelio Arroyo.

Signed-off-by: Duncan Sands 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB ATM: robustify poll throttling

2005-07-12T18:52:55+00:00

No functional change, but less likely to break in the future.

Signed-off-by: Duncan Sands 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB ATM: line speed measured in Kb not Kib

2005-07-12T18:52:55+00:00

Spotted by David Woodhouse.

Signed-off-by: Duncan Sands 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: usbatm kcalloc cleanup

2005-06-27T21:43:58+00:00

you seem to have applied the original, not the new improved one with
whiter teeth that uses kcalloc instead of kmalloc + memset.  Here's a
patch that goes on top of the one you applied.

Signed-off-by: Duncan Sands 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: fix usbatm gcc-2.95.x bug

2005-06-27T21:43:58+00:00

Work around the gcc-2.95.x macro expansion bug.

Cc: Duncan Sands 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB ATM: avoid oops on bind failure; plug memory leak

2005-06-27T21:43:58+00:00

Zero the entire instance, not just the struct usbatm_data head.
Make sure the just allocated urb is freed if we fail to allocate
a buffer.  Based on a patch by Stanislaw W. Gruszka.

Signed-off-by: Duncan Sands 
Acked-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman