linux.git/drivers/tty/vt/vt.c, branch v4.8

Merge 4.7-rc6 into tty-next

2016-07-04T15:17:08+00:00

We want the tty/serial fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

tty: vt: Fix soft lockup in fbcon cursor blink timer.

2016-06-25T17:41:13+00:00

We are getting somewhat random soft lockups with this signature:

[   86.992215] [] el1_irq+0xa0/0x10c
[   86.997082] [] cursor_timer_handler+0x30/0x54
[   87.002991] [] call_timer_fn+0x54/0x1a8
[   87.008378] [] run_timer_softirq+0x1c4/0x2bc
[   87.014200] [] __do_softirq+0x114/0x344
[   87.019590] [] irq_exit+0x74/0x98
[   87.024458] [] __handle_domain_irq+0x98/0xfc
[   87.030278] [] gic_handle_irq+0x94/0x190

This is caused by the vt visual_init() function calling into
fbcon_init() with a vc_cur_blink_ms value of zero.  This is a
transient condition, as it is later set to a non-zero value.  But, if
the timer happens to expire while the blink rate is zero, it goes into
an endless loop, and we get soft lockup.

The fix is to initialize vc_cur_blink_ms before calling the con_init()
function.

Signed-off-by: David Daney 
Cc: stable@vger.kernel.org
Acked-by: Pavel Machek 
Tested-by: Ming Lei 
Acked-by: Scot Doyle 
Tested-by: Henrique de Moraes Holschuh 
Signed-off-by: Greg Kroah-Hartman

tty: vt, remove unused vc_deccolm

2016-06-25T16:04:48+00:00

vc_deccolm is only set and never read, remove the member from vc_data.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, convert more macros to functions

2016-06-25T16:04:48+00:00

Namely convert:
* IS_FG -> con_is_fg
* DO_UPDATE -> con_should_update
* CON_IS_VISIBLE -> con_is_visible

DO_UPDATE was a weird name for a yes/no answer, so the new name is
con_should_update.

Signed-off-by: Jiri Slaby 
Cc: Thomas Winischhofer 
Cc: Jean-Christophe Plagniol-Villard 
Cc: linux-usb@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

tty: vt, whitespace cleanup in csi_m

2016-06-25T16:04:48+00:00

Flush the switch cases to be aligned with the switch. Mostly
everything can now fit to the 80-chars terminal.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, too many commands per line in rgb_foreground

2016-06-25T16:04:48+00:00

Do not opencode max3, use the macro.

Separate commands. Until now, I have not noticed the comma. Make it
one line, one command. And make the code obvious.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, do not pass structure over stack

2016-06-25T16:04:48+00:00

The compiler noticed passing structure over stack. Even though rgb is
a small structure, let us define one and pass that over all the
functions wherever needed.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, separate T.416 high colors handler

2016-06-25T16:04:48+00:00

The code with T.416 high colors handling is flushed to the right and
hard to read. Move the code to a separate function and remove code
duplication for foreground & background colors.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, get rid of ugly FLUSH macro

2016-06-25T16:04:48+00:00

It's a macro accessing and changing some local variables. And the code
uses it without appending semicolon which confuses everybody too.

Switch from this bad guy to a sane standard function.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, drop VT_BUF_VRAM_ONLY

2016-06-25T16:04:48+00:00

It is never defined. And I spent quite some time looking into the
history and cannot find how this was ever used. Given it was not used
in the history, I doubt it currently works as expected after the years
of changes all over the code.

So kill it.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman