linux.git/drivers/tty/vt/keyboard.c, branch v4.7

tty/vt/keyboard: fix OOB access in do_compute_shiftstate()

2016-07-21T00:50:23+00:00

The size of individual keymap in drivers/tty/vt/keyboard.c is NR_KEYS,
which is currently 256, whereas number of keys/buttons in input device (and
therefor in key_down) is much larger - KEY_CNT - 768, and that can cause
out-of-bound access when we do

	sym = U(key_maps[0][k]);

with large 'k'.

To fix it we should not attempt iterating beyond smaller of NR_KEYS and
KEY_CNT.

Also while at it let's switch to for_each_set_bit() instead of open-coding
it.

Reported-by: Sasha Levin 
Reviewed-by: Guenter Roeck 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

tty/vt/keyboard: use memdup_user to simplify code

2016-02-07T07:27:46+00:00

use memdup_user rather than duplicating implementation.
found by coccinelle

Signed-off-by: Saurabh Sengar 
Signed-off-by: Greg Kroah-Hartman

tty/vt/keyboard: define LED triggers for VT keyboard lock states

2015-06-16T21:59:46+00:00

In addition to defining triggers for VT LED states, let's define triggers
for VT keyboard lock states, such as "kbd-shiftlock", "kbd-altgrlock", etc.

This permits to fix #7063 from userland by using a modifier to implement
proper CapsLock behavior and have the keyboard caps lock led show that
modifier state.

Signed-off-by: Samuel Thibault 
Tested-by: Pavel Machek 
Acked-by: Pavel Machek 
Signed-off-by: Dmitry Torokhov

tty/vt/keyboard: define LED triggers for VT LED states

2015-06-16T21:59:46+00:00

Now that input core allows controlling keyboards LEDs via standard LED
subsystem triggers let's switch VT keyboard code to make use of this
feature. We will define the following standard triggers: "kbd-scrollock",
"kbd-numlock", "kbd-capslock", and "kbd-kanalock" which are default
triggers for respective LEDs on keyboards.

Signed-off-by: Samuel Thibault 
Tested-by: Pavel Machek 
Acked-by: Pavel Machek 
Signed-off-by: Dmitry Torokhov

tty: pr_warning->pr_warn and logging neatening

2014-11-26T01:06:38+00:00

Convert the pr_warning to the more common pr_warn.

Other miscellanea:

o Convert unusual PR_FMT define and uses to pr_fmt
o Remove unnecessary OOM message
o Fix grammar in an error message
o Convert a pr_warning with a KERN_ERR to pr_err

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

tty/vt/keyboard: Resolve many shadow warnings

2014-09-08T23:30:43+00:00

Many local variables were given the same name as a global. This
is valid, but generates many shadow warnings in W=2 builds. Resolve
them by changing the local names. Also change local variables
named "up" because they shadow the semaphore "up" function. Also
moved the outer declaration of the variable "a" because it is
only used in one block, and that resolves all of the shadow warnings
for the other declarations of "a" that have different types.

Change diacr => dia, kbd => kb, rep => rpt, up => udp.

Signed-off-by: Mark Rustad 
Signed-off-by: Jeff Kirsher 
Signed-off-by: Greg Kroah-Hartman

tty: Remove dead code

2013-07-26T23:19:48+00:00

-> The ledptrs[] array is never initialized.
-> There is no place where kbd->ledmode is set to LED_SHOW_MEM therefore the if
   statement does not make much sense.
-> Since LED_SHOW_MEM is not used, it can be removed from the header file as well.

Signed-off-by: Andreas Platschek 
Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_schedule_flip

2013-01-16T06:43:15+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

This is the last one: tty_schedule_flip

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_insert_flip_char

2013-01-16T06:21:36+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

tty_insert_flip_char is the next one to proceed. This one is used all
over the code, so the patch is huge.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

vt: fix the keyboard/led locking

2012-07-17T16:13:37+00:00

We touch the LED from both keyboard callback and direct paths. In
one case we've got the lock held way up the call chain and in the
other we haven't. This leads to complete insanity so fix it by giving
the LED bits their own lock.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman