linux.git/drivers/tty/serial/jsm, branch v4.11

tty: serial: jsm_tty: constify uart_ops structures

2016-09-02T13:01:16+00:00

Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// 

Signed-off-by: Julia Lawall 
Acked-by: Gabriel Krisman Bertazi 
Signed-off-by: Greg Kroah-Hartman

tty: serial: jsm_tty: fixed redundant variable issue.

2016-02-07T21:36:09+00:00

The variable "len" gets assigned once and it's value copied to
"n", which is then used for the rest of the function.

This patch fixes the unnecessary variable reassignment by using "len"
throughout the function instead.

Signed-off-by: Jakob Østergaard Jensen 
Signed-off-by: Greg Kroah-Hartman

tty: Use termios c_*flag macros

2016-01-28T22:13:44+00:00

Expressions of the form "tty->termios.c_*flag & FLAG"
are more clearly expressed with the termios flags macros,
I_FLAG(), C_FLAG(), O_FLAG(), and L_FLAG().

Convert treewide.

Signed-off-by: Peter Hurley 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

serial/jsm: Deinline neo_parse_isr, save 688 bytes

2015-12-14T03:59:48+00:00

This function compiles to 811 bytes of machine code.

Signed-off-by: Denys Vlasenko 
CC: Jiri Slaby 
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

drivers: serial: jsm: Switch "jsm" to JSM_DRIVER_NAME

2015-12-14T03:59:48+00:00

This commit replaces every instance of the string "jsm"
in the driver with JSM_DRIVER_NAME, as the two are
equivalent. This should increase overall consistency.

Signed-off-by: Gavin Thomas Claugus 
Signed-off-by: Greg Kroah-Hartman

serial: jsm: some off by one bugs

2015-03-26T22:00:36+00:00

"brd->nasync" amd "brd->maxports" are the same.  They hold the number of
filled out channels in the brd->channels[] array.  These tests should
be ">=" instead of ">" so that we don't read one element past the end.

Signed-off-by: Dan Carpenter 
Acked-by: Thadeu Lima de Souza Cascardo 
Signed-off-by: Greg Kroah-Hartman

serial: jsm: Fix unnecessary space before function ptr arguments

2014-11-26T01:06:38+00:00

This commit deals with the checkpatch warning "Unnecessary space before
function pointer arguments".

Signed-off-by: Konrad Zapalowicz 
Signed-off-by: Greg Kroah-Hartman

serial: jsm: Replace magic value with the proper define

2014-11-26T01:06:38+00:00

The changed function flushes the tx UART and the '4' corresponds to the
UART_FCR_CLEAR_XMIT value. This commit replaces the magic number with
this define.

Signed-off-by: Konrad Zapalowicz 
Signed-off-by: Greg Kroah-Hartman

serial: jsm: Fix the alignment of the switch satement

2014-11-26T01:06:38+00:00

This commit fixes the alignment of the 'case's i the switch statement.

Signed-off-by: Konrad Zapalowicz 
Signed-off-by: Greg Kroah-Hartman

serial: jsm: Remove unnecessary if statement

2014-11-26T01:06:38+00:00

The flow of {neo,cls}_param() shows that at this stage the baud rate
has a non-zero value. This fact makes the if clausule obsolete and
acknowledges it's removal.

Signed-off-by: Konrad Zapalowicz 
Signed-off-by: Greg Kroah-Hartman