linux.git/drivers/tty/ipwireless, branch v5.14

ipwireless: remove unused ipw_tty::closing

2021-06-15T12:02:43+00:00

It's only set, but never read because commit 01261cb94318 ("tty:
ipwireless: Remove tty->closing abort from ipw_open()") removed last use
of tty::closing.

Cc: Jiri Kosina 
Cc: David Sterba 
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210610090307.2689-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: make tty_operations::chars_in_buffer return uint

2021-05-13T16:29:11+00:00

tty_operations::chars_in_buffer is another hook which is expected to
return values >= 0. So make it explicit by the return type too -- use
unsigned int.

Signed-off-by: Jiri Slaby 
Acked-By: Anton Ivanov 
Acked-by: David Sterba 
Cc: Jeff Dike 
Cc: Richard Weinberger 
Cc: Arnd Bergmann 
Cc: Samuel Iglesias Gonsalvez 
Cc: Jens Taprogge 
Cc: Karsten Keil 
Cc: Ulf Hansson 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Heiko Carstens 
Cc: Vasily Gorbik 
Cc: Christian Borntraeger 
Cc: David Lin 
Cc: Johan Hovold 
Cc: Alex Elder 
Cc: Jiri Kosina 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Oliver Neukum 
Cc: Felipe Balbi 
Cc: Mathias Nyman 
Cc: Marcel Holtmann 
Cc: Johan Hedberg 
Cc: Luiz Augusto von Dentz 
Link: https://lore.kernel.org/r/20210505091928.22010-27-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: make tty_operations::write_room return uint

2021-05-13T15:03:20+00:00

Line disciplines expect a positive value or zero returned from
tty->ops->write_room (invoked by tty_write_room). So make this
assumption explicit by using unsigned int as a return value. Both of
tty->ops->write_room and tty_write_room.

Signed-off-by: Jiri Slaby 
Acked-by: Laurentiu Tudor 
Acked-by: Alex Elder 
Acked-by: Max Filippov  # xtensa
Acked-by: David Sterba 
Acked-By: Anton Ivanov 
Acked-by: Geert Uytterhoeven 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Cc: Matt Turner 
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Jeff Dike 
Cc: Richard Weinberger 
Cc: Chris Zankel 
Cc: Arnd Bergmann 
Cc: Samuel Iglesias Gonsalvez 
Cc: Jens Taprogge 
Cc: Karsten Keil 
Cc: Scott Branden 
Cc: Ulf Hansson 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Heiko Carstens 
Cc: Vasily Gorbik 
Cc: Christian Borntraeger 
Cc: David Lin 
Cc: Johan Hovold 
Cc: Jiri Kosina 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Oliver Neukum 
Cc: Felipe Balbi 
Cc: Mathias Nyman 
Cc: Marcel Holtmann 
Cc: Johan Hedberg 
Cc: Luiz Augusto von Dentz 
Link: https://lore.kernel.org/r/20210505091928.22010-23-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: make everyone's write_room return >= 0

2021-03-10T08:34:09+00:00

The tty line disciplines don't expect tty_operations::write_room to
return negative values. Fix the five drivers which violate this.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-44-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: do not check tty_unregister_driver's return value

2021-03-10T08:34:09+00:00

These drivers check tty_unregister_driver return value. But they don't
handle a failure correctly (they free the driver in any case). So stop
checking tty_unregister_driver return value and remove also the prints.

In the next patch, tty_unregister_driver's return type will be switched
to void.

Cc: Chris Zankel 
Cc: Max Filippov 
Cc: linux-xtensa@linux-xtensa.org
Cc: Jiri Kosina 
Cc: David Sterba 
Reviewed-by: Max Filippov 
Acked-by: David Sterba 
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-34-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty_port: drop last traces of low_latency

2021-01-07T15:17:32+00:00

The main purpose of tty_port::low_latency was removed in commit
a9c3f68f3cd8 (tty: Fix low_latency BUG) back in 2014. It was left in
place for drivers as an optional tune knob. But only one driver has been
using it until the previous commit. So remove this misconcept
completely, given there are no users.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210105120239.28031-11-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: fix error handling

2020-09-04T16:08:16+00:00

ipwireless_send_packet() can only return 0 on success and -ENOMEM on
error, the caller should check non zero for error condition

Signed-off-by: Tong Zhang 
Acked-by: David Sterba 
Link: https://lore.kernel.org/r/20200821161942.36589-1-ztong0001@gmail.com
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: convert tasklets to use new tasklet_setup() API

2020-08-18T11:33:13+00:00

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier 
Signed-off-by: Allen Pais 
Link: https://lore.kernel.org/r/20200817085921.26033-2-allen.cryptic@gmail.com
Signed-off-by: Greg Kroah-Hartman

tty: add SPDX identifiers to Kconfig and Makefiles

2019-04-04T16:48:43+00:00

There were a few Kconfig and Makefiles under drivers/tty/ that were
missing a SPDX identifier.  Fix that up so that automated tools can
properly classify all kernel source files.

Cc: Jiri Slaby 
Cc: Jiri Kosina 
Cc: Rob Herring 
Acked-by: David Sterba 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: fix missing checks for ioremap

2019-03-27T16:28:23+00:00

ipw->attr_memory and ipw->common_memory are assigned with the
return value of ioremap. ioremap may fail, but no checks
are enforced. The fix inserts the checks to avoid potential
NULL pointer dereferences.

Signed-off-by: Kangjie Lu 
Reviewed-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman