linux.git/drivers/tty/ipwireless, branch v5.13

tty: make everyone's write_room return >= 0

2021-03-10T08:34:09+00:00

The tty line disciplines don't expect tty_operations::write_room to
return negative values. Fix the five drivers which violate this.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-44-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: do not check tty_unregister_driver's return value

2021-03-10T08:34:09+00:00

These drivers check tty_unregister_driver return value. But they don't
handle a failure correctly (they free the driver in any case). So stop
checking tty_unregister_driver return value and remove also the prints.

In the next patch, tty_unregister_driver's return type will be switched
to void.

Cc: Chris Zankel 
Cc: Max Filippov 
Cc: linux-xtensa@linux-xtensa.org
Cc: Jiri Kosina 
Cc: David Sterba 
Reviewed-by: Max Filippov 
Acked-by: David Sterba 
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-34-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty_port: drop last traces of low_latency

2021-01-07T15:17:32+00:00

The main purpose of tty_port::low_latency was removed in commit
a9c3f68f3cd8 (tty: Fix low_latency BUG) back in 2014. It was left in
place for drivers as an optional tune knob. But only one driver has been
using it until the previous commit. So remove this misconcept
completely, given there are no users.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210105120239.28031-11-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: fix error handling

2020-09-04T16:08:16+00:00

ipwireless_send_packet() can only return 0 on success and -ENOMEM on
error, the caller should check non zero for error condition

Signed-off-by: Tong Zhang 
Acked-by: David Sterba 
Link: https://lore.kernel.org/r/20200821161942.36589-1-ztong0001@gmail.com
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: convert tasklets to use new tasklet_setup() API

2020-08-18T11:33:13+00:00

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier 
Signed-off-by: Allen Pais 
Link: https://lore.kernel.org/r/20200817085921.26033-2-allen.cryptic@gmail.com
Signed-off-by: Greg Kroah-Hartman

tty: add SPDX identifiers to Kconfig and Makefiles

2019-04-04T16:48:43+00:00

There were a few Kconfig and Makefiles under drivers/tty/ that were
missing a SPDX identifier.  Fix that up so that automated tools can
properly classify all kernel source files.

Cc: Jiri Slaby 
Cc: Jiri Kosina 
Cc: Rob Herring 
Acked-by: David Sterba 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: fix missing checks for ioremap

2019-03-27T16:28:23+00:00

ipw->attr_memory and ipw->common_memory are assigned with the
return value of ioremap. ioremap may fail, but no checks
are enforced. The fix inserts the checks to avoid potential
NULL pointer dereferences.

Signed-off-by: Kangjie Lu 
Reviewed-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

tty: ipwireless: Fix potential NULL pointer dereference

2019-01-30T11:03:58+00:00

There is a potential NULL pointer dereference in case
alloc_ctrl_packet() fails and returns NULL.

Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem")
Signed-off-by: YueHaibing 
Signed-off-by: Greg Kroah-Hartman

ipwireless: switch to ->[sg]et_serial()

2018-10-13T04:50:31+00:00

Acked-by: David Sterba 
Signed-off-by: Al Viro

tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network_create

2018-04-23T08:57:06+00:00

ipwireless_network_create() is never called in atomic context.

The call chain ending up at ipwireless_network_create() is:
[1] ipwireless_network_create() <- config_ipwireless() <-
	ipwireless_attach()
ipwireless_attach() is only set as ".probe" in struct pcmcia_driver.

Despite never getting called from atomic context,
ipwireless_network_create() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai 
Reviewed-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman