linux.git/drivers/thunderbolt, branch v5.9-rc2

thunderbolt: merge fix for kunix_resource changes

2020-08-09T18:06:10+00:00

Signed-off-by: Stephen Rothwell 
Signed-off-by: Linus Torvalds

thunderbolt: Fix old style declaration warning

2020-07-02T11:50:11+00:00

Fix gcc build warning:

drivers/thunderbolt/quirks.c:21:1: warning:
 'static' is not at beginning of declaration [-Wold-style-declaration]
   21 | const static struct tb_quirk tb_quirks[] = {
      | ^~~~~

Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Signed-off-by: Mika Westerberg

thunderbolt: Add support for authenticate on disconnect

2020-07-01T10:51:49+00:00

Some external devices can support completing thunderbolt authentication
when they are unplugged. For this to work though, the link controller must
remain operational.

The only device known to support this right now is the Dell WD19TB, so add
a quirk for this.

Signed-off-by: Mario Limonciello 
Signed-off-by: Mika Westerberg

thunderbolt: Add support for separating the flush to SPI and authenticate

2020-07-01T10:51:49+00:00

This allows userspace to have a shorter period of time that the device
is unusable and to call it at a more convenient time.

For example flushing the image may happen while the user is using the
machine and authenticating/rebooting may happen while logging out.

Signed-off-by: Mario Limonciello 
Signed-off-by: Mika Westerberg

thunderbolt: Ensure left shift of 512 does not overflow a 32 bit int

2020-07-01T10:46:47+00:00

The 32 bit int value 512 is being left shifted and then used in a context
that expects the expression to be a larger unsigned long. There may be
a potential integer overflow, so make 512 a UL before shift to avoid
any such issues.

Addresses-Coverity: ("Uninintentional integer overflow")
Fixes: 3b1d8d577ca8 ("thunderbolt: Implement USB3 bandwidth negotiation routines")
Signed-off-by: Colin Ian King 
Signed-off-by: Mika Westerberg

thunderbolt: Add support for on-board retimers

2020-06-22T16:58:32+00:00

USB4 spec specifies standard access to retimers (both on-board and
cable) through USB4 port sideband access. This makes it possible to
upgrade their firmware in the same way than we already do with the
routers.

This enumerates on-board retimers under each USB4 port when the link
comes up and adds them to the bus under the router the retimer belongs
to. Retimers are exposed in sysfs with name like :.
where device is the router the retimer belongs to, port is the USB4 port
the retimer is connected to and index is the retimer index under that
port (starting from 1). This applies to the upstream USB4 port as well
so if there is on-board retimer between the port and the router it is
also added accordingly.

At this time we do not add cable retimers but there is no techincal
restriction to do so in the future if needed. It is not clear whether it
makes sense to upgrade their firmwares and at least Thunderbolt 3 cables
it has not been done outside of lab environments.

The sysfs interface is made to follow the router NVM upgrade to make it
easy to extend the existing userspace (fwupd) to handle these as well.

Signed-off-by: Kranthi Kuntala 
Co-developed-by: Mika Westerberg 
Signed-off-by: Mika Westerberg

thunderbolt: Implement USB4 port sideband operations for retimer access

2020-06-22T16:58:32+00:00

USB4 spec specifies standard set of sideband operations that are send
over the low speed link to access either retimers on the link or the
link parter (the other router). The USB4 retimer spec extends these and
adds operations for retimer NVM upgrade.

This implements the retimer access and NVM upgrade USB4 port sideband
operations which we need for retimer support in the patch that follows.

Signed-off-by: Rajmohan Mani 
Co-developed-by: Mika Westerberg 
Signed-off-by: Mika Westerberg

thunderbolt: Retry USB4 block read operation

2020-06-22T16:58:32+00:00

Especially when accessing retimers over USB4 sideband operations the
possibility to get read errors seems to be higher so make the
usb4_do_read_data() retry a couple of times if it sees any other error
than -ENODEV (device is gone). We can only do this for read side because
it carries the offset as part of metadata (as opposed to writes).

Signed-off-by: Mika Westerberg

thunderbolt: Generalize usb4_switch_do_[read|write]_data()

2020-06-22T16:58:32+00:00

Currently these functions operate on struct tb_switch but we are going
to need the same functionality with retimers as well so make the two
functions work with an arbitrary object that gets passed as parameter to
the callbacks.

Signed-off-by: Mika Westerberg

thunderbolt: Split common NVM functionality into a separate file

2020-06-22T16:58:32+00:00

We are going to reuse some of this functionality to implement retimer
NVM upgrade so move common NVM functionality into its own file. We also
rename the structure from tb_switch_nvm to tb_nvm to make it clear that
it is not just for switches.

Signed-off-by: Mika Westerberg