linux.git/drivers/thunderbolt, branch v3.17-rc2

thunderbolt: Use kcalloc

2014-07-13T20:16:50+00:00

The advantage of kcalloc is, that will prevent integer overflows
which could result from the multiplication of number of elements
and size and it is also a bit nicer to read.

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Acked-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Correct the size argument to devm_kzalloc

2014-07-08T01:56:20+00:00

nhi->rx_rings does not have type as struct tb_ring *, as it is a
double pointer so the elements of the array should have pointer type,
not structure type.

The Coccinelle semantic patch that makes this change is as follows:

// 
@disable sizeof_type_expr@
type T;
T **x;
@@

  x =
  <+...sizeof(
- T
+ *x
  )...+>
// 

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Cc: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: select CRC32 in Kconfig

2014-06-21T20:12:35+00:00

We use __crc32c_le in ctl.c. So make sure that the dependency is there.

Reported-by: kbuild test robot 
Signed-off-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Make tb_eeprom_get_drom_offset static

2014-06-20T20:06:01+00:00

tb_eeprom_get_drom_offset is local to this file.

Signed-off-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Make enum tb_drom_entry_type unsigned

2014-06-20T20:06:01+00:00

Force enum tb_drom_entry_type to unsigned to fix the following error:

drivers/thunderbolt/eeprom.c:202:39: error: dubious one-bit signed bitfield

Signed-off-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Fix header declaration of tb_find_cap

2014-06-20T20:06:01+00:00

tb_find_cap in cap.c takes an enum tb_cap and not an u32. Fix the
declaration in tb.h.

Signed-off-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Add casts to prevent endianness warnings

2014-06-20T20:06:01+00:00

Thunderbolt packets are big endian. Cast pkg->buffer to __be32* when
accessing the checksum.

Reported-by: kbuild test robot 
Signed-off-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: fix format string for size_t

2014-06-20T16:46:36+00:00

The result of "sizeof(struct tb_drom_entry_port)" is a size_t, which
is not necessarily the same as 'long', so we should use the appropriate
%z format string instead of %l.

Signed-off-by: Arnd Bergmann 
Acked-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: add PCI dependency

2014-06-20T16:46:36+00:00

The thunderbolt drivers cannot be built if CONFIG_PCI is disabled,
better add an explicit Kconfig dependency.
The "default no" line is redundant and can be removed at the same
time.

Signed-off-by: Arnd Bergmann 
Acked-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Staticize nhi_ids

2014-06-20T16:44:42+00:00

'nhi_ids' is local to this file.

Signed-off-by: Sachin Kamat 
Acked-by: Andreas Noever 
Signed-off-by: Greg Kroah-Hartman