linux.git/drivers/target, branch v4.2-rc5

iscsi-target: Fix iser explicit logout TX kthread leak

2015-07-24T21:19:44+00:00

This patch fixes a regression introduced with the following commit
in v4.0-rc1 code, where an explicit iser-target logout would result
in ->tx_thread_active being incorrectly cleared by the logout post
handler, and subsequent TX kthread leak:

    commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca
    Author: Nicholas Bellinger 
    Date:   Thu Feb 26 22:19:15 2015 -0800

        iscsi-target: Convert iscsi_thread_set usage to kthread.h

To address this bug, change iscsit_logout_post_handler_closesession()
and iscsit_logout_post_handler_samecid() to only cmpxchg() on
->tx_thread_active for traditional iscsi/tcp connections.

This is required because iscsi/tcp connections are invoking logout
post handler logic directly from TX kthread context, while iser
connections are invoking logout post handler logic from a seperate
workqueue context.

Cc: Sagi Grimberg 
Cc:  # v3.10+
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-24T21:19:43+00:00

This patch fixes a regression introduced with the following commit
in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers
a NULL pointer dereference OOPs:

    commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca
    Author: Nicholas Bellinger 
    Date:   Thu Feb 26 22:19:15 2015 -0800

        iscsi-target: Convert iscsi_thread_set usage to kthread.h

To address this bug, move iscsit_start_kthreads() immediately
preceeding the transmit of last login response, before signaling
a successful transition into full-feature-phase within existing
iscsi_target_do_tx_login_io() logic.

This ensures that no target-side resource allocation failures can
occur after the final login response has been successfully sent.

Also, it adds a iscsi_conn->rx_login_comp to allow the RX thread
to sleep to prevent other socket related failures until the final
iscsi_post_login_handler() call is able to complete.

Cc: Sagi Grimberg 
Cc:  # v3.10+
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix use-after-free during TPG session shutdown

2015-07-24T21:19:43+00:00

This patch fixes a use-after-free bug in iscsit_release_sessions_for_tpg()
where se_portal_group->session_lock was incorrectly released/re-acquired
while walking the active se_portal_group->tpg_sess_list.

The can result in a NULL pointer dereference when iscsit_close_session()
shutdown happens in the normal path asynchronously to this code, causing
a bogus dereference of an already freed list entry to occur.

To address this bug, walk the session list checking for the same state
as before, but move entries to a local list to avoid dropping the lock
while walking the active list.

As before, signal using iscsi_session->session_restatement=1 for those
list entries to be released locally by iscsit_free_session() code.

Reported-by: Sunilkumar Nadumuttlu 
Cc: Sunilkumar Nadumuttlu 
Cc:  # v3.1+
Signed-off-by: Nicholas Bellinger

target/configfs: handle match_int() errors

2015-07-24T06:41:22+00:00

As a follow up to ce31c1b0dc4038a1dec64585d892adb73d9c45f4 - there are
still a few LIO match_int() calls that don't check the return value.
Propagate errors rather than using the potentially uninitialised result.

Signed-off-by: David Disseldorp 
Signed-off-by: Nicholas Bellinger

target: Do not return 0 from aptpl and alua configfs store functions

2015-07-24T06:40:01+00:00

Here are some more instances where we are returning 0 from a configfs
store function, the unintended result of which is likely infinite retries
from userspace.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Indicate success if writing 0 to pi_prot_type

2015-07-24T06:39:59+00:00

See https://bugzilla.redhat.com/show_bug.cgi?id=1240687

Returning 0 from a configfs store function results in infinite retries.

Reported-by: Yanko Kaneti 
Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/rd: Set ramdisk as non rotational device

2015-07-07T01:07:19+00:00

Since a RAM backend device is not really a rotational device,
we set it as is_nonrot=1 which will be forwarded in VPD page 0xb1
(block device characteristics) response.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

target: Add extra TYPE_DISK + protection checks for INQUIRY SPT

2015-07-07T01:07:17+00:00

Cc: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

target/spc: Set SPT correctly in Extended INQUIRY Data VPD page

2015-07-07T01:07:03+00:00

LIO supports protection types 1,3 so setting a hard-coded SPT=3
is fine for now.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

target/pr: Fix possible uninitialized variable usage

2015-07-07T00:07:30+00:00

Triggered a compilation warning.

Fixes: 2650d71e2 target: move transport ID handling to the core

Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger