linux.git/drivers/target, branch v3.1-rc5

target: Convert acl_node_lock to be IRQ-disabling

2011-08-22T19:28:36+00:00

With qla2xxx, acl_node_lock is taken inside qla2xxx's hardware_lock,
which is taken in hardirq context.  This means acl_node_lock must become
an IRQ-disabling lock; in particular this fixes lockdep warnings along
the lines of

    ======================================================
    [ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]

     (&(&se_tpg->acl_node_lock)->rlock){+.....}, at: [] transport_deregister_session+0x92/0x140 [target_core_mod]

    and this task is already holding:
     (&(&ha->hardware_lock)->rlock){-.-...}, at: [] qla_tgt_stop_phase1+0x57/0x2c0 [qla2xxx]
    which would create a new lock dependency:
     (&(&ha->hardware_lock)->rlock){-.-...} -> (&(&se_tpg->acl_node_lock)->rlock){+.....}

    but this new dependency connects a HARDIRQ-irq-safe lock:
     (&(&ha->hardware_lock)->rlock){-.-...}

    to a HARDIRQ-irq-unsafe lock:
     (&(&se_tpg->acl_node_lock)->rlock){+.....}

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Make locking in transport_deregister_session() IRQ safe

2011-08-22T19:26:33+00:00

At least the tcm_qla2xxx fabric driver calls into transport_deregister_session()
while holding an IRQ-disabled spinlock, so the inner locking needs to
use spin_lock_irqsave() instead of spin_lock_bh().

This fixes warnings seen with tcm_qla2xxx like:

    WARNING: at kernel/softirq.c:159 local_bh_enable_ip+0x98/0xb0()
    Call Trace:
     [] warn_slowpath_common+0x7f/0xc0
     [] warn_slowpath_null+0x1a/0x20
     [] local_bh_enable_ip+0x98/0xb0
     [] _raw_spin_unlock_bh+0x14/0x20
     [] transport_deregister_session+0x96/0x180 [target_core_mod]
     [] tcm_qla2xxx_free_session+0xd1/0x170 [tcm_qla2xxx]
     [] qla_tgt_sess_put+0xc3/0x140 [qla2xxx]
     [] qla_tgt_stop_phase1+0x8f/0x2c0 [qla2xxx]
     [] tcm_qla2xxx_tpg_store_enable+0x6e/0xd0 [tcm_qla2xxx]
     [] target_fabric_tpg_attr_store+0x39/0x40 [target_core_mod]
     [] configfs_write_file+0xbd/0x120 [configfs]
     [] vfs_write+0xc6/0x180
     [] sys_write+0x51/0x90
     [] system_call_fastpath+0x16/0x1b

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

tcm_fc: init/exit functions should not be protected by "#ifdef MODULE"

2011-08-22T19:26:32+00:00

There's no need for the #ifdef protection when building into the kernel,
and in fact we need the module_init() for the initialization function to
be called.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Print subpage too for unhandled MODE SENSE pages

2011-08-22T19:26:31+00:00

Make a log message more useful by printing both the page and subpage
that an initiator is requesting.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix iscsit_allocate_se_cmd_for_tmr failure path bugs

2011-08-22T19:26:30+00:00

This patch fixes two bugs in allocation failure handling in
iscsit_allocate_se_cmd_for_tmr():

This first reported by DanC is a free-after call to transport_free_se_cmd(), this
patch drops the transport_free_se_cmd() call all together, as iscsit_release_cmd()
will release existing allocations as expected.

The second is a bug where iscsi_cmd_t was being leaked on a cmd->tmr_req allocation
failure, so make this jump to iscsit_release_cmd() as well.

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger

iscsi-target: Implement iSCSI target IPv6 address printing.

2011-08-22T19:26:29+00:00

The iSCSI target configfs code to print out an initiator's IPv6 address
is not fully implemented. This patch uses snprintf() with the "%pI6c"
format string to format the IPv6 address for display purposes.

Signed-off-by: Chris Boot 
Signed-off-by: Nicholas Bellinger

target: Fix task SGL chaining breakage with transport_allocate_data_tasks

2011-08-22T19:26:28+00:00

This patch fixes two bugs associated with transport_do_task_sg_chain()
operation where transport_allocate_data_tasks() was incorrectly setting
task_padded_sg for all tasks, and causing bogus task->task_sg_nents
assignments + OOPsen with fabrics depending upon this code.  The first bit
here adds a task_sg_nents_padded check in transport_allocate_data_tasks()
to include an extra SGL vector when necessary for tasks that expect to
be linked using sg_chain().

The second change involves making transport_do_task_sg_chain() properly
account for the extra SGL vector when task->task_padded_sg is set for
the non trailing ->task_sg or single ->task_sg allocations.  Note this
patch also removes the BUG_ON(!task->task_padded_sg) check within
transport_do_task_sg_chain() as we expect this to happen normally
with the updated logic in transport_allocate_data_tasks(), along with
being bogus for CONTROL_SG_IO_CDB type payloads.

So far this bugfix has been tested with tcm_qla2xxx and iblock backends
in (task_count > 1)( and (task_count == 1) operation.

Reported-by: Kiran Patil 
Cc: Kiran Patil 
Cc: Andy Grover 
Cc: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Fix task count > 1 handling breakage and use max_sector page alignment

2011-08-22T19:26:27+00:00

This patch addresses recent breakage with multiple se_task (task_count > 1)
operation following backend dev->se_sub_dev->se_dev_attrib.max_sectors in new
transport_allocate_data_tasks() code.  The initial bug here was a bogus
task->task_sg_nents assignment in transport_allocate_data_tasks() based on
the passed parameter, which now uses DIV_ROUND_UP(task_size, PAGE_SIZE) to
determine the proper number of per task SGL entries for the (task_count > 1)
case.

This also means we now need to enforce a PAGE_SIZE aligned max_sector count
value for this to work as expected without bringing back the pre v3.1
transport_map_mem_to_sg() logic to handle SGL offsets across multiple tasks.
So this patch adds se_dev_align_max_sectors() to round down max_sectors as
necessary to ensure this alignment via se_dev_set_default_attribs() and
se_dev_align_max_sectors() and keeps it simple for (task_count > 1)
operation.

So far this bugfix has been tested with (task_count > 1) operation
using iscsi-target and iblock backends.

Reported-by: Chris Boot 
Cc: Kiran Patil 
Cc: Andy Grover 
Cc: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Add missing DATA_SG_IO transport_cmd_get_valid_sectors check

2011-08-22T19:26:26+00:00

This patch adds the missing transport_cmd_get_valid_sectors() check for
SCF_SCSI_DATA_SG_IO_CDB type payloads to ensure that a received LBA + range
does not exeed past the end of associated backend struct se_device.

This patch also fixes a bug in the failure path of transport_new_cmd_obj()
where this check can fail, so change to use a signed 'rc' and return '-EINVAL'
to signal proper transport_generic_request_failure() handling.

Signed-off-by: Nicholas Bellinger

target: Fix SYNCHRONIZE_CACHE zero LBA + range breakage

2011-08-22T19:26:25+00:00

This patch fixes a SYNCHRONIZE_CACHE CDB handling bug with IBLOCK/FILEIO
backends where transport_cmd_get_valid_sectors() was incorrectly rejecting
a zero LBA + range CDB from being processed, and returning CHECK_CONDITION.

This includes changing transport_cmd_get_valid_sectors() to return '0' on
success and '-EINVAL' on failure (this makes more sense than sectors),
and to only check transport_cmd_get_valid_sectors() when a non zero LBA +
range SYNCHRONIZE_CACHE operation has been receieved for the non passthrough
case.

Signed-off-by: Nicholas Bellinger