linux.git/drivers/target/tcm_fc, branch v4.9

target/tcm_fc: use CPU affinity for responses

2016-10-21T08:19:44+00:00

The libfc stack assigns exchange IDs based on the CPU the request
was received on, so we need to send the responses via the same CPU.
Otherwise the send logic gets confuses and responses will be delayed,
causing exchange timeouts on the initiator side.

Signed-off-by: Hannes Reinecke 
Cc: stable@vger.kernel.org # 4.5+
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Update debugging statements to match libfc usage

2016-10-21T08:19:43+00:00

Update the debug statements to match those from libfc.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: return detailed error in ft_sess_create()

2016-10-21T08:19:42+00:00

Not every failure is due to out-of-memory; the ACLs might not be
set, too. So return a detailed error code in ft_sess_create()
instead of just a NULL pointer.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: print command pointer in debug message

2016-10-21T08:19:42+00:00

When allocating a new command we should add the pointer to the
debug statements; that allows us to match this with other debug
statements for handling data.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

tcm_fc: set and unset FCP_SPPF_TARG_FCN

2016-07-20T20:27:05+00:00

When registering and unregistering as an target port we should
be setting the FC-4 service params correctly.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: make ->shutdown_session optional

2016-05-10T08:19:18+00:00

Turns out the template and thus many drivers got the return value wrong:
0 means the fabrics driver needs to put a session reference, which no
driver except for the iSCSI target drivers did.  Fortunately none of these
drivers supports explicit Node ACLs, so the bug was harmless.

Even without that only qla2xxx and iscsi every did real work in
shutdown_session, so get rid of the boilerplate code in all other
drivers.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

tcm_fc: Convert to TARGET_SCF_ACK_KREF I/O + TMR krefs

2016-03-11T05:48:23+00:00

This patch converts tcm_fc to modern TARGET_SCF_ACK_KREF
usage for ft_queue_status(), and fixes ft_check_stop_free()
to return transport_generic_free_cmd() for ->cmd_kref.

It also converts TM request -> ft_send_tm() to use ACK_KREF,
and update ft_queue_tm_resp() to drop the outstanding kref
after queueing TM response into fabric code.

Cc: Vasu Dev 
Cc: Mark Rustad 
Cc: Robert Love 
Signed-off-by: Nicholas Bellinger

tcm_fc: Convert to target_alloc_session usage

2016-03-11T05:47:58+00:00

This patch converts tcm_fc target mode addition of tf_sess->hash to
port_id hlist_head using the new alloc_session callback().

Cc: Vasu Dev 
Cc: Mark Rustad 
Cc: Robert Love 
Signed-off-by: Nicholas Bellinger

tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage

2016-01-13T07:17:51+00:00

This patch does a simple conversion of tcm_fc code to use
proper modern core_tpg_get_initiator_node_acl() lookup using
se_node_acl->acl_kref, and drops the legacy list walk from
ft_acl_get().

Note the original lookup also took node_name into account,
but since ft_init_nodeacl() only ever sets port_name for
se_node_acl->acl_group within configfs, this is purely
a mechanical change.

As per HCH, go ahead and fold ft_acl_get() into original
caller.

Cc: Vasu Dev 
Cc: Sagi Grimberg 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

tcm_fc: Wait for command completion before freeing a session

2016-01-07T21:57:55+00:00

This patch avoids that the following kernel crash can occur with
later patches in this patch series:

general protection fault: 0000 [#1] SMP
CPU: 0 PID: 6 Comm: kworker/u8:0 Not tainted 4.3.0-rc1-debug+ #1
Workqueue: tmr-fileio target_tmr_work [target_core_mod]
Call Trace:
 [] lock_acquire+0x65/0x90
 [] _raw_spin_lock_irqsave+0x4b/0x60
 [] target_release_cmd_kref+0x2a/0xa0 [target_core_mod]
 [] target_put_sess_cmd+0x28/0x50 [target_core_mod]
 [] core_tmr_lun_reset+0x390/0x640 [target_core_mod]
 [] target_tmr_work+0x80/0xd0 [target_core_mod]
 [] process_one_work+0x19d/0x430
 [] worker_thread+0x10f/0x460
 [] kthread+0xea/0x100
 [] ret_from_fork+0x3f/0x70

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger