linux.git/drivers/target/target_core_user.c, branch v4.9

target/user: Fix comments to not refer to data ring

2016-10-20T04:22:23+00:00

We no longer use a ringbuffer for the data area, so this might cause
confusion. Just call it the data area.

Signed-off-by: Andy Grover 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Signed-off-by: Nicholas Bellinger

target/user: Return an error if cmd data size is too large

2016-10-20T04:22:16+00:00

Userspace should be implementing VPD B0 (Block Limits) to inform the
initiator of max data size, but just in case we do get a too-large request,
do what the spec says and return INVALID_CDB_FIELD.

Make sure to unlock udev->cmdr_lock before returning.

Signed-off-by: Andy Grover 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Signed-off-by: Nicholas Bellinger

target/user: Use sense_reason_t in tcmu_queue_cmd_ring

2016-10-20T04:21:45+00:00

Instead of using -ERROR-style returns, use sense_reason_t. This lets us
remove tcmu_pass_op(), and return more correct sense values.

Signed-off-by: Andy Grover 
Signed-off-by: Bryant G. Ly 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Signed-off-by: Nicholas Bellinger

target/user: Report capability of handling out-of-order completions to userspace

2016-03-11T05:49:09+00:00

TCMU_MAILBOX_FLAG_CAP_OOOC was introduced, and userspace can check the flag
for out-of-order completion capability support.

Also update the document on how to use the feature.

Signed-off-by: Sheng Yang 
Reviewed-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/user: Fix size_t format-spec build warning

2016-03-11T05:49:06+00:00

Fix the following printk size_t warning as per 0-day build:

All warnings (new ones prefixed by >>):

   drivers/target/target_core_user.c: In function 'is_ring_space_avail':
>> drivers/target/target_core_user.c:385:12: warning: format '%lu'
>> expects argument of type 'long unsigned int', but argument 3 has type
>> 'size_t {aka unsigned int}' [-Wformat=]
      pr_debug("no data space: only %lu available, but ask for %lu\n",
               ^

Reported-by: kbuild test robot 
Signed-off-by: Nicholas Bellinger

target/user: Don't free expired command when time out

2016-03-11T05:49:04+00:00

Which would result in NPE after when userspace connected again.

Expired command would be freed either when handling command(by userspace),
or when device was tearing down

Reviewed-by: Andy Grover 
Signed-off-by: Sheng Yang 
Signed-off-by: Nicholas Bellinger

target/user: Introduce data_bitmap, replace data_length/data_head/data_tail

2016-03-11T05:49:02+00:00

The data_bitmap was introduced to support asynchornization accessing of
data area.

We divide mailbox data area into blocks, and use data_bitmap to track the
usage of data area. All the new command's data would start with a new block,
and may left unusable space after it end. But it's easy to track using
data_bitmap.

Now we can allocate data area for asynchronization accessing from userspace,
since we can track the allocation using data_bitmap. The userspace part would
be the same as Maxim's previous asynchronized implementation.

Signed-off-by: Sheng Yang 
Signed-off-by: Nicholas Bellinger

target/user: Free data ring in unified function

2016-03-11T05:49:00+00:00

Prepare for data_bitmap in the next patch.

Reviewed-by: Andy Grover 
Signed-off-by: Sheng Yang 
Signed-off-by: Nicholas Bellinger

target/user: Use iovec[] to describe continuous area

2016-03-11T05:48:57+00:00

We don't need use one iovec per scatter-gather list entry, since data
area are continuous.

Reviewed-by: Andy Grover 
Signed-off-by: Sheng Yang 
Signed-off-by: Nicholas Bellinger

target/user: Fix cast from pointer to phys_addr_t

2016-02-06T23:59:57+00:00

The uio_mem structure has a member that is a phys_addr_t, but can
be a number of other types too. The target core driver attempts
to assign a pointer from vmalloc() to it, by casting it to
phys_addr_t, but that causes a warning when phys_addr_t is longer
than a pointer:

drivers/target/target_core_user.c: In function 'tcmu_configure_device':
drivers/target/target_core_user.c:906:22: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

This adds another cast to uintptr_t to shut up the warning.
A nicer fix might be to have additional fields in uio_mem
for the different purposes, so we can assign a pointer directly.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Nicholas Bellinger