linux.git/drivers/target/target_core_user.c, branch v4.19

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2018-08-16T05:06:26+00:00

Pull SCSI updates from James Bottomley:
 "This is mostly updates to the usual drivers: mpt3sas, lpfc, qla2xxx,
  hisi_sas, smartpqi, megaraid_sas, arcmsr.

  In addition, with the continuing absence of Nic we have target updates
  for tcmu and target core (all with reviews and acks).

  The biggest observable change is going to be that we're (again) trying
  to switch to mulitqueue as the default (a user can still override the
  setting on the kernel command line).

  Other major core stuff is the removal of the remaining Microchannel
  drivers, an update of the internal timers and some reworks of
  completion and result handling"

* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (203 commits)
  scsi: core: use blk_mq_run_hw_queues in scsi_kick_queue
  scsi: ufs: remove unnecessary query(DM) UPIU trace
  scsi: qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()
  scsi: aacraid: Spelling fix in comment
  scsi: mpt3sas: Fix calltrace observed while running IO & reset
  scsi: aic94xx: fix an error code in aic94xx_init()
  scsi: st: remove redundant pointer STbuffer
  scsi: qla2xxx: Update driver version to 10.00.00.08-k
  scsi: qla2xxx: Migrate NVME N2N handling into state machine
  scsi: qla2xxx: Save frame payload size from ICB
  scsi: qla2xxx: Fix stalled relogin
  scsi: qla2xxx: Fix race between switch cmd completion and timeout
  scsi: qla2xxx: Fix Management Server NPort handle reservation logic
  scsi: qla2xxx: Flush mailbox commands on chip reset
  scsi: qla2xxx: Fix unintended Logout
  scsi: qla2xxx: Fix session state stuck in Get Port DB
  scsi: qla2xxx: Fix redundant fc_rport registration
  scsi: qla2xxx: Silent erroneous message
  scsi: qla2xxx: Prevent sysfs access when chip is down
  scsi: qla2xxx: Add longer window for chip reset
  ...

scsi: tcmu: use u64 for dev_size

2018-07-31T03:29:34+00:00

We use unsigned long, size_t and u64 for dev_size. This has us standardize
on u64.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: use match_int for dev params

2018-07-31T03:17:53+00:00

Instead of doing strdup and kstrto* just use match_int for dev params.

It will be ok to use int instead of unsigned long in tcmu_set_dev_attrib
because that is only being used for max sectors and block size and the
supported values for them are well under the max possible integer value.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: do not set max_blocks if data_bitmap has been setup

2018-07-31T03:17:53+00:00

This patch prevents a bug where data_bitmap is allocated in
tcmu_configure_device, userspace changes the max_blocks setting, the device
is mapped to a LUN, then we try to access the data_bitmap based on the new
max_blocks limit which may now be out of range.

To prevent this, we just check if data_bitmap has been setup. If it has
then we fail the max_blocks update operation.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: unmap if dev is configured

2018-07-31T03:17:53+00:00

The tcmu dev is added to the list of tcmu devices during configuration.  At
this time the tcmu setup has completed, but lio core has not completed its
setup. The device is not yet usable so do not try to unmap blocks from it

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: check if dev is configured before block/reset

2018-07-31T03:17:53+00:00

Do not allow userspace to block or reset the ring until the device has been
configured. This will prevent the bug where userspace can write to those
files and access mb_addr before it has been setup.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: use lio core se_device configuration helper

2018-07-31T03:17:53+00:00

Use the lio core helper to check if the device is configured.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: initialize list head

2018-07-31T03:17:53+00:00

Use INIT_LIST_HEAD to initialize node list head.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: target_core_user: fix double unlock

2018-07-31T03:17:53+00:00

The caller of queue_cmd_ring grabs and releases the lock, so the
tcmu_setup_cmd_timer failure handling inside queue_cmd_ring should not call
mutex_unlock.

Signed-off-by: Mike Christie 
Reviewed-by: Xiubo Li 
Signed-off-by: Martin K. Petersen

scsi: tcmu: Don't pass KERN_ERR to pr_err

2018-06-26T16:55:08+00:00

Fix warning:

smatch warnings:
drivers/target/target_core_user.c:301 tcmu_genl_cmd_done() warn: KERN_*
level not at start of string

Signed-off-by: Mike Christie 
Signed-off-by: Martin K. Petersen