linux.git/drivers/target/target_core_pr.c, branch v4.18

scsi: target: Fix truncated PR-in ReadKeys response

2018-06-20T01:36:37+00:00

SPC5r17 states that the contents of the ADDITIONAL LENGTH field are not
altered based on the allocation length, so always calculate and pack the
full key list length even if the list itself is truncated.

According to Maged:

  Yes it fixes the "Storage Spaces Persistent Reservation" test in the
  Windows 2016 Server Failover Cluster validation suites when having
  many connections that result in more than 8 registrations. I tested
  your patch on 4.17 with iblock.

This behaviour can be tested using the libiscsi PrinReadKeys.Truncate test.

Cc: stable@vger.kernel.org
Signed-off-by: David Disseldorp 
Reviewed-by: Mike Christie 
Tested-by: Maged Mokhtar 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

target-core: don't use "const char*" for a buffer that is written to

2018-01-12T23:07:09+00:00

iscsi_parse_pr_out_transport_id launders the const away via a call to
strstr(), and then modifies the buffer (writing a nul byte) through
the return value. It's cleaner to be honest and simply declare the
parameter as "char*", fixing up the call chain, and allowing us to
drop the cast in the return statement.

Amusingly, the two current callers found it necessary to cast a
non-const pointer to a const.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Nicholas Bellinger

target: Suppress gcc 7 fallthrough warnings

2017-11-04T22:15:35+00:00

Avoid that gcc 7 reports the following warning when building with W=1:

warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Mike Christie 
Cc: Varun Prakash 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: fix PR state file path truncation

2017-11-04T22:00:17+00:00

If an LIO backstore is configured with a sufficiently long Unit Serial
string, alongside a similarly long dbroot path, then a truncated
Persistent Reservation APTPL state file path will be used. This
truncation can unintentionally lead to two LUs with differing serial
numbers sharing PR state file.

Fixes: fdddf932269a ("target: use new "dbroot" target attribute")
Signed-off-by: David Disseldorp 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target:fix condition return in core_pr_dump_initiator_port()

2017-11-04T21:45:24+00:00

When is pr_reg->isid_present_at_reg is false,this function should return.

This fixes a regression originally introduced by:

  commit d2843c173ee53cf4c12e7dfedc069a5bc76f0ac5
  Author: Andy Grover 
  Date:   Thu May 16 10:40:55 2013 -0700

      target: Alter core_pr_dump_initiator_port for ease of use

Signed-off-by: tangwenji 
Signed-off-by: Nicholas Bellinger

target: add sense code INSUFFICIENT REGISTRATION RESOURCES

2017-11-04T21:45:23+00:00

If a PERSISTENT RESERVE OUT command with a REGISTER service action or a
REGISTER AND IGNORE EXISTING KEY service action or REGISTER AND MOVE
service action is attempted, but there are insufficient device server
resources to complete the operation, then the command shall be terminated
with CHECK CONDITION status, with the sense key set to ILLEGAL REQUEST,and
the additonal sense code set to INSUFFICIENT REGISTRATION RESOURCES.

Signed-off-by: tangwenji 
Signed-off-by: Nicholas Bellinger

target: fix double unmap data sg in core_scsi3_emulate_pro_register_and_move()

2017-11-04T21:45:22+00:00

Signed-off-by: tangwenji 
Signed-off-by: Nicholas Bellinger

target: fix buffer offset in core_scsi3_pri_read_full_status

2017-11-04T21:45:21+00:00

When at least two initiators register pr on the same LUN,
the target returns the exception data due to buffer offset
error, therefore the initiator executes command 'sg_persist -s'
may cause the initiator to appear segfault error.

This fixes a regression originally introduced by:

  commit a85d667e58bddf73be84d1981b41eaac985ed216
  Author: Bart Van Assche 
  Date:   Tue May 23 16:48:27 2017 -0700

      target: Use {get,put}_unaligned_be*() instead of open coding these functions

Signed-off-by: tangwenji 
Cc: stable@vger.kernel.org # 4.13+
Signed-off-by: Nicholas Bellinger

fs: fix kernel_write prototype

2017-09-04T23:05:15+00:00

Make the position an in/out argument like all the other read/write
helpers and and make the buf argument a void pointer.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

target: Fix return sense reason in target_scsi3_emulate_pr_out

2017-07-10T03:59:17+00:00

The sense reason should be TCM_PARAMETER_LIST_LENGTH_ERROR when
parmeter length error.

Also the cdb[1] & 0x1f has been assigned to local variable sa,
so use sa instead of it.

Signed-off-by: Tang Wenji 
Signed-off-by: Nicholas Bellinger