linux.git/drivers/target/target_core_device.c, branch v3.4

target: remove obvious warnings

2012-03-16T02:16:09+00:00

Get rid of a bunch of write-only variables.  In a number of cases I
suspect actual bugs to be present, so I left all of those for a second
look.

(nab: fix lio-core patch fuzz)

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Use array_zalloc for device_list

2012-03-16T02:15:51+00:00

Turns an order-8 allocation into slab-sized ones, thereby preventing
allocation failures with memory fragmentation.

This likely saves memory as well, as the slab allocator can pack objects
more tightly than the buddy allocator.

(nab: Fix lio-core patch fuzz)

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Use array_zalloc for tpg_lun_list

2012-03-16T02:15:38+00:00

Turns an order-10 allocation into slab-sized ones, thereby preventing
allocation failures with memory fragmentation.

This likely saves memory as well, as the slab allocator can pack objects
more tightly than the buddy allocator.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Fix off-by-seven in target_report_luns

2012-02-25T22:37:50+00:00

cdb_offset is always equal to offset - 8, so remove that one.  More
importantly, the existing code only worked correct if
se_cmd->data_length is a multiple of 8.  Pass in a length of, say, 9 and
we will happily overwrite 7 bytes of "unallocated" memory.

Now, afaics this bug is currently harmless, as allocations will
implicitly be padded to multiples of 8 bytes.  But depending on such a
fact wouldn't qualify as sound engineering practice.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: prevent NULL pointer dereference in target_report_luns

2012-02-25T22:37:50+00:00

transport_kmap_data_sg can return NULL.  I never saw this trigger, but
returning -ENOMEM seems better than a crash.  Also removes a pointless
case while at it.

Signed-off-by: Joern Engel 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: fix use after free in target_report_luns

2012-02-25T22:37:50+00:00

Fix possible NULL pointer dereference in target_report_luns failure path.

Signed-off-by: Joern Engel 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: Untangle front-end and back-end meanings of max_sectors attribute

2012-02-25T22:37:49+00:00

se_dev_attrib.max_sectors currently has two independent meanings:

 - It is reported in the block limits VPD page as the maximum transfer
   length, ie the largest IO that the front-end (fabric) can handle.
   Also the target core doesn't enforce this maximum transfer length.

 - It is used to hold the size of the largest IO that the back-end can
   handle, so we know when to split SCSI commands into multiple tasks.

Fix this by adding a new se_dev_attrib.fabric_max_sectors to hold the
maximum transfer length, and checking incoming IOs against that limit.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: remove the transport_lun_active field in struct se_cmd

2012-02-25T22:37:46+00:00

There is no reason to have a flag telling if a command is on the per-lun list,
we can simply do a list_empty check before removing it as long as we're careful
to always use list_del_init.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Allow control CDBs with data > 1 page

2012-01-18T08:35:58+00:00

We need to handle >1 page control cdbs, so extend the code to do a vmap
if bigger than 1 page. It seems like kmap() is still preferable if just
a page, fewer TLB shootdowns(?), so keep using that when possible.

Rename function pair for their new scope.

Signed-off-by: Andy Grover 
Cc: 
Signed-off-by: Nicholas Bellinger

target: fix return code of core_tpg_.*_lun

2012-01-18T08:33:44+00:00

- core_tpg_pre_addlun()
  returns always ERR_PTR() or the pointer, never NULL. The additional
  check for NULL in core_dev_add_lun() is not required.

- core_tpg_pre_dellun()
  returns always ERR_PTR() or the pointer, never NULL. The check for NULL
  in core_dev_del_lun() is wrong. The third argument (int *) is never
  used, remove it.

- core_dev_add_lun()
  returns always NULL or the pointer, never ERR_PTR. The check for
  IS_ERR() is not required.

(nab: Convert core_dev_add_lun() use err.h macros for failure
handling to be consistent with the rest of target_core_fabric_configfs.c
callers)

Signed-off-by: Sebastian Andrzej Siewior 
Cc: 
Signed-off-by: Nicholas Bellinger