linux.git/drivers/staging, branch v3.12-rc4

staging: comedi: ni_65xx: (bug fix) confine insn_bits to one subdevice

2013-10-03T21:27:32+00:00

The `insn_bits` handler `ni_65xx_dio_insn_bits()` has a `for` loop that
currently writes (optionally) and reads back up to 5 "ports" consisting
of 8 channels each.  It reads up to 32 1-bit channels but can only read
and write a whole port at once - it needs to handle up to 5 ports as the
first channel it reads might not be aligned on a port boundary.  It
breaks out of the loop early if the next port it handles is beyond the
final port on the card.  It also breaks out early on the 5th port in the
loop if the first channel was aligned.  Unfortunately, it doesn't check
that the current port it is dealing with belongs to the comedi subdevice
the `insn_bits` handler is acting on.  That's a bug.

Redo the `for` loop to terminate after the final port belonging to the
subdevice, changing the loop variable in the process to simplify things
a bit.  The `for` loop could now try and handle more than 5 ports if the
subdevice has more than 40 channels, but the test `if (bitshift >= 32)`
ensures it will break out early after 4 or 5 ports (depending on whether
the first channel is aligned on a port boundary).  (`bitshift` will be
between -7 and 7 inclusive on the first iteration, increasing by 8 for
each subsequent operation.)

Signed-off-by: Ian Abbott 
Cc:  # 3.10.y 3.11.y 3.12.y
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add new device ID

2013-09-26T23:44:45+00:00

The DLink DWA-125 Rev D1 also uses this driver.

Signed-off-by: Larry Finger 
Reported-by: Sergey Kostanbaev 
Tested-by: Sergey Kostanbaev 
Cc: Sergey Kostanbaev 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: imx-drm: Fix probe failure

2013-09-25T23:53:40+00:00

Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe
failure is seen:

[drm] Supports vblank timestamp caching Rev 1 (10.10.2010).
[drm] No driver support for vblank timestamp query.
[drm] Initialized imx-drm 1.0.0 20120507 on minor 0
imx-ldb ldb.10: adding encoder failed with -16
imx-ldb: probe of ldb.10 failed with error -16
imx-ipuv3 2400000.ipu: IPUv3H probed
imx-ipuv3 2800000.ipu: IPUv3H probed
imx-ipuv3-crtc imx-ipuv3-crtc.0: adding crtc failed with -16.
imx-ipuv3-crtc: probe of imx-ipuv3-crtc.0 failed with error -16
imx-ipuv3-crtc imx-ipuv3-crtc.1: adding crtc failed with -16.
imx-ipuv3-crtc: probe of imx-ipuv3-crtc.1 failed with error -16
imx-ipuv3-crtc imx-ipuv3-crtc.2: adding crtc failed with -16.
imx-ipuv3-crtc: probe of imx-ipuv3-crtc.2 failed with error -16
imx-ipuv3-crtc imx-ipuv3-crtc.3: adding crtc failed with -16.
imx-ipuv3-crtc: probe of imx-ipuv3-crtc.3 failed with error -16

The reason for the probe failure is that now 'imxdrm->references' is incremented
early in imx_drm_driver_load(), so the following checks in imx_drm_add_crtc()
and imx_drm_add_encoder():

	if (imxdrm->references) {
		ret = -EBUSY;
		goto err_busy;
	}

,will always fail.

Instead of manually keeping the references in the imx-drm driver, let's use
drm->open_count.

After this patch, lvds panel is functional on a mx6qsabrelite board.

Signed-off-by: Fabio Estevam 
Acked-by: Sascha Hauer 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: [BUG] iwctl_siwencodeext return if device not open

2013-09-25T23:53:40+00:00

Don't allow entry to iwctl_siwencodeext if device not open.

This fixes a race condition where wpa supplicant/network manager
enters the function when the device is already closed.

Signed-off-by: Malcolm Priestley 
Cc: stable@vger.kernel.org # 3.8+
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: [BUG] main_usb.c oops on device_close move flag earlier.

2013-09-25T23:53:40+00:00

The vt6656 is prone to resetting on the usb bus.

It seems there is a race condition and wpa supplicant is
trying to open the device via iw_handlers before its actually
closed at a stage that the buffers are being removed.

The device is longer considered open when the
buffers are being removed. So move ~DEVICE_FLAGS_OPENED
flag to before freeing the device buffers.

Signed-off-by: Malcolm Priestley 
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: rxtx.c [BUG] s_vGetFreeContext dead lock on null apTD.

2013-09-25T23:53:39+00:00

There seems to be race condition that the device is ndo_start_xmit
at a point where the device is closing and apTD is NULL resulting
in dead lock.

Add a NULL check to apTD and return NULL to calling functions.

This is more likely on 64 bit systems.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8192u: r819xU_cmdpkt: checking NULL value after doing dev_alloc_skb

2013-09-25T23:53:39+00:00

Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60411

Signed-off-by: Iker Pedrosa 
Reported-by: RUC_Soft_Sec rucsoftsec@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add files for new drive: Cocci spatch "noderef"

2013-09-25T23:53:39+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Cocci spatch "noderef"

2013-09-25T23:53:39+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

staging: octeon-usb: Cocci spatch "noderef"

2013-09-25T23:53:39+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman