linux.git/drivers/staging/zram, branch v3.13

Staging: zram: Fix memory leak by refcount mismatch

2013-11-25T17:14:29+00:00

As suggested by Minchan Kim and Jerome Marchand "The code in reset_store
get the block device (bdget_disk()) but it does not put it (bdput()) when
it's done using it. The usage count is therefore incremented but never
decremented."

This patch also puts bdput() for all error cases.

Acked-by: Minchan Kim 
Acked-by: Jerome Marchand 
Cc: stable@vger.kernel.org
Signed-off-by: Rashika Kheria 
Signed-off-by: Greg Kroah-Hartman

Staging: zram: Fix access of NULL pointer

2013-10-30T16:36:53+00:00

This patch fixes the bug in reset_store caused by accessing NULL pointer.

The bdev gets its value from bdget_disk() which could fail when memory
pressure is severe and hence can return NULL because allocation of
inode in bdget could fail.

Hence, this patch introduces a check for bdev to prevent reference to a
NULL pointer in the later part of the code. It also removes unnecessary
check of bdev for fsync_bdev().

Cc: stable 
Acked-by: Jerome Marchand 
Signed-off-by: Rashika Kheria 
Acked-by: Minchan Kim 
Signed-off-by: Greg Kroah-Hartman

Staging: zram: Fix variable dereferenced before check

2013-10-30T16:32:10+00:00

This patch fixes the following Smatch warning in zram_drv.c-
drivers/staging/zram/zram_drv.c:899
destroy_device() warn: variable dereferenced before check 'zram->disk' (see line 896)

Acked-by: Minchan Kim 
Acked-by: Jerome Marchand 
Signed-off-by: Rashika Kheria 
Signed-off-by: Greg Kroah-Hartman

Revert "staging: zram: Add auto loading of module if user opens /dev/zram."

2013-09-17T14:39:28+00:00

This reverts commit c70bda992c12e593e411c02a52e4bd6985407539.

It's incorrect, Kay writes:
	Please just remove it. "devname" is meant to be used for
	single-instance devices with a static dev_t, never for things
	like zramX.

	It will not do anything useful here, it does nothing really
	without a statically assigned dev_t, and it should not be used
	for devices of this kind anyway.

Reported-by: Tom Gundersen 
Reported-by: Kay Sievers 
Cc: Minchan Kim 
Cc: Konrad Rzeszutek Wilk 
Signed-off-by: Greg Kroah-Hartman

zram: don't grab mutex in zram_slot_free_noity

2013-08-12T22:25:00+00:00

[1] introduced down_write in zram_slot_free_notify to prevent race
between zram_slot_free_notify and zram_bvec_[read|write]. The race
could happen if somebody who has right permission to open swap device
is reading swap device while it is used by swap in parallel.

However, zram_slot_free_notify is called with holding spin_lock of
swap layer so we shouldn't avoid holing mutex. Otherwise, lockdep
warns it.

This patch adds new list to handle free slot and workqueue
so zram_slot_free_notify just registers slot index to be freed and
registers the request to workqueue. If workqueue is expired,
it holds mutex_lock so there is no problem any more.

If any I/O is issued, zram handles pending slot-free request
caused by zram_slot_free_notify right before handling issued
request because workqueue wouldn't be expired yet so zram I/O
request handling function can miss it.

Lastly, when zram is reset, flush_work could handle all of pending
free request so we shouldn't have memory leak.

NOTE: If zram_slot_free_notify's kmalloc with GFP_ATOMIC would be
failed, the slot will be freed when next write I/O write the slot.

[1] [57ab0485, zram: use zram->lock to protect zram_free_page()
    in swap free notify path]

* from v2
  * refactoring

* from v1
  * totally redesign

Cc: Nitin Gupta 
Cc: Jiang Liu 
Cc: stable@vger.kernel.org
Signed-off-by: Minchan Kim 
Signed-off-by: Greg Kroah-Hartman

zram: fix invalid memory access

2013-08-12T22:24:59+00:00

[1] tried to fix invalid memory access on zram->disk but it didn't
fix properly because get_disk failed during module exit path.

Actually, we don't need to reset zram->disk's capacity to zero
in module exit path so that this patch introduces new argument
"reset_capacity" on zram_reset_divice and it only reset it when
reset_store is called.

[1] 6030ea9b,  zram: avoid invalid memory access in zram_exit()

Cc: Nitin Gupta 
Cc: Jiang Liu 
Cc: stable@vger.kernel.org
Signed-off-by: Minchan Kim 
Signed-off-by: Greg Kroah-Hartman

Staging: zram: zram_drv.c: Fixed Error of trailing whitespace

2013-08-12T22:20:25+00:00

Fixed by removing trailing whitespace

Signed-off-by: Kumar Gaurav 
Signed-off-by: Greg Kroah-Hartman

Merge 3.11-rc3 into staging-next

2013-07-29T14:40:10+00:00

We want these fixes here.

Signed-off-by: Greg Kroah-Hartman

zram: prevent data loss in error cases of function zram_bvec_write()

2013-07-26T23:30:05+00:00

In function zram_bvec_write(), previous data at the index is
already freed by function zram_free_page().
When failed to compress or zs_malloc, there is no way to restore old data.
Therefore, free previous data when it's about to update.

Also, no need to check whether table is not empty outside of
function zram_free_page(), because the function properly checks inside.

Signed-off-by: Sunghan Suh 
Signed-off-by: Greg Kroah-Hartman

staging: zram: Add auto loading of module if user opens /dev/zram.

2013-07-25T20:38:25+00:00

Greg spotted that said driver is not subscribing to the automagic
mechanism of auto-loading if a user tries to open /dev/zram.

This fixes it.

CC: Minchan Kim 
Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Greg Kroah-Hartman