linux.git/drivers/staging/vt6656, branch v3.13

staging: vt6656: [BUG] Fix for TX USB resets from vendors driver.

2013-11-25T17:14:29+00:00

This fixes resets on heavy TX data traffic.

Vendor driver
VT6656_Linux_src_v1.21.03_x86_11.04.zip
http://www.viaembedded.com/servlet/downloadSvl?id=1890&download_file_id=14704
This is GPL-licensed code.

original code
BBbVT3184Init
...
//2007-0725, RobertChang add, Enable Squelch detect reset option(SQ_RST_Opt), USB (register4, bit1)
CONTROLnsRequestIn(pDevice,
                                 MESSAGE_TYPE_READ,
                                 (WORD)0x600+4,     // USB's Reg4's bit1
                                 MESSAGE_REQUEST_MEM,
                                 1,
                                 (PBYTE) &byData);
byData = byData|2 ;
CONTROLnsRequestOut(pDevice,
                              MESSAGE_TYPE_WRITE,
                              (WORD)0x600+4,     // USB's Reg4's bit1
                              MESSAGE_REQUEST_MEM,
                              1,
                              (PBYTE) &byData);

return TRUE;//ntStatus;
....

A back port patch is needed for kernels less than 3.10.

Signed-off-by: Malcolm Priestley 
Cc: stable@vger.kernel.org # v3.10+
Signed-off-by: Greg Kroah-Hartman

Staging: vt6655-6: potential NULL dereference in hostap_disable_hostapd()

2013-11-25T17:14:29+00:00

We fixed this to use free_netdev() instead of kfree() but unfortunately
free_netdev() doesn't accept NULL pointers.  Smatch complains about
this, it's not something I discovered through testing.

Fixes: 3030d40b5036 ('staging: vt6655: use free_netdev instead of kfree')
Fixes: 0a438d5b381e ('staging: vt6656: use free_netdev instead of kfree')
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: removed space after '*' in pointer declaration

2013-10-28T03:38:24+00:00

space after '*' in pointer declaration is not preferred in linux
and results in checkpatch error. Hence removed the spaces present
after the '*' in pointer declarations to fix the checkpatch errors

Signed-off-by: Nandini Hanumanthagowda 
Reviewed-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

Staging: vt6656: fix code indenting error in power.c

2013-10-28T03:36:44+00:00

This patch fixes a code indentation error found by checkpatch.pl
where a line was indented with spaces instead of tabs

Signed-off-by: Johannes Löthberg 
Signed-off-by: Greg Kroah-Hartman

Staging: vt6656: Fix Sparse Warning: cast from restricted gfp_t in hostap.c

2013-10-28T03:36:44+00:00

This patch fixes the following type of sparse warnings:

drivers/staging/vt6656/hostap.c:688:42: warning: cast from restricted gfp_t
drivers/staging/vt6656/hostap.c:688:42: warning: incorrect type in argument 2 (different base types)
drivers/staging/vt6656/hostap.c:688:42: expected restricted gfp_t [usertype] flags
drivers/staging/vt6656/hostap.c:688:42: got int [signed] 

Signed-off-by: Ebru Akagunduz 
Signed-off-by: Greg Kroah-Hartman

Staging: vt6656: fix a brace coding style issue in power.c

2013-10-27T13:53:18+00:00

This patch fixes a brace warning in power.c found by checkpatch.pl

Signed-off-by: Johannes Löthberg 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: removed braces from single line if-statement

2013-10-27T13:51:25+00:00

removed braces from if-control flow structs whenever it
contained only one statement to comply with the coding style

Signed-off-by: Nandini Hanumanthagowda 
Reviewed-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: fixed indentation and unnecessary space errors

2013-10-27T13:51:25+00:00

Fixed the indentation errors and removed unnecessary space
warnings to comply with coding style

Signed-off-by: Nandini Hanumanthagowda 
Reviewed-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: call usb_device_reset before netdev registration

2013-10-27T13:50:10+00:00

The USB reset occurs after netdev registration if network manager
calls device_open too fast causing USB fails in main_usb.c: device_init_registers.

Move the usb reset to before register_netdev.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: removed line over 80 chars warning

2013-10-17T20:34:23+00:00

Removed the checkpatch warning of line over 80 chars
by breaking the long line into sensible chunks of 2 lines
to comply with coding style

Signed-off-by: Nandini Hanumanthagowda 
Signed-off-by: Greg Kroah-Hartman