linux.git/drivers/staging/vt6656, branch v3.12

staging: vt6656: [BUG] iwctl_siwencodeext return if device not open

2013-09-25T23:53:40+00:00

Don't allow entry to iwctl_siwencodeext if device not open.

This fixes a race condition where wpa supplicant/network manager
enters the function when the device is already closed.

Signed-off-by: Malcolm Priestley 
Cc: stable@vger.kernel.org # 3.8+
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: [BUG] main_usb.c oops on device_close move flag earlier.

2013-09-25T23:53:40+00:00

The vt6656 is prone to resetting on the usb bus.

It seems there is a race condition and wpa supplicant is
trying to open the device via iw_handlers before its actually
closed at a stage that the buffers are being removed.

The device is longer considered open when the
buffers are being removed. So move ~DEVICE_FLAGS_OPENED
flag to before freeing the device buffers.

Signed-off-by: Malcolm Priestley 
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: rxtx.c [BUG] s_vGetFreeContext dead lock on null apTD.

2013-09-25T23:53:39+00:00

There seems to be race condition that the device is ndo_start_xmit
at a point where the device is closing and apTD is NULL resulting
in dead lock.

Add a NULL check to apTD and return NULL to calling functions.

This is more likely on 64 bit systems.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging/vt6656: Fix screwed up indentation in swGetOFDMControlRate

2013-09-17T14:39:27+00:00

The indentation in the swGetOFDMControlRate function is screwed up.
At first it appears that there are missing braces on a multi-line if, but
looking at history, commit dd0a774fc727ee793780197beb3f2cf80bfefa99
("staging: vt6656: card/main_usb/device use new structure names")
incorrectly indented the two lines below.

Signed-off-by: Dave Jones 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: device.h Replace typedef struct _RCB

2013-08-28T22:28:43+00:00

Replace with struct vnt_rcb

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: baseband.h re: baseband.c:877:26: sparse: incorrect type in assignment (different base types)

2013-08-28T22:28:42+00:00

sparse warnings: (new ones prefixed by >>)
...
>> drivers/staging/vt6656/baseband.c:877:26: sparse: incorrect type in assignment (different base types)
   drivers/staging/vt6656/baseband.c:877:26:    expected unsigned short [unsigned] [usertype] len
   drivers/staging/vt6656/baseband.c:877:26:    got restricted __le16 [usertype] 
>> drivers/staging/vt6656/baseband.c:880:26: sparse: incorrect type in assignment (different base types)
   drivers/staging/vt6656/baseband.c:880:26:    expected unsigned short [unsigned] [usertype] len
   drivers/staging/vt6656/baseband.c:880:26:    got restricted __le16 [usertype] 

vnt_phy_field member len should be __le16.

Reported-by: kbuild test robot 
Cc: kbuild-all@01.org
Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: device.h replace typedef struct _USB_SEND_CONTEXT.

2013-08-27T23:56:42+00:00

Replace with struct vnt_usb_send_context.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: rxtx.c s_vFillTxKey use switch for pTransmitKey->byCipherSuite

2013-08-27T23:55:34+00:00

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: rxtx.c s_vFillTxKey clean up format and white space.

2013-08-27T23:55:34+00:00

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6656: rxtx.c s_vFillRTSHead/s_vFillCTSHead move union vnt_tx_data_head up one level.

2013-08-27T23:54:39+00:00

Move
s_vFillRTSHead union vnt_tx_data_head to void *pvRTS argument.
s_vFillCTSHead union vnt_tx_data_head to void *pvCTS argument.

In s_vGenerateTxParameter create union vnt_tx_data_head
pointing to rts_cts;

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman