linux.git/drivers/staging/vt6655, branch v5.14

staging: vt6655: upc: Suppress set but not used warning in macro

2021-05-10T09:19:25+00:00

The variable is used in the function using the macro.

Fixes the following W=1 kernel build warning(s):

 drivers/staging/vt6655/upc.h:45:16: warning: variable ‘byData’ set but not used [-Wunused-but-set-variable]

Cc: Forest Bond 
Cc: Greg Kroah-Hartman 
Cc: linux-staging@lists.linux.dev
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20210414181129.1628598-28-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman

Merge v5.12-rc4 into staging-next

2021-03-22T07:55:27+00:00

We want the staging/iio fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

staging: vt665x: fix alignment constraints

2021-03-18T09:21:46+00:00

Removing 2 instances of alignment warnings

drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’ is less than 2 [-Wpacked-not-aligned]
drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]

The root cause seems to be that _because_ struct ieee80211_cts is marked as __aligned(2),
this requires any encapsulating struct to also have an alignment of 2.

Fixes: 2faf12c57efe ("staging: vt665x: fix alignment constraints")
Reviewed-by: Arnd Bergmann 
Signed-off-by: Edmundo Carmona Antoranz 
Link: https://lore.kernel.org/r/20210316181736.2553318-1-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Rename two dimensional array declaration

2021-03-16T11:36:20+00:00

Rename two dimensional array declaration to fix checkpatch warning: Avoid
Camelcase and make the declaration more readable and understandable

Signed-off-by: Madhumitha Prabakaran 
Link: https://lore.kernel.org/r/20210315004641.378933-1-madhumithabiw@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove duplicate code

2021-03-14T16:01:46+00:00

In the definition of vnt_init_bands(), there are two sections of
code that are very similar. Unifying them through a new
function that takes care of initialization of a single band.

Signed-off-by: Edmundo Carmona Antoranz 
Link: https://lore.kernel.org/r/20210314145943.1933245-3-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: correct documentation warnings

2021-03-14T16:01:44+00:00

Both arguments to set_channel have changed their names and their
types. Correct the discrepancy in the function documentation to get
rid of four warnings:

drivers/staging/vt6655/channel.c:165: warning: Function parameter or member 'priv' not described in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Function parameter or member 'ch' not described in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Excess function parameter 'pDeviceHandler' description in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Excess function parameter 'uConnectionChannel' description in 'set_channel'

Signed-off-by: Edmundo Carmona Antoranz 
Link: https://lore.kernel.org/r/20210314145943.1933245-2-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman

Staging: vt6655: Replace a camel case variable name

2021-02-11T11:13:53+00:00

Replace camel case variable names with snake case in baseband.c.

Signed-off-by: Yujia Qiao 
Link: https://lore.kernel.org/r/tencent_21CFC58E6013D47A55691E4F4C6C4CF20706@qq.com
Signed-off-by: Greg Kroah-Hartman

staging: vt665x: fix alignment constraints

2021-02-06T13:11:21+00:00

multiple structures contains a ieee80211_rts structure, which is required to
have at least two byte alignment, but are annotated with a __packed attribute
to force single-byte alignment:

staging/vt6656/rxtx.h:98:1: warning: alignment 1 of 'struct vnt_rts_g' is less than 2 [-Wpacked-not-aligned]
staging/vt6656/rxtx.h:106:1: warning: alignment 1 of 'struct vnt_rts_ab' is less than 2 [-Wpacked-not-aligned]
staging/vt6656/rxtx.h:116:1: warning: alignment 1 of 'struct vnt_cts' is less than 2 [-Wpacked-not-aligned]

I see no reason why the structure itself would be misaligned, and all members
have at least two-byte alignment within the structure, so use the same
constraint on the sturcture itself.

Signed-off-by: Arnd Bergmann 
Link: https://lore.kernel.org/r/20210204162731.3132069-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Fix fall-through warnings for Clang

2020-11-23T16:55:23+00:00

In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Remove useless else

2020-11-13T15:35:21+00:00

The else statements are not useful due to the presence of a return
statement on the if block. Remove the else statements, adjust the
indentation of the code, move variable declarations to the beginning of
their scope and remove useless return statement. Reported by checkpatch.

Signed-off-by: Marcos Antonio de Jesus Filho 
Link: https://lore.kernel.org/r/20201109025641.GA69196@Zangetsu
Signed-off-by: Greg Kroah-Hartman