linux.git/drivers/staging/vt6655, branch v5.11 Linux kernel source tree staging: vt6655: Fix fall-through warnings for Clang 2020-11-23T16:55:23+00:00 Gustavo A. R. Silva gustavoars@kernel.org 2020-11-20T18:27:44+00:00 6a8ce97113b3b26dcf3ecc6752ee556f145cb49e In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: Remove useless else 2020-11-13T15:35:21+00:00 Marcos Antonio de Jesus Filho mdejesusfilho@gmail.com 2020-11-09T02:56:41+00:00 0d79a48440f559ac939d1be2089757c5e4ab16c7 The else statements are not useful due to the presence of a return statement on the if block. Remove the else statements, adjust the indentation of the code, move variable declarations to the beginning of their scope and remove useless return statement. Reported by checkpatch. Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com> Link: https://lore.kernel.org/r/20201109025641.GA69196@Zangetsu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The else statements are not useful due to the presence of a return
statement on the if block. Remove the else statements, adjust the
indentation of the code, move variable declarations to the beginning of
their scope and remove useless return statement. Reported by checkpatch.

Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
Link: https://lore.kernel.org/r/20201109025641.GA69196@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: Fix typo 2020-10-27T11:23:44+00:00 Marcos Antonio de Jesus Filho mdejesusfilho@gmail.com 2020-10-26T20:17:14+00:00 36f18e741a232aa5543ac687e15b47213146ba56 Fix typo reported by checkpatch. Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com> Link: https://lore.kernel.org/r/20201026201714.GA24239@Zangetsu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix typo reported by checkpatch.

Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
Link: https://lore.kernel.org/r/20201026201714.GA24239@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: rearrange lines exceeding 100 columns 2020-10-26T05:53:10+00:00 Deepak R Varma mh12gx2825@gmail.com 2020-10-16T15:44:23+00:00 2ed1fa08e6748b0a9010723d404d49d07ff6ed60 Rearrange lines that are longer than 100 columns in width. Issue reported by chckpatch script. Also remove unnecessary pair of braces for single line instruction post if condition. Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> Link: https://lore.kernel.org/r/20201016154423.GA17210@ubuntu204 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Rearrange lines that are longer than 100 columns in width. Issue reported
by chckpatch script. Also remove unnecessary pair of braces for single
line instruction post if condition.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/20201016154423.GA17210@ubuntu204
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: Add spaces around arithmetic operators 2020-09-13T07:20:38+00:00 Sebastian Fuentes sefu1789@gmail.com 2020-09-12T05:23:57+00:00 9a9c1827e720fe25ee9cfbca6e10b7f78fcd39f7 This addresses the checkpatch.pl warning "spaces preferred around that '+/-/*'" Signed-off-by: Sebastian Fuentes <sefu1789@gmail.com> Link: https://lore.kernel.org/r/20200912052357.GA4707@ubuntu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This addresses the checkpatch.pl warning "spaces preferred around that
'+/-/*'"

Signed-off-by: Sebastian Fuentes <sefu1789@gmail.com>
Link: https://lore.kernel.org/r/20200912052357.GA4707@ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: Use fallthrough pseudo-keyword 2020-07-10T11:52:46+00:00 Gustavo A. R. Silva gustavoars@kernel.org 2020-07-07T19:43:50+00:00 deb34767b2b23d330aa226d5ef4209f52acfb127 Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20200707194350.GA3255@embeddedor Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200707194350.GA3255@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655/device_main.c: use generic power management 2020-07-01T13:39:21+00:00 Vaibhav Gupta vaibhavgupta40@gmail.com 2020-06-29T08:28:19+00:00 7a46931ba9a25ce73761f4015f004229df44ef13 Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essentials will be handled by the PCI core. Driver needs to do only device-specific operations. The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use device_wakeup_disable() instead. Compile-tested only. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> Link: https://lore.kernel.org/r/20200629082819.216405-5-vaibhavgupta40@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions like
pci_save/restore_state(), pci_enable/disable_device(), etc.

With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.

The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
device_wakeup_disable() instead.

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Link: https://lore.kernel.org/r/20200629082819.216405-5-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers: staging: vt6655: replace CamelCase names on function s_uGetRTSCTSRsvTime 2020-06-25T13:40:27+00:00 Rodolfo C. Villordo rodolfovillordo@gmail.com 2020-06-24T10:02:56+00:00 79e88fd45bd26ea2770b79e70cfb824a4e2e7049 Replace function and variables name from CamelCase style to snake_case style. Remove Hungarian notation. Signed-off-by: Rodolfo C. Villordo <rodolfovillordo@gmail.com> Link: https://lore.kernel.org/r/20200624100256.GA17118@ip-172-31-24-31.ec2.internal Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Replace function and variables name from CamelCase style to snake_case style.
Remove Hungarian notation.

Signed-off-by: Rodolfo C. Villordo <rodolfovillordo@gmail.com>
Link: https://lore.kernel.org/r/20200624100256.GA17118@ip-172-31-24-31.ec2.internal
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6656: vt6655: removing unused macros definition Makefiles 2020-05-15T13:49:13+00:00 Matej Dujava mdujava@kocurkovo.cz 2020-05-13T19:15:50+00:00 3abbab51321f51bdb1c64f2296644110c7a61f62 This patch is removing definition of CFLAGS in Makefile of vt6656 and vt6655, as those are defining macros that are not used. This will remove undef of one macro from vt6655/device_main.c, as it is only undef and it is not used anywhere else, so it is safe to remove it. Macros are removed from vt665x/Makefile and vt6655/device_main.c. Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz> Link: https://lore.kernel.org/r/1589397351-24655-2-git-send-email-mdujava@kocurkovo.cz Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch is removing definition of CFLAGS in Makefile of vt6656 and
vt6655, as those are defining macros that are not used. This will remove
undef of one macro from vt6655/device_main.c, as it is only undef and it is
not used anywhere else, so it is safe to remove it.

Macros are removed from vt665x/Makefile and vt6655/device_main.c.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1589397351-24655-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: fix LONG_LINE warning 2020-05-05T10:33:00+00:00 Matej Dujava mdujava@kocurkovo.cz 2020-05-03T15:42:50+00:00 0729bb9b2a97a279c4b7c7be8565d494aab3d6e9 This patch will fix LONG_LINE error from checkpatch, by using ternary operator. Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz> Link: https://lore.kernel.org/r/1588520570-14388-3-git-send-email-mdujava@kocurkovo.cz Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch will fix LONG_LINE error from checkpatch, by using ternary
operator.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588520570-14388-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>