linux.git/drivers/staging/vc04_services, branch v4.18

staging: vc04_services: no need to save the log debufs dentries

2018-06-01T18:15:56+00:00

The log entry dentries are only set, never referenced, so no need to
keep them around.  Remove the pointer from struct
vchiq_debugfs_log_entry as it is not needed anymore and get rid of the
separate vchiq_debugfs_create_log_entries() function as it is only used
in one place.

Suggested-by: Eric Anholt 
Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: vc04_services: vchiq_debugfs_log_entry can be a void *

2018-06-01T18:15:56+00:00

There's no need to set this to be int * when it is only used as a void *.
This lets us remove the unneeded cast, and unneeded temporary variable
the one place it is referenced in the code.

Suggested-by: Eric Anholt 
Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: vc04_services: remove struct vchiq_debugfs_info

2018-06-01T18:15:56+00:00

This structure, and the one static variable that was declared with it,
were not being used for anything.  The log_categories field was being
set, but never used again.  So just remove it entirely as it is not
needed at all.

Suggested-by: Eric Anholt 
Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: vc04_services: move client dbg directory into static variable

2018-06-01T18:15:56+00:00

This does not need to be part of a wrapper function, or in a structure,
just properly reference it directly as a single variable.

The whole variable will be going away soon anyway, this is just a step
toward that direction.

Suggested-by: Eric Anholt 
Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: vc04_services: remove odd vchiq_debugfs_top() wrapper

2018-06-01T18:15:56+00:00

vchiq_debugfs_top() is only a wrapper around a pointer to a dentry, so
just use the dentry directly instead, making it a static variable
instead of part of a static structure.

This also removes the pointless BUG_ON() when checking that dentry as no
one should ever care if debugfs is working or not, and the kernel should
really not panic over something as trivial as that.

Suggested-by: Eric Anholt 
Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: vc04_services: no need to check debugfs return values

2018-06-01T18:15:56+00:00

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Clean up the vchiq_arm code by not caring about the value of debugfs
calls.  This ends up removing a number of lines of code that are not
needed.

Cc: Stefan Wahren 
Cc: Kees Cook 
Cc: Dan Carpenter 
Cc: Arnd Bergmann 
Cc: Keerthi Reddy 
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: bcm2835: Use BIT_ULL macro

2018-05-14T12:05:49+00:00

This patch fixes the checkpatch.pl check hint:

CHECK: Prefer using the BIT_ULL macro

Signed-off-by: Kilian Köppchen 
Signed-off-by: Greg Kroah-Hartman

staging: bcm2835-camera: Replace open-coded idr with a struct idr.

2018-05-14T11:58:45+00:00

We just need some integer handles that can map back to our message
struct when we're handling a reply, which struct idr is perfect for.

v2: Fix error check to look at the right variable.

Signed-off-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

staging: bcm2835-camera: Fix module section mismatch warnings.

2018-05-14T09:26:02+00:00

Noticed by Stephen Rothwell in -next.

Signed-off-by: Eric Anholt 
Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.")
Reported-by: Stephen Rothwell 
Signed-off-by: Greg Kroah-Hartman

staging: bcm2835: Fix mmal_port_parameter_get() signed/unsigned warnings.

2018-05-11T10:02:06+00:00

The arg is a u32 *, so switch over to that in our declarations.

Signed-off-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman