linux.git/drivers/staging/speakup, branch v4.9

Staging: speakup: constify attribute_group structures

2016-10-02T15:14:03+00:00

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property  can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text	   data	    bss	    dec	    hex	filename
   7551	   1440	     16	   9007	   232f
drivers/staging/speakup/kobjects.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   7671	   1312	     16	   8999	   2327
drivers/staging/speakup/kobjects.o

Signed-off-by: Bhumika Goyal 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: kobjects: Add space around the operator.

2016-09-22T10:01:14+00:00

This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: varhandlers: Add space around the operator.

2016-09-22T09:56:54+00:00

This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove unnecessary parentheses

2016-09-22T09:54:47+00:00

Issue found by checkpatch.

Signed-off-by: Katie Dunne 
Signed-off-by: Greg Kroah-Hartman

speakup: Add spinlock in synth_direct_store

2016-09-12T11:13:25+00:00

All operations with synth buffer should be protected,
as there are global pointers, which should be modified atomically.

Found by Linux Driver Verification project (linuxtesting.org)

Signed-off-by: Pavel Andrianov 
Acked-by: Vaishali Thakkar 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: ensure we do not overrun synths array

2016-08-15T17:14:54+00:00

synth_add allows one to add MAXSYNTHS synths to the synths array;
however it always NULLifies the next synth in the array which
means that on the MAXSYNTHS synth we get an out-of-bounds write of
the NULL to the synths array.  Make the synths array MAXSYNTHS + 1
elements in size to allow for the final NULL sentinal to avoid the
out-of-bounds write.

Issue found wit CoverityScan, CID#744671

Signed-off-by: Colin Ian King 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Remove space after cast

2016-08-15T17:14:53+00:00

Fix the checkpatch.pl warning "No space is necessary after a cast".

Signed-off-by: Laurence Rochfort 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'staging-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging

2016-05-21T05:20:48+00:00

Pull staging and IIO driver updates from Greg KH:
 "Here's the big staging and iio driver update for 4.7-rc1.

  I think we almost broke even with this release, only adding a few more
  lines than we removed, which isn't bad overall given that there's a
  bunch of new iio drivers added.

  The Lustre developers seem to have woken up from their sleep and have
  been doing a great job in cleaning up the code and pruning unused or
  old cruft, the filesystem is almost readable :)

  Other than that, just a lot of basic coding style cleanups in the
  churn.  All have been in linux-next for a while with no reported
  issues"

* tag 'staging-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (938 commits)
  Staging: emxx_udc: emxx_udc: fixed coding style issue
  staging/gdm724x: fix "alignment should match open parenthesis" issues
  staging/gdm724x: Fix avoid CamelCase
  staging: unisys: rename misleading var ii with frag
  staging: unisys: visorhba: switch success handling to error handling
  staging: unisys: visorhba: main path needs to flow down the left margin
  staging: unisys: visorinput: handle_locking_key() simplifications
  staging: unisys: visorhba: fail gracefully for thread creation failures
  staging: unisys: visornic: comment restructuring and removing bad diction
  staging: unisys: fix format string %Lx to %llx for u64
  staging: unisys: remove unused struct members
  staging: unisys: visorchannel: correct variable misspelling
  staging: unisys: visorhba: replace functionlike macro with function
  staging: dgnc: Need to check for NULL of ch
  staging: dgnc: remove redundant condition check
  staging: dgnc: fix 'line over 80 characters'
  staging: dgnc: clean up the dgnc_get_modem_info()
  staging: lustre: lnet: enable configuration per NI interface
  staging: lustre: o2iblnd: properly set ibr_why
  staging: lustre: o2iblnd: remove last of kiblnd_tunables_fini
  ...

tty: Replace TTY_THROTTLED bit tests with tty_throttled()

2016-04-30T16:26:55+00:00

Abstract TTY_THROTTLED bit tests with tty_throttled().

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix type mismatch warnings

2016-03-28T14:30:36+00:00

Compiling speakup driver with sparse produces following warning:

drivers/staging/speakup/serialio.c:22:9: warning: incorrect type in
initializer (different base types)
drivers/staging/speakup/serialio.c:22:9:    expected unsigned int
[unsigned] flags
drivers/staging/speakup/serialio.c:22:9:    got restricted upf_t

This patch fixes it.

Signed-off-by: Okash Khawaja 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman