linux.git/drivers/staging/speakup, branch v3.3

module_param: make bool parameters really bool (drivers & misc)

2012-01-12T23:02:20+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Rusty Russell

Staging: speakup: Don't try to access an unallocated struct.

2011-11-27T02:13:55+00:00

In speakup_init, we have the following:
	if (quiet_boot)
		spk_shut_up |= 0x01;
And in spk_types.h:
This patch moves the statement in speakup_init so that
speakup_console[vc->vc_num] is guaranteed to be allocated when it
executes.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Use kmemdup rather than duplicating its implementation

2011-11-27T02:12:56+00:00

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

drivers/staging/speakup/devsynth.c: fix "buffer size is not provably correct" error

2011-08-02T23:09:46+00:00

x86_64 allmodconfig:

In file included from arch/x86/include/asm/uaccess.h:572,
                 from include/linux/uaccess.h:5,
                 from drivers/staging/speakup/devsynth.c:4:
In function 'copy_from_user',
    inlined from 'speakup_file_write' at drivers/staging/speakup/devsynth.c:28:
arch/x86/include/asm/uaccess_64.h:64: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct

I'm not sure what was unprovable about it, but size_t is the correct type
anyway.

Also replace needless min_t() with min()

Cc: William Hubbs 
Cc: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Remove unneeded version.h includes from drivers/staging/speakup/

2011-07-05T17:39:38+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Use kstrtoul_from_user

2011-06-28T21:35:41+00:00

This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Kernel Version: staging of 20110606

Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

staging: speakup: Remove NULL check before kfree

2011-03-14T18:57:36+00:00

This patch was generated by the following semantic patch:
// 
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// 

Signed-off-by: Ilia Mirkin 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: fix an out-of-bounds error.

2011-02-23T22:39:09+00:00

The cur_item variable from keyhelp.c is an index into a table of
messages.  The following condition should always hold:
MSG_FUNCNAMES_START + cur_item <= MSG_FUNCNAMES_END.
The check in keyhelp.c was wrong.  It allowed cur_item to be
incremented to an out-of-bounds value.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: enlosed macros with complex values in parenthesis

2011-02-04T21:01:02+00:00

Enclosed all macros with complex values in parenthesis

Signed-off-by: Timo von Holtz 
Signed-off-by: Greg Kroah-Hartman