linux.git/drivers/staging/speakup, branch v3.15

Staging: speakup: Update __speakup_paste_selection() tty (ab)usage to match vt

2014-05-23T17:25:11+00:00

This function is largely a duplicate of paste_selection() in
drivers/tty/vt/selection.c, but with its own selection state.  The
speakup selection mechanism should really be merged with vt.

For now, apply the changes from 'TTY: vt, fix paste_selection ldisc
handling', 'tty: Make ldisc input flow control concurrency-friendly',
and 'tty: Fix unsafe vt paste_selection()'.

References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers 
Reported-and-tested-by: Jarek Czekalski 
Signed-off-by: Ben Hutchings 
Cc:  # v3.8 but needs backporting for < 3.12
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Move pasting into a work item

2014-05-23T17:25:10+00:00

Input is handled in softirq context, but when pasting we may
need to sleep.  speakup_paste_selection() currently tries to
bodge this by busy-waiting if in_atomic(), but that doesn't
help because the ldisc may also sleep.

For bonus breakage, speakup_paste_selection() changes the
state of current, even though it's not running in process
context.

Move it into a work item and make sure to cancel it on exit.

References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers 
Reported-and-tested-by: Jarek Czekalski 
Signed-off-by: Ben Hutchings 
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

speakup: fix incorrect perms on speakup_acntsa.c

2014-05-23T16:31:35+00:00

22c9bcad859d5c969289b3b37084a96c621f8f2c contained a bad
substitution for ROOT_W => S_IRUSR|S_IRUGO instead of
S_IWUSR|S_IRUGO.

Fixes: 22c9bcad859d5c969289b3b37084a96c621f8f2c
Signed-off-by: Rusty Russell 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix misuse of kstrtol() in handle_goto()

2014-04-16T18:41:44+00:00

A string of goto_buf has a number followed by x or y.
e.g. "3x" means move 3 lines down.
The kstrtol() returns an error(-EINVAL) with this string so
go_pos has unsigned a value of that error.
And also "*cp" has not expected value.

And fix sparse warnings:
 drivers/staging/speakup/main.c:1901 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero.
 drivers/staging/speakup/main.c:1911 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero.

Signed-off-by: Daeseok Youn 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux

2014-04-06T16:38:07+00:00

Pull module updates from Rusty Russell:
 "Nothing major: the stricter permissions checking for sysfs broke a
  staging driver; fix included.  Greg KH said he'd take the patch but
  hadn't as the merge window opened, so it's included here to avoid
  breaking build"

* tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
  staging: fix up speakup kobject mode
  Use 'E' instead of 'X' for unsigned module taint flag.
  VERIFY_OCTAL_PERMISSIONS: stricter checking for sysfs perms.
  kallsyms: fix percpu vars on x86-64 with relocation.
  kallsyms: generalize address range checking
  module: LLVMLinux: Remove unused function warning from __param_check macro
  Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE
  module: remove MODULE_GENERIC_TABLE
  module: allow multiple calls to MODULE_DEVICE_TABLE() per module
  module: use pr_cont

staging: fix up speakup kobject mode

2014-04-01T03:50:26+00:00

It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.

Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).

Also, many of these are other-writable.  Is that really intended?

I'll-queue-this-patch-up-in-a-bit-by: Greg KH 
Signed-off-by: Rusty Russell

staging/speakup:speakup_dectlk.c Fix line over 80 characters.

2014-03-18T19:22:20+00:00

checkpatch.pl issues with line over
80 characters in speakup_dectlk.c

Signed-off-by: Aybuke Ozdemir 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Prefer pr_err instead of printk(KERN_ERR)

2014-03-18T18:13:37+00:00

Prefer pr_err instead of printk(KERN_ERR)

Signed-off-by: Keerthimai Janarthanan 
Signed-off-by: Greg Kroah-Hartman

mm/staging: remove unnecessary inclusion of bootmem.h

2013-11-12T00:36:05+00:00

Clean-up to remove depedency with bootmem headers.

Cc: Yinghai Lu 
Cc: Tejun Heo 
Cc: Andrew Morton 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Greg Kroah-Hartman 

Signed-off-by: Grygorii Strashko 
Signed-off-by: Santosh Shilimkar 
Signed-off-by: Greg Kroah-Hartman

drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.

2013-11-12T00:22:17+00:00

If SERIAL_PORT_DFNS isn't present by platform, it need be defined to
"nothing", like the 8250 serial driver does it.

All related macros also need be removed: IRQF_SHARED is defined in
"linux/interrupt.h", others will be defined when related architecture
has SERIAL_PORT_DFNS.

Or it will cause issue (for arc, with allmodconfig):

    CC [M]  drivers/staging/speakup/serialio.o
  drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
    SERIAL_PORT_DFNS
    ^
  drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[0].baud_base')
  drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
  drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[1].baud_base')
  drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
  drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[2].baud_base')
  drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
  drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[3].baud_base')

Signed-off-by: Chen Gang 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman