linux.git/drivers/staging/speakup, branch v3.13

Staging: speakup: replacing simple_strtoul with kstrtoul

2013-10-19T21:51:06+00:00

Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use
kstrtoul instead

Signed-off-by: Ashvini Varatharaj 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: removing jiffies comparison in speakup_apollo.c

2013-10-19T12:27:19+00:00

Fix checkpatch warning: WARNING: Comparing jiffies is almost always
wrong; prefer time_after, time_before and friends

Signed-off-by: Ashvini Varatharaj 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: removing jiffies comparison using time_after_eq()

2013-10-19T12:27:15+00:00

Fix checkpatch warning:  Comparing jiffies is almost always wrong;
prefer time_after, time_before and friends

Signed-off-by: Ashvini Varatharaj 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: remove unnecessary space before semicolon

2013-10-14T16:15:27+00:00

Removed unnecessary space before semicolon which was
leading to checkpatch.pl warning.

Signed-off-by: Nandini Hanumanthagowda 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: str initialization replaced with NULL where it was initialized with int

2013-10-03T20:50:54+00:00

Fixed warnings in all of three files where the string was initilized with an integer instead of NULL

Signed-off-by: Shalin Mehta 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects.c: Use correct values when changing voice.

2013-09-17T14:47:46+00:00

When a new voice is selected, we set volume and pitch appropriate for
the voice.  We need to use the numeric index corresponding to the
voice when indexing into the volume and pitch tables, rather than
the raw user input that was used to select the voice.
Note that using the raw input can also lead to an invalid memory read
in the case of invalid or malicious user input.

Signed-off-by: Christopher Brannon 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging/speakup/kobjects.c: Code improvement.

2013-09-17T14:47:45+00:00

Well, there is no need to use strcmp since we can make a test of similar semantic by using the var_id field of param.
I moved the test into the VAR_NUM:VAR_TIME case since VAR_STRING will never be "voice".

spk_xlate isn't used anymore (in line 628), then there is no difference between using cp and buf in VAR_STRING case.
Besides, buf is a const char and those changes remove one uneeded line.

I created the function spk_reset_default_value because it clarifies the code and allows code reusing.

Signed-off-by: Raphael S.Carvalho 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Add dependencies for ISA card drivers

2013-09-17T14:47:45+00:00

Several speakup drivers are for ISA cards and are useless on systems
without ISA slots.  Make them depend on ISA || COMPILE_TEST.

Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix warnings by adding __user annotations

2013-05-22T22:35:52+00:00

This patch fixes the following sparse warnings by adding
__user annotations.

drivers/staging/speakup/speakup_soft.c:248:34: warning:
        incorrect type in argument 1 (different address spaces)
        drivers/staging/speakup/speakup_soft.c:248:34:
        expected void [noderef] *dst
        drivers/staging/speakup/speakup_soft.c:248:34:
        got char *[assigned] cp
drivers/staging/speakup/speakup_soft.c:272:40: warning:
        incorrect type in argument 1 (different address spaces)
        drivers/staging/speakup/speakup_soft.c:272:40:
        expected char const [noderef] *s
        drivers/staging/speakup/speakup_soft.c:272:40:
        got char const *buf
drivers/staging/speakup/speakup_soft.c:306:17: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/speakup_soft.c:306:17:
        expected long ( *read )( ... )
        drivers/staging/speakup/speakup_soft.c:306:17:
        got long ( static [toplevel] * )( ... )
drivers/staging/speakup/speakup_soft.c:307:18: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/speakup_soft.c:307:18:
        expected long ( *write )( ... )
        drivers/staging/speakup/speakup_soft.c:307:18:
        got long ( static [toplevel] * )( ... )

drivers/staging/speakup/devsynth.c:29:41: warning:
        incorrect type in argument 2 (different address spaces)
        drivers/staging/speakup/devsynth.c:29:41:
        expected void const [noderef] *from
        drivers/staging/speakup/devsynth.c:29:41:    got char const *ptr
drivers/staging/speakup/devsynth.c:62:17: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/devsynth.c:62:17:
        expected long ( *read )( ... )
        drivers/staging/speakup/devsynth.c:62:17:
        got long ( static [toplevel] * )( ... )
drivers/staging/speakup/devsynth.c:63:18: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/devsynth.c:63:18:
        expected long ( *write )( ... )
        drivers/staging/speakup/devsynth.c:63:18:
        got long ( static [toplevel] * )( ... )

Signed-off-by: Emil Goode 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup/main: Staticize local symbols

2013-05-22T22:35:39+00:00

Symbols referenced only in this file are made static.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman