linux.git/drivers/staging/speakup/synth.c, branch v5.5

staging: speakup_soft: Fix alternate speech with other synths

2019-03-18T06:57:58+00:00

When switching from speakup_soft to another synth, speakup_soft would
keep calling synth_buffer_getc() from softsynthx_read.

Let's thus make synth.c export the knowledge of the current synth, so
that speakup_soft can determine whether it should be running.

speakup_soft also needs to set itself alive, otherwise the switch would
let it remain silent.

Signed-off-by: Samuel Thibault 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: refactor synths array to use a list

2018-06-17T07:05:11+00:00

The synths[] array is a collection of synths acting like a list.
There is no need for synths to be an array, so refactor synths[] to use
standard kernel list_head API, instead, and modify the usages to suit.
As a side-effect, the maximum number of synths has also become redundant.

Signed-off-by: Justin Skists 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Add unicode support to the speakup_dummy driver

2018-03-14T11:57:45+00:00

This extends spk_io_ops with a synth_out_unicode which takes a u16 character
instead of just a byte, and extends spk_ttyio to implement it to emit
utf-8. spk_do_catch_up_unicode can then be introduced to benefit from
synth_out_unicode, and speakup_dummy made to use spk_do_catch_up_unicode instead
of spk_do_catch_up.

Signed-off-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: add SPDX identifier.

2018-01-15T15:03:44+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Fix up the remaining staging speakup files to have a proper SPDX
identifier, based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

treewide: Switch DEFINE_TIMER callbacks to struct timer_list *

2017-11-21T23:57:05+00:00

This changes all DEFINE_TIMER() callbacks to use a struct timer_list
pointer instead of unsigned long. Since the data argument has already been
removed, none of these callbacks are using their argument currently, so
this renames the argument to "unused".

Done using the following semantic patch:

@match_define_timer@
declarer name DEFINE_TIMER;
identifier _timer, _callback;
@@

 DEFINE_TIMER(_timer, _callback);

@change_callback depends on match_define_timer@
identifier match_define_timer._callback;
type _origtype;
identifier _origarg;
@@

 void
-_callback(_origtype _origarg)
+_callback(struct timer_list *unused)
 { ... }

Signed-off-by: Kees Cook

timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-05T13:01:20+00:00

Drop the arguments from the macro and adjust all callers with the
following script:

  perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
    $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)

Signed-off-by: Kees Cook 
Acked-by: Geert Uytterhoeven  # for m68k parts
Acked-by: Guenter Roeck  # for watchdog parts
Acked-by: David S. Miller  # for networking parts
Acked-by: Greg Kroah-Hartman 
Acked-by: Kalle Valo  # for wireless parts
Acked-by: Arnd Bergmann 
Cc: linux-mips@linux-mips.org
Cc: Petr Mladek 
Cc: Benjamin Herrenschmidt 
Cc: Lai Jiangshan 
Cc: Sebastian Reichel 
Cc: Kalle Valo 
Cc: Paul Mackerras 
Cc: Pavel Machek 
Cc: linux1394-devel@lists.sourceforge.net
Cc: Chris Metcalf 
Cc: linux-s390@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: "James E.J. Bottomley" 
Cc: Wim Van Sebroeck 
Cc: Michael Ellerman 
Cc: Ursula Braun 
Cc: Viresh Kumar 
Cc: Harish Patil 
Cc: Stephen Boyd 
Cc: Michael Reed 
Cc: Manish Chopra 
Cc: Len Brown 
Cc: Arnd Bergmann 
Cc: linux-pm@vger.kernel.org
Cc: Heiko Carstens 
Cc: Tejun Heo 
Cc: Julian Wiedmann 
Cc: John Stultz 
Cc: Mark Gross 
Cc: linux-watchdog@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" 
Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Cc: Oleg Nesterov 
Cc: Ralf Baechle 
Cc: Stefan Richter 
Cc: Guenter Roeck 
Cc: netdev@vger.kernel.org
Cc: Martin Schwidefsky 
Cc: Andrew Morton 
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Sudip Mukherjee 
Link: https://lkml.kernel.org/r/1507159627-127660-11-git-send-email-keescook@chromium.org
Signed-off-by: Thomas Gleixner

staging: speakup: fix synth caching when synth init fails

2017-06-25T14:31:22+00:00

synths[] array caches currently loaded synths. synth_add checks
synths[] before adding a new one. It however ignores the result of
do_synth_init. So when do_synth_init fails, the failed synth is still
cached. Since, as a result module loading fails too, synth_remove -
which is responsible for removing the cached synth - is never called.
Next time the failing synth is added again it succeeds because
synth_add finds it cached inside synths[].

This patch fixes this by caching a synth only after do_synth_init
succeeds.

Signed-off-by: Okash Khawaja 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-16T12:19:41+00:00

This patch fixes the issue where TTY-migrated synths would take a while
to shut up after hitting numpad enter key. When calling synth_flush,
even though XOFF character is sent as high priority, data buffered in
TTY layer is still sent to the synth. This patch flushes that buffered
data when synth_flush is called.

It also tries to ensure that hardware flow control is enabled, by
setting CRTSCTS using tty's termios.

Reported-by: John Covici 
Signed-off-by: Okash Khawaja 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: make input functionality swappable

2017-05-15T10:31:43+00:00

This moves functions which take input from external synth, into struct
spk_io_ops. The calling code then uses serial implementation of those methods
through spk_io_ops. That way we can add a parallel TTY-based implementation and
simply replace serial with TTY. That is what the next patch in this series does.

speakup_decext.c has get_last_char function which reads the most recent
available character from the synth. This patch changes that by defining
read_buff_add callback method of spk_syth and letting that update the last_char
global character read from the synth. read_buff_add is called from ISR, so
there is a possibility for last_char to be stale. Therefore it is marked as
volatile. It also pulls a repeated get_index implementation into synth.c, to
be used as a utility function.

Signed-off-by: Okash Khawaja 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: move those functions which do outgoing serial comms, into serialio.c

2017-03-17T06:19:09+00:00

This moves spk_synth_immediate and spk_serial_synth_probe functions into
serialio.c. These functions do outgoing serial comms. The move is a step
towards collecting all serial comms in serialio.c. This also renames
spk_synth_immediate to spk_serial_synth_immediate.

Code inside those functions has not been changed. Along the way, this patch
also fixes a couple of spots which were calling spk_synth_immediate directly,
so that the calls now happen via the spk_syth struct.

Signed-off-by: Okash Khawaja 

Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman