linux.git/drivers/staging/speakup/synth.c, branch v4.10

staging: speakup: synth.c Align parenthesis

2016-11-21T10:05:30+00:00

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: synth.c Comment modifications

2016-11-21T10:05:30+00:00

Make modifications to comment style

Signed-off-by: Walt Feasel 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: synth.c Logical continuation

2016-11-21T10:05:30+00:00

Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line

Signed-off-by: Walt Feasel 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: synth.c Blank line before }

2016-11-21T10:05:30+00:00

Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Walt Feasel 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: synth.c Spaces around operators

2016-11-21T10:05:30+00:00

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|,+,-,/'

Signed-off-by: Walt Feasel 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove unnecessary parentheses

2016-09-22T09:54:47+00:00

Issue found by checkpatch.

Signed-off-by: Katie Dunne 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: ensure we do not overrun synths array

2016-08-15T17:14:54+00:00

synth_add allows one to add MAXSYNTHS synths to the synths array;
however it always NULLifies the next synth in the array which
means that on the MAXSYNTHS synth we get an out-of-bounds write of
the NULL to the synths array.  Make the synths array MAXSYNTHS + 1
elements in size to allow for the final NULL sentinal to avoid the
out-of-bounds write.

Issue found wit CoverityScan, CID#744671

Signed-off-by: Colin Ian King 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove unnecessary test in if condition

2016-03-05T22:48:04+00:00

Remove unnecessary test on synth->alive since it has already been
tested previously.

This fixes the following smatch warning:
drivers/staging/speakup/synth.c:182 spk_synth_is_alive_restart() warn:
we tested 'synth->alive' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Split the comment to fit the length

2015-01-18T00:14:16+00:00

Split the comment to fit the length.

Signed-off-by: Panir Nyan 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: remove jiffies comparison using time_after_eq()

2014-09-23T20:31:36+00:00

This patch fixes checkpatch.pl warning in files of speakup
WARNING : Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman