<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/staging/speakup/main.c, branch v5.8</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>Merge 5.6-rc7 into staging-next</title>
<updated>2020-03-23T07:01:20+00:00</updated>
<author>
<name>Greg Kroah-Hartman</name>
<email>gregkh@linuxfoundation.org</email>
</author>
<published>2020-03-23T07:01:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=6203da9803017701da5782998157d9826215059d'/>
<id>6203da9803017701da5782998157d9826215059d</id>
<content type='text'>
We need the staging/iio fixes in here as well

Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We need the staging/iio fixes in here as well

Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: main: switch multiple assignment for one assignment per line</title>
<updated>2020-03-17T13:07:55+00:00</updated>
<author>
<name>Lourdes Pedrajas</name>
<email>lu@pplo.net</email>
</author>
<published>2020-03-15T22:12:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=f23519843b01fdc266dd70ca29ef0f0a54f8b064'/>
<id>f23519843b01fdc266dd70ca29ef0f0a54f8b064</id>
<content type='text'>
One assignment per line is preferred, instead of multiple assignments.
To make it more readable.
Issue found with checkpatch.

Signed-off-by: Lourdes Pedrajas &lt;lu@pplo.net&gt;
Reviewed-by: Samuel Thibautl &lt;samuel.thibault@ens-lyon.org&gt;
Link: https://lore.kernel.org/r/20200315221247.16629-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One assignment per line is preferred, instead of multiple assignments.
To make it more readable.
Issue found with checkpatch.

Signed-off-by: Lourdes Pedrajas &lt;lu@pplo.net&gt;
Reviewed-by: Samuel Thibautl &lt;samuel.thibault@ens-lyon.org&gt;
Link: https://lore.kernel.org/r/20200315221247.16629-1-lu@pplo.net
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging/speakup: fix get_word non-space look-ahead</title>
<updated>2020-03-11T07:10:37+00:00</updated>
<author>
<name>Samuel Thibault</name>
<email>samuel.thibault@ens-lyon.org</email>
</author>
<published>2020-03-06T00:30:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=9d32c0cde4e2d1343dfb88a67b2ec6397705b32b'/>
<id>9d32c0cde4e2d1343dfb88a67b2ec6397705b32b</id>
<content type='text'>
get_char was erroneously given the address of the pointer to the text
instead of the address of the text, thus leading to random crashes when
the user requests speaking a word while the current position is on a space
character and say_word_ctl is not enabled.

Reported-on: https://github.com/bytefire/speakup/issues/1
Reported-by: Kirk Reiser &lt;kirk@reisers.ca&gt;
Reported-by: Janina Sajka &lt;janina@rednote.net&gt;
Reported-by: Alexandr Epaneshnikov &lt;aarnaarn2@gmail.com&gt;
Reported-by: Gregory Nowak &lt;greg@gregn.net&gt;
Reported-by: deedra waters &lt;deedra@the-brannons.com&gt;
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Tested-by: Alexandr Epaneshnikov &lt;aarnaarn2@gmail.com&gt;
Tested-by: Gregory Nowak &lt;greg@gregn.net&gt;
Tested-by: Michael Taboada &lt;michael@michaels.world&gt;
Cc: stable &lt;stable@vger.kernel.org&gt;
Link: https://lore.kernel.org/r/20200306003047.thijtmqrnayd3dmw@function
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
get_char was erroneously given the address of the pointer to the text
instead of the address of the text, thus leading to random crashes when
the user requests speaking a word while the current position is on a space
character and say_word_ctl is not enabled.

Reported-on: https://github.com/bytefire/speakup/issues/1
Reported-by: Kirk Reiser &lt;kirk@reisers.ca&gt;
Reported-by: Janina Sajka &lt;janina@rednote.net&gt;
Reported-by: Alexandr Epaneshnikov &lt;aarnaarn2@gmail.com&gt;
Reported-by: Gregory Nowak &lt;greg@gregn.net&gt;
Reported-by: deedra waters &lt;deedra@the-brannons.com&gt;
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Tested-by: Alexandr Epaneshnikov &lt;aarnaarn2@gmail.com&gt;
Tested-by: Gregory Nowak &lt;greg@gregn.net&gt;
Tested-by: Michael Taboada &lt;michael@michaels.world&gt;
Cc: stable &lt;stable@vger.kernel.org&gt;
Link: https://lore.kernel.org/r/20200306003047.thijtmqrnayd3dmw@function
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: refactor to use existing code in vt</title>
<updated>2019-04-19T13:09:10+00:00</updated>
<author>
<name>Okash Khawaja</name>
<email>okash.khawaja@gmail.com</email>
</author>
<published>2019-04-17T12:21:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=41f13084506aba1d50412026764cf7ad460fd9c2'/>
<id>41f13084506aba1d50412026764cf7ad460fd9c2</id>
<content type='text'>
This patch replaces speakup's implementations with calls to functions
in tty/vt/selection.c. Those functions are:

cancel_selection()
set_selection_kernel()
paste_selection()

Currently setting selection is done in interrupt context. However,
set_selection_kernel() can sleep - for instance, it requires console_lock
which can sleep. Therefore we offload that work to a work_struct thread,
following the same pattern which was already set for paste_selection().
When setting selection, we also get a reference to tty and make sure to
release the reference before returning.

struct speakup_paste_work has been renamed to the more generic
speakup_selection_work because it is now used for both pasting as well
as setting selection. When paste work is cancelled, the code wasn't
setting tty to NULL. This patch also fixes that by setting tty to NULL
so that in case of failure we don't get EBUSY forever.

Signed-off-by: Okash Khawaja &lt;okash.khawaja@gmail.com&gt;
Reviewed-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Tested-by: Gregory Nowak &lt;greg@gregn.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch replaces speakup's implementations with calls to functions
in tty/vt/selection.c. Those functions are:

cancel_selection()
set_selection_kernel()
paste_selection()

Currently setting selection is done in interrupt context. However,
set_selection_kernel() can sleep - for instance, it requires console_lock
which can sleep. Therefore we offload that work to a work_struct thread,
following the same pattern which was already set for paste_selection().
When setting selection, we also get a reference to tty and make sure to
release the reference before returning.

struct speakup_paste_work has been renamed to the more generic
speakup_selection_work because it is now used for both pasting as well
as setting selection. When paste work is cancelled, the code wasn't
setting tty to NULL. This patch also fixes that by setting tty to NULL
so that in case of failure we don't get EBUSY forever.

Signed-off-by: Okash Khawaja &lt;okash.khawaja@gmail.com&gt;
Reviewed-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Tested-by: Gregory Nowak &lt;greg@gregn.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: fix line over 80 characters.</title>
<updated>2019-03-01T08:05:00+00:00</updated>
<author>
<name>Bhagyashri Dighole</name>
<email>digholebhagyashri@gmail.com</email>
</author>
<published>2019-02-28T12:29:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=e2d55017ae1ce44247d03c1612e9b724ceff1388'/>
<id>e2d55017ae1ce44247d03c1612e9b724ceff1388</id>
<content type='text'>
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".

Signed-off-by: Bhagyashri Dighole &lt;digholebhagyashri@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".

Signed-off-by: Bhagyashri Dighole &lt;digholebhagyashri@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Note that simple_strtoul can't simply be replaced by kstrtoul</title>
<updated>2019-02-26T10:50:17+00:00</updated>
<author>
<name>Samuel Thibault</name>
<email>samuel.thibault@ens-lyon.org</email>
</author>
<published>2019-02-23T19:42:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=615cba3557f1bad6061acde2067a3edbf80d90c2'/>
<id>615cba3557f1bad6061acde2067a3edbf80d90c2</id>
<content type='text'>
We often receive patches which erroneously try to use kstrtoul in these
places.

Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We often receive patches which erroneously try to use kstrtoul in these
places.

Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: use true/false instead of 1/0</title>
<updated>2018-05-15T07:31:38+00:00</updated>
<author>
<name>Samuel Thibault</name>
<email>samuel.thibault@ens-lyon.org</email>
</author>
<published>2018-05-14T20:57:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d1598d4e3b1c26215b70c8d7ea6dd1ec6d478bf9'/>
<id>d1598d4e3b1c26215b70c8d7ea6dd1ec6d478bf9</id>
<content type='text'>
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Fix coding style</title>
<updated>2018-05-14T11:34:33+00:00</updated>
<author>
<name>Samuel Thibault</name>
<email>samuel.thibault@ens-lyon.org</email>
</author>
<published>2018-05-13T09:38:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=fbae47076e9307154fac38d57b260e8dd7c79b1d'/>
<id>fbae47076e9307154fac38d57b260e8dd7c79b1d</id>
<content type='text'>
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Add pause command used on switching to graphical mode</title>
<updated>2018-05-07T02:02:37+00:00</updated>
<author>
<name>Samuel Thibault</name>
<email>samuel.thibault@ens-lyon.org</email>
</author>
<published>2018-05-02T00:56:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=2610df41489f548e235171b86895d4b49e6acb1f'/>
<id>2610df41489f548e235171b86895d4b49e6acb1f</id>
<content type='text'>
For software speech syntheses to be able to manage concurrent audio card
access, they need to know when speakup stops emitting text to be spoken
because the console has switched to graphical mode.  This introduces a
PAUSE command to do so.

Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For software speech syntheses to be able to manage concurrent audio card
access, they need to know when speakup stops emitting text to be spoken
because the console has switched to graphical mode.  This introduces a
PAUSE command to do so.

Signed-off-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: match alignment with open parenthesis</title>
<updated>2018-03-06T12:01:10+00:00</updated>
<author>
<name>Santha Meena Ramamoorthy</name>
<email>santhameena13@gmail.com</email>
</author>
<published>2018-03-05T17:34:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=accb9343f58c6750c328645ca4b87fdf0fef3623'/>
<id>accb9343f58c6750c328645ca4b87fdf0fef3623</id>
<content type='text'>
Match alignment with the open parenthesis to conform to the Linux kernel
coding style. Issue found using checkpatch.

Signed-off-by: Santha Meena Ramamoorthy &lt;santhameena13@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Match alignment with the open parenthesis to conform to the Linux kernel
coding style. Issue found using checkpatch.

Signed-off-by: Santha Meena Ramamoorthy &lt;santhameena13@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
