linux.git/drivers/staging/speakup/main.c, branch v4.14

staging: speakup: fix speakup-r empty line lockup

2017-09-18T10:25:31+00:00

When cursor is at beginning of an empty or whitespace-only line and
speakup-r typed, kernel locks up. This happens because deadlock of in
input_event function over dev->event_lock, as demonstrated by lockdep
logs. The reason for that is speakup simulates a down arrow - because
cursor is at an empty line - while inside key press notifier handler
which is ultimately triggered from input_event function. The simulated
key press leads to input_event being called again, this time under its
own context. So the spinlock is dev->event_lock is acquired while still
being held.

This patch ensures that key press is not simulated from inside key press
notifier handler. Instead it delegates to cursor_timer. It starts the
timer and passes RA_DOWN_ARROW as argument. When timer handler runs and
sees RA_DOWN_ARROW, it will then call kbd_fakekey2(RA_DOWN_ARROW) which
will correctly simulate the keypress inside timer context.

When not inside key press notifier callback, the behaviour will remain
the same as before this patch.

Signed-off-by: Okash Khawaja 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: safely register and unregister ldisc

2017-07-18T07:03:22+00:00

This patch makes use of functions added in the previous patch. It
registers ldisc during init of main speakup module and unregisters it
during exit. It also removes the code to register ldisc every time a
synth module is loaded. This way we only register the ldisc once when
main speakup module is loaded. Since main speakup module is required by
all synth modules, it is only unloaded when all synths have been
unloaded. Therefore we unregister the ldisc once, when all speakup
related references to the ldisc have returned. In unlikely scenario of
something outside speakup using the ldisc, the ldisc refcount check in
tty_unregister_ldisc will ensure that it is not unregistered while in
use.

The function to register ldisc doesn't cause speakup init function to
fail. That is different from current behaviour where failure to register
ldisc results in failure to load the specific synth module. This is
because speakup module is also required by those synths which don't use
tty and ldisc. We don't want to prevent those modules from loading when
ldisc fails to register. The synth modules will correctly fail when
trying to set N_SPEAKUP to tty, if ldisc registrationi had failed.

Signed-off-by: Okash Khawaja 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Add missing blank line after declaration

2017-06-13T12:59:21+00:00

This patch fixes checkpatch warnings about adding a blank line after
variable declaration.

Signed-off-by: Alexandre Ghiti 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove the explicit NULL comparison

2017-03-27T12:00:41+00:00

Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: use speakup_allocate as per required context

2017-03-27T11:51:32+00:00

speakup_allocate used GFP_ATOMIC for allocations
even while during initialization due to it's use
in notifier call.

Pass GFP_ flags as well to speakup_allocate depending
on the context it is called in.

Signed-off-by: Pranay Kr. Srivastava 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Match alignment with open parenthesis.

2017-03-23T13:20:41+00:00

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Moved OR operator to previous line.

2017-03-23T13:20:41+00:00

Moved logical OR operator to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-23T13:20:41+00:00

This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Moved logical to previous line.

2017-03-23T13:20:40+00:00

Moved logical operator to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

remove unnecessary initial allocation of vc

2017-03-23T13:16:52+00:00

This patch removes the unnecessary allocation of
current foreground vc during initialization.

This initialization is already handled in the loop
that follows it for all available virtual consoles.

Signed-off-by: Pranay Kr. Srivastava 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman