linux.git/drivers/staging/speakup/main.c, branch v3.10

staging: speakup: reuse native kernel functions

2013-03-29T15:41:15+00:00

We have simple_strtoul and simple_strtol. Don't repeat their functionality
here.

Signed-off-by: Andy Shevchenko 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Turn some symbols static

2013-01-07T22:08:15+00:00

Turn static some symbols which do not actually need to be
externally-visible

Signed-off-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Prefix externally-visible symbols

2013-01-07T22:06:31+00:00

This prefixes all externally-visible symbols of speakup with "spk_".

Signed-off-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: fix an improperly-declared variable.

2012-06-19T00:13:06+00:00

A local static variable was declared as a pointer to a string
constant.  We're assigning to the underlying memory, so it
needs to be an array instead.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

vt:tackle kbd_table

2012-03-08T18:50:35+00:00

Keyboard struct lifetime is easy, but the locking is not and is completely
ignored by the existing code. Tackle this one head on

- Make the kbd_table private so we can run down all direct users
- Hoick the relevant ioctl handlers into the keyboard layer
- Lock them with the keyboard lock so they don't change mid keypress
- Add helpers for things like console stop/start so we isolate the poking
  around properly
- Tweak the braille console so it still builds

There are a couple of FIXME locking cases left for ioctls that are so hideous
they should be addressed in a later patch. After this patch the kbd_table is
private and all the keyboard jiggery pokery is in one place.

This update fixes speakup and also a memory leak in the original.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Don't try to access an unallocated struct.

2011-11-27T02:13:55+00:00

In speakup_init, we have the following:
	if (quiet_boot)
		spk_shut_up |= 0x01;
And in spk_types.h:
This patch moves the statement in speakup_init so that
speakup_console[vc->vc_num] is guaranteed to be allocated when it
executes.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

Remove unneeded version.h includes from drivers/staging/speakup/

2011-07-05T17:39:38+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove NULL check before kfree

2011-03-14T18:57:36+00:00

This patch was generated by the following semantic patch:
// 
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// 

Signed-off-by: Ilia Mirkin 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: more fixes for init-failure handling.

2011-01-20T23:58:16+00:00

We still leaked many resources when Speakup failed to initialize.
Examples of leaked resources include:
/dev/synth, keyboard or VT notifiers, and heap-allocated st_spk_t
structs.
This is fixed.

* We now use PTR_ERR to detect kthread_create failure
(thank you Dan Carpenter).

* The loop which frees members of the speakup_console array now iterates
over the whole array, not stopping at the first NULL value.  Fixes
a possible memory leak.  Safe because kfree(NULL) is a no-op.

* The order of some initializations was changed.  The safe ones, which
will never fail, are performed first.

Signed-off-by: Christopher Brannon 
Acked-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix failure handling

2011-01-10T20:26:10+00:00

fix the failure handling in kobjects and the main function so that we
release the virtual keyboard if we exit due to another failure.

Signed-off-by: William Hubbs 
Signed-off-by: Greg Kroah-Hartman