linux.git/drivers/staging/speakup/kobjects.c, branch v4.19

staging: speakup: Replace strncpy with memcpy

2018-07-02T08:39:06+00:00

gcc 8.1.0 generates the following warnings.

drivers/staging/speakup/kobjects.c: In function 'punc_store':
drivers/staging/speakup/kobjects.c:522:2: warning:
	'strncpy' output truncated before terminating nul
	copying as many bytes from a string as its length
drivers/staging/speakup/kobjects.c:504:6: note: length computed here

drivers/staging/speakup/kobjects.c: In function 'synth_store':
drivers/staging/speakup/kobjects.c:391:2: warning:
	'strncpy' output truncated before terminating nul
	copying as many bytes from a string as its length
drivers/staging/speakup/kobjects.c:388:8: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: add SPDX identifier.

2018-01-15T15:03:44+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Fix up the remaining staging speakup files to have a proper SPDX
identifier, based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Removed Unnecessary parentheses.

2017-03-23T13:20:41+00:00

Unnecessary parentheses are removed to improve readability.

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix "Alignment match open parenthesis"

2017-03-13T22:07:43+00:00

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".

Signed-off-by: Arushi Singhal 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: Delete comparison

2017-03-09T13:29:40+00:00

Comparison to NULL is not necessary because 'if' statement tests if
'synth' is NULL anyway.

Delete comparison in 'if' structure to fix the checkpath.pl issue :
CHECK: Comparison to NULL could be written 'synth'.

Signed-off-by: Tamara Diaconita 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: Rearrange headers

2017-03-09T13:29:40+00:00

Put a part from the headers of some functions in a new line to have less than
80 characters.

Fixed the checkpath.pl issue:
CHECK: line over 80 characters.

Signed-off-by: Tamara Diaconita 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: Align the code

2017-03-09T13:29:40+00:00

Fixed the checkpath.pl issue:
CHECK: Aligment should match open paranthesis.

Added and deleted spaces and tabs to align the code.

Signed-off-by: Tamara Diaconita 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: Delete blank line

2017-03-09T13:29:40+00:00

Delet the blank line after an open brace '{' to fix the checkpath.pl issue:
CHECK: Blank lines aren't necessary after an open brace '{'.

Signed-off-by: Tamara Diaconita 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: Delete space

2017-03-09T13:28:21+00:00

Added a space after multiple casts to fix the checkpath.pl issue:
CHECK: No space is necessary after a cast.

Signed-off-by: Tamara Diaconita 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Replace BUG_ON() with WARN_ON().

2017-03-06T08:17:05+00:00

BUG_ON() is replaced with WARN_ON() and EINVAL is returned, when
WARN_ON() is true. This fixes the following checkpatch issue:

Avoid crashing the kernel - try using WARN_ON & recovery code rather
than BUG() or BUG_ON().

Signed-off-by: Varsha Rao 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman