linux.git/drivers/staging/speakup/kobjects.c, branch v4.10

Staging: speakup: constify attribute_group structures

2016-10-02T15:14:03+00:00

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property  can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text	   data	    bss	    dec	    hex	filename
   7551	   1440	     16	   9007	   232f
drivers/staging/speakup/kobjects.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   7671	   1312	     16	   8999	   2327
drivers/staging/speakup/kobjects.o

Signed-off-by: Bhumika Goyal 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: kobjects: Add space around the operator.

2016-09-22T10:01:14+00:00

This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar 
Signed-off-by: Greg Kroah-Hartman

speakup: Add spinlock in synth_direct_store

2016-09-12T11:13:25+00:00

All operations with synth buffer should be protected,
as there are global pointers, which should be modified atomically.

Found by Linux Driver Verification project (linuxtesting.org)

Signed-off-by: Pavel Andrianov 
Acked-by: Vaishali Thakkar 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Add space around '|'

2016-03-05T22:48:04+00:00

Add space around operator '|'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '|' (ctx:VxV)

Signed-off-by: Dilek Uzulmez 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: kobjects.c: Remove explicit NULL comparison

2015-09-13T01:25:00+00:00

Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:

@replace_rule@
expression e;
@@

-e == NULL
+ !e

Signed-off-by: Shraddha Barke 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Fix warning reported by checkpatch

2015-08-15T00:38:16+00:00

This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines

Signed-off-by: Aleksey Fedotov 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Remove unused variable

2015-03-09T12:30:40+00:00

This patch removes variable that was used to store only the return value of a function call.

The issue was detected and resolved using the following coccinelle script:

@@
expression ret;
identifier f;
@@

 -ret =
 +return
    f(...);
 -return ret;

Signed-off-by: Haneen Mohammed 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Combine the consecutive string

2015-01-18T00:14:16+00:00

Combine the consecutive string

Signed-off-by: Panir Nyan 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Change char * array type as static const

2014-10-20T02:29:12+00:00

This patch fixes "char * array declaration might be better as static const"
checkpatch.pl warning in kobjects.c

Signed-off-by: Ebru Akagunduz 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Fixed else after return or break warning

2014-10-20T02:29:12+00:00

The following patch fixes the checkpatch.pl warning:

drivers/staging/speakup/kobjects.c:812 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu 
Signed-off-by: Greg Kroah-Hartman